Skip to content

Commit 2013a4b

Browse files
Zhen Leiarndb
authored andcommitted
arm64: dts: broadcom: clear the warnings caused by empty dma-ranges
The scripts/dtc/checks.c requires that the node have empty "dma-ranges" property must have the same "#address-cells" and "#size-cells" values as the parent node. Otherwise, the following warnings is reported: arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \ (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \ its #address-cells (1) differs from / (2) arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \ (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \ its #size-cells (1) differs from / (2) Arnd Bergmann figured out why it's necessary: Also note that the #address-cells=<1> means that any device under this bus is assumed to only support 32-bit addressing, and DMA will have to go through a slow swiotlb in the absence of an IOMMU. Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20201016090833.1892-2-thunder.leizhen@huawei.com' Acked-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent f8394f2 commit 2013a4b

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,20 @@
55
usb {
66
compatible = "simple-bus";
77
dma-ranges;
8-
#address-cells = <1>;
9-
#size-cells = <1>;
10-
ranges = <0x0 0x0 0x68500000 0x00400000>;
8+
#address-cells = <2>;
9+
#size-cells = <2>;
10+
ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
1111

1212
usbphy0: usb-phy@0 {
1313
compatible = "brcm,sr-usb-combo-phy";
14-
reg = <0x00000000 0x100>;
14+
reg = <0x0 0x00000000 0x0 0x100>;
1515
#phy-cells = <1>;
1616
status = "disabled";
1717
};
1818

1919
xhci0: usb@1000 {
2020
compatible = "generic-xhci";
21-
reg = <0x00001000 0x1000>;
21+
reg = <0x0 0x00001000 0x0 0x1000>;
2222
interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
2323
phys = <&usbphy0 1>, <&usbphy0 0>;
2424
phy-names = "phy0", "phy1";
@@ -28,7 +28,7 @@
2828

2929
bdc0: usb@2000 {
3030
compatible = "brcm,bdc-v0.16";
31-
reg = <0x00002000 0x1000>;
31+
reg = <0x0 0x00002000 0x0 0x1000>;
3232
interrupts = <GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>;
3333
phys = <&usbphy0 0>, <&usbphy0 1>;
3434
phy-names = "phy0", "phy1";
@@ -38,21 +38,21 @@
3838

3939
usbphy1: usb-phy@10000 {
4040
compatible = "brcm,sr-usb-combo-phy";
41-
reg = <0x00010000 0x100>;
41+
reg = <0x0 0x00010000 0x0 0x100>;
4242
#phy-cells = <1>;
4343
status = "disabled";
4444
};
4545

4646
usbphy2: usb-phy@20000 {
4747
compatible = "brcm,sr-usb-hs-phy";
48-
reg = <0x00020000 0x100>;
48+
reg = <0x0 0x00020000 0x0 0x100>;
4949
#phy-cells = <0>;
5050
status = "disabled";
5151
};
5252

5353
xhci1: usb@11000 {
5454
compatible = "generic-xhci";
55-
reg = <0x00011000 0x1000>;
55+
reg = <0x0 0x00011000 0x0 0x1000>;
5656
interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
5757
phys = <&usbphy1 1>, <&usbphy2>, <&usbphy1 0>;
5858
phy-names = "phy0", "phy1", "phy2";
@@ -62,7 +62,7 @@
6262

6363
bdc1: usb@21000 {
6464
compatible = "brcm,bdc-v0.16";
65-
reg = <0x00021000 0x1000>;
65+
reg = <0x0 0x00021000 0x0 0x1000>;
6666
interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
6767
phys = <&usbphy2>;
6868
phy-names = "phy0";

0 commit comments

Comments
 (0)