fix: apply force_to_bytes to readline result in non-term_mode path#2707
Merged
Conversation
Contributor
Author
|
The CI failure appears to be pre-existing and unrelated to this change |
peace-maker
approved these changes
Apr 3, 2026
peace-maker
left a comment
peace-maker
left a comment
Member
There was a problem hiding this comment.
Thank you, this is cleaner. @Arusekk ?
Arusekk
approved these changes
Apr 4, 2026
peace-maker
enabled auto-merge (squash)
April 5, 2026 20:43
peace-maker
disabled auto-merge
April 7, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readline()calls.rstrip(b'\n')on the result ofsys.stdin.readline(), which returns astrwhensys.stdin.bufferis unavailable, causing aTypeError. Applied the existingforce_to_bytes()helper to ensure the result is always bytes before.rstrip()is called.Fixes #2584