chore(actions): tidy workflows and script layout

Author: dgibbs64

…rkflows/details-check-generate-matrix.sh …scripts/details-check-generate-matrix.sh.github/workflows/details-check-generate-matrix.sh renamed to .github/scripts/details-check-generate-matrix.sh .github/workflows/details-check-generate-matrix.sh renamed to .github/scripts/details-check-generate-matrix.sh

@@ -22,20 +22,4 @@ for csv in "${csvlist[@]}"; do
 	fi
 done
 
-# Compare all game servers listed in serverlist.csv to $shortname-icon.png files in ${datadir}/gameicons
-# if the game server is listed in serverlist.csv then it will have a $shortname-icon.png file
-
-# loop though shortname in serverlist.csv
-echo ""
-echo "Checking that all the game servers listed in serverlist.csv have a shortname-icon.png file"
-for shortname in $(tail -n +2 serverlist.csv | cut -d ',' -f1); do
-	# check if $shortname-icon.png exists
-	if [ ! -f "gameicons/${shortname}-icon.png" ]; then
-		echo "ERROR: gameicons/${shortname}-icon.png does not exist"
-		exitcode=1
-	else
-		echo "OK: gameicons/${shortname}-icon.png exists"
-	fi
-done
-
 exit "${exitcode}"

…kflows/serverlist-validate-game-icons.sh …cripts/serverlist-validate-game-icons.sh.github/workflows/serverlist-validate-game-icons.sh renamed to .github/scripts/serverlist-validate-game-icons.sh .github/workflows/serverlist-validate-game-icons.sh renamed to .github/scripts/serverlist-validate-game-icons.sh

@@ -24,7 +24,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Generate matrix with generate-matrix.sh
-        run: chmod +x .github/workflows/details-check-generate-matrix.sh; .github/workflows/details-check-generate-matrix.sh
+        run: .github/scripts/details-check-generate-matrix.sh
 
       - name: Set Matrix
         id: set-matrix

.github/workflows/serverlist-validate.sh .github/scripts/serverlist-validate.sh.github/workflows/serverlist-validate.sh renamed to .github/scripts/serverlist-validate.sh

@@ -15,7 +15,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Compare Versions
-        run: chmod +x .github/workflows/serverlist-validate.sh; .github/workflows/serverlist-validate.sh
+        run: .github/scripts/serverlist-validate.sh
 
       - name: Validate Game Icons
-        run: chmod +x .github/workflows/serverlist-validate-game-icons.sh; .github/workflows/serverlist-validate-game-icons.sh
+        run: .github/scripts/serverlist-validate-game-icons.sh

.github/workflows/version-check.sh .github/scripts/version-check.sh.github/workflows/version-check.sh renamed to .github/scripts/version-check.sh

@@ -14,4 +14,4 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Version Check
-        run: chmod +x .github/workflows/version-check.sh; .github/workflows/version-check.sh
+        run: .github/scripts/version-check.sh