Skip to content

fix(install_config): replace cp -nv with explicit file existence check #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgibbs64 merged 3 commits into from
Apr 19, 2026
+28 −5
Merged

fix(install_config): replace cp -nv with explicit file existence check #4897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8055e86
fix(install_config): replace cp -nv with explicit file existence check
dgibbs64 Apr 19, 2026
ad890c6
fix(install_config): use -e and -L checks to handle broken symlinks
dgibbs64 Apr 19, 2026
953758f
Merge branch 'develop' into fix/install-config-cp-portability
dgibbs64 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions lgsm/modules/install_config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,13 @@ fn_default_config_remote() {
if [ "${config}" == "${servercfgdefault}" ]; then
mkdir -p "${servercfgdir}"
echo -en "copying config file [ ${italic}${servercfgfullpath}${default} ]"
changes+=$(cp -nv "${lgsmdir}/config-default/config-game/${config}" "${servercfgfullpath}")
exitcode=$?
if [ ! -e "${servercfgfullpath}" ] && [ ! -L "${servercfgfullpath}" ]; then
cp "${lgsmdir}/config-default/config-game/${config}" "${servercfgfullpath}"
exitcode=$?
[ "${exitcode}" -eq 0 ] && changes="copied"
else
exitcode=0
fi
if [ "${exitcode}" -ne 0 ]; then
fn_print_fail_eol_nl
fn_script_log_fail "copying config file ${servercfgfullpath}"
Expand All @@ -48,7 +53,13 @@ fn_default_config_remote() {
elif [ "${shortname}" == "arma3" ] && [ "${config}" == "${networkcfgdefault}" ]; then
mkdir -p "${servercfgdir}"
echo -en "copying config file [ ${italic}${networkcfgfullpath}${default} ]"
changes+=$(cp -nv "${lgsmdir}/config-default/config-game/${config}" "${networkcfgfullpath}")
if [ ! -e "${networkcfgfullpath}" ] && [ ! -L "${networkcfgfullpath}" ]; then
cp "${lgsmdir}/config-default/config-game/${config}" "${networkcfgfullpath}"
exitcode=$?
[ "${exitcode}" -eq 0 ] && changes="copied"
else
exitcode=0
fi
if [ "${exitcode}" -ne 0 ]; then
fn_print_fail_eol_nl
fn_script_log_fail "copying config file ${networkcfgdefault}"
Expand All @@ -60,7 +71,13 @@ fn_default_config_remote() {
fi
elif [ "${shortname}" == "dst" ] && [ "${config}" == "${clustercfgdefault}" ]; then
echo -en "copying config file [ ${italic}${clustercfgfullpath}${default} ]"
changes+=$(cp -nv "${lgsmdir}/config-default/config-game/${clustercfgdefault}" "${clustercfgfullpath}")
if [ ! -e "${clustercfgfullpath}" ] && [ ! -L "${clustercfgfullpath}" ]; then
cp "${lgsmdir}/config-default/config-game/${clustercfgdefault}" "${clustercfgfullpath}"
exitcode=$?
[ "${exitcode}" -eq 0 ] && changes="copied"
else
exitcode=0
fi
if [ "${exitcode}" -ne 0 ]; then
fn_print_fail_eol_nl
fn_script_log_fail "copying config file ${clustercfgfullpath}"
Expand All @@ -72,7 +89,13 @@ fn_default_config_remote() {
fi
else
echo -en "copying config file [ ${italic}${servercfgdir}/${config}${default} ]"
changes+=$(cp -nv "${lgsmdir}/config-default/config-game/${config}" "${servercfgdir}/${config}")
if [ ! -e "${servercfgdir}/${config}" ] && [ ! -L "${servercfgdir}/${config}" ]; then
cp "${lgsmdir}/config-default/config-game/${config}" "${servercfgdir}/${config}"
exitcode=$?
[ "${exitcode}" -eq 0 ] && changes="copied"
else
exitcode=0
fi
if [ "${exitcode}" -ne 0 ]; then
fn_print_fail_eol_nl
fn_script_log_fail "copying config file ${servercfgdir}/${config}"
Expand Down
Loading