Skip to content

Commit e2d85e3

Browse files
committed
Use file for release notes in build workflow
Generating release notes via a temporary file instead of an inline string argument improves readability and avoids potential shell escaping issues with the gh release command.
1 parent a7f42fa commit e2d85e3

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/build.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,8 @@ jobs:
171171
run: |
172172
VERSION="${{ steps.etl.outputs.version }}"
173173
174-
gh release create "v${VERSION}" \
175-
--title "ET:Legacy v${VERSION} i386 Server for LinuxGSM" \
176-
--notes "## ET:Legacy v${VERSION} Linux i386 Server for LinuxGSM
174+
cat > release-notes.md <<EOF
175+
## ET:Legacy v${VERSION} Linux i386 Server for LinuxGSM
177176

178177
Built from:
179178
- [ET:Legacy v${VERSION}](https://www.etlegacy.com/download) Linux i386 server archive
@@ -189,8 +188,13 @@ MD5 : ${MD5}
189188

190189
### LinuxGSM download URL
191190
\`\`\`
192-
https://github.com/${{ github.repository }}/releases/download/v${VERSION}/${OUTPUT}
193-
\`\`\`" \
191+
https://github.com/${GITHUB_REPOSITORY}/releases/download/v${VERSION}/${OUTPUT}
192+
\`\`\`
193+
EOF
194+
195+
gh release create "v${VERSION}" \
196+
--title "ET:Legacy v${VERSION} i386 Server for LinuxGSM" \
197+
--notes-file release-notes.md \
194198
"$OUTPUT"
195199

196200
echo "Release v${VERSION} created with ${OUTPUT} (MD5: ${MD5})"

0 commit comments

Comments
 (0)