New module: Reeling Rods (#1104)

* Initial Commit

* Fix Version Compat

* Add player gamemode check

* Fix Allay HandItems[0] being removed instead of set empty

* Add shulker pulling

* Fix minecart fishing bobber vertical displacement off by 0.00001

* Fix Allay item summon wrong location

* Add witch potion stealing

* Slight python change

* Add villager theft

* Python changes to allow baby mobs to be processed

* Add fox theft

* Add witch theft limit

* Add pig desaddling

* Add strider desaddling

* Add snow golem beheading

* Add entity TODO list

* Add wolf armor stealing

* Add horse type mob item yoinking

* Fix Donkey and Mule code a bit

* Add Llama yoinking

* Python refactor & the start of Dismounting work

* Remove witch limit

* Fix file new line issue

* Switch to id based system for entity selection

* Intial commit for id changes

* Fix everything

* overwrite old

* actual overwrite old

* minor text fixes

* more fixes from the id change

* Fix wrong command syntax :(

* Re-Add smithed.entity ignore

* Change id tags to be removed when unneeded

* Vehicle separation passenger transfer

* Add live catch to recommended

* Misc comments because I need these file changes on my laptop to work on this while not at home

* misc beet changes

* py comment restructure

* Refactor in prep for generic item yoinking

* Refactor & Add Generic Hand/Armor Yoinking

* Update to 1.21.5

* Some comment changes

* Missed changes for 1.21.5

* Fix shulker teleporting

* Fix chest boat yoinking

* Rename function for clarity

* Add Sheep shearing yoinking

* Fix sheep wool yoinking
I was rushing before

* Fixes (hopefully)

* Add Binding blocking for equipment theft

* Add Entities
- Wandering Trader: Steal Hands
- Armor Stand: Steal Equipment
- Camel: Steal Saddle
- Mooshroom: Shear and steal shrooms
- Bee: Steal honey comb and suffer the consequences

* Optimize bobber id setting

* single comment change because nobody can stop me

* Fix my id changes & add sounds :D

* Change some player selectors to `@p`

* Change a few more player selectors to @p

* Shorten bee anger time

* Add Barbed Enchantment (#2)

* Add Barbed Enchantment

* Fix formatting

* Update apply_barbed_damage header

* Add missing comma

* Remove extra line

* Update non_treasure.json to include barbed

Needed for it to show up in enchanting table

* Fix barbed damage not running

* Increase Barbed Damage

* Adjust Enchantment Cost

---------

Co-authored-by: runcows <124551271+runcows@users.noreply.github.com>

* Fix overassigning ID causing breakage

* Adjust enchantment cost & rarity

* Remove excess entity_data storage

* Add Barbed Delayed Damage

* Fix Bleeding Damage not Starting

* Adjust Damage & Particles

* Add Custom Death Messages

* Adjust Enchantment Weights

* Fix Death Messages & Properly Reset Players on Respawn

* Fix Bleeding Damage not Triggering for non-Player Entities

* ID rewrite to use scores & optimization

* Swap enchantment name for translation string

* Big Reorganization

* Add Bloo to credits

* Missed renaming for reorganization

* minor changes

* Fix item data not being reset all the time

* Change barbed to explode tnt minecarts

* Rework hooked_entity/select_type to use bolt in file instead of generating file

* Add drop chance usage to reeling

* Drop Chance Rework
- if 0%, playsound and fail
- else, yoink
- there are exceptions for stealing mainhand
Also did some reorganization to make this easier to update in the future

* Formatting Changes

* Update to 1.21.6
- extend leash knot search range to 12 blocks
- add happy_ghast to leashable tag list
- add happy_ghast harness reeling

* Fix item frame yoinking not respecting fixed tag

* Set module to not run if hooked entity is Invulnerable

* Upload Icon

* Uncomment Icon Design in beet.yaml

* Initial Guidebook and Readme

* Automated Guidebook Building Stuff

* Update gm4_reeling_rods/data/gm4_reeling_rods/function/id/loop.mcfunction

Co-authored-by: Bloo <git@bloo.boo>

* Update gm4_reeling_rods/data/gm4_reeling_rods/function/tick.mcfunction

Co-authored-by: Bloo <git@bloo.boo>

* A couple of header comments

* Update gm4_reeling_rods/generate_files.py

* Fail minecart & mooshroom if passengers

* Optimize reeling/stealable/steal_hand

* Clean `generate_files.py` and move a tag command

* Add enderman falling block yoinking, fix a logical error with motion function, adjust a few commands

* Update get_motion_to_player header comment

* Update gm4_reeling_rods/data/gm4_reeling_rods/function/get_motion_to_player.mcfunction
- Swear this is the last time. I got all nitpicky about the comments

* Translations file

* Forgot key in translations

* Add Panda to steal hand
- because I forgot them

* Update header in get_execution_pos

* Guidebook pages for reeling and barbed now unlock when getting an enchanted book with them on it

* Reword Guidebook Pages

* Add unreleased modrinth page id

---------

Co-authored-by: Bloo <git@bloo.boo>

Author: runcows

gm4/modeldata_registry.json

@@ -534,6 +534,7 @@
     "fishing_rod": {
       "gm4_end_fishing:gui/advancement/end_fishing": 1,
       "gm4_end_fishing:guidebook_icon/end_fishing": 2,
+      "gm4_reeling_rods:guidebook_icon/reeling_rods": 3,
       "gm4_metallurgy:shamir/hypexperia": 110,
       "gm4_animi_shamir:shamir/animi": 124
     },

gm4/utils.py

@@ -1,6 +1,6 @@
 {
   "__important__": "Generated by generate_guidebooks.py. Don't manually update this",
-  "__next__": 121,
+  "__next__": 122,
   "animi_shamir": 91,
   "apple_trees": 83,
   "arborenda_shamir": 20,
@@ -82,6 +82,7 @@
   "potion_liquids": 32,
   "potion_swords": 62,
   "record_crafting": 97,
+  "reeling_rods": 121,
   "relocators": 70,
   "resurrecting_skeletons": 41,
   "resurrecting_zombies": 46,

gm4_guidebook/triggers.json

@@ -0,0 +1,10 @@
+# Reeling Rods<!--$headerTitle--><!--$pmc:delete-->
+
+Reel in more than just fish with these rods. Yoink the chest from the chest boat, deal some damage, and more! <!--$pmc:headerSize-->
+
+### Features
+- All fishing rods have extra abilities when hooking Paintings, Item Frames, Leash Knots, Shulkers and End Crystals. Hooking any entity will also dismount them from their vehicle.
+
+Adds 2 fishing rod enchantments, Reeling and Barbed.
+- Reeling revolves around stealing from entities. Pull the chest from chest boats and so much more!
+- Barbed turns a fishing rod into a lethal weapon. With 5 levels, it applies a scratching damage to the hooked mob and then bleeding damage.

gm4_reeling_rods/README.md

@@ -0,0 +1,38 @@
+id: gm4_reeling_rods
+name: Reeling Rods
+version: 1.0.X
+
+data_pack:
+  load: .
+
+pipeline:
+  - generate_files
+  - gm4.plugins.extend.module
+
+require:
+  - bolt
+
+meta:
+  gm4:
+    versioning:
+      schedule_loops: [tick]
+    website:
+      description: Reel in more than just fish with these rods! Yoink the chest from the chest boat and more!
+      recommended: 
+        - gm4_end_fishing
+        - gm4_live_catch
+      notes: []
+    modrinth:
+      project_id: MWPuloVL
+    #smithed:
+      #pack_id: 
+    #planetminecraft:
+      #uid: 
+    video: null
+    wiki: https://wiki.gm4.co/wiki/Reeling_Rods
+    credits:
+      Creators:
+        - runcows
+        - Bloo
+      Icon Design:
+        - runcows

gm4_reeling_rods/beet.yaml

@@ -0,0 +1,24 @@
+{
+    "description": {
+        "translate": "gm4.reeling_rods.enchantment.barbed",
+        "fallback": "Barbed"
+    },
+    "exclusive_set": "gm4_reeling_rods:reeling",
+    "supported_items": "minecraft:fishing_rod",
+    "primary_items": "minecraft:fishing_rod",
+    "weight": 1,
+    "max_level": 5,
+    "min_cost": {
+        "base": 1,
+        "per_level_above_first": 10
+    },
+    "max_cost": {
+        "base": 51,
+        "per_level_above_first": 10
+    },
+    "anvil_cost": 1,
+    "slots": [
+        "any"
+    ],
+    "effects": {}
+}

gm4_reeling_rods/data/gm4_reeling_rods/enchantment/barbed.json

@@ -0,0 +1,24 @@
+{
+    "description": {
+        "translate": "gm4.reeling_rods.enchantment.reeling",
+        "fallback": "Reeling"
+    },
+    "exclusive_set": "gm4_reeling_rods:barbed",
+    "supported_items": "minecraft:fishing_rod",
+    "primary_items": "minecraft:fishing_rod",
+    "weight": 1,
+    "max_level": 1,
+    "min_cost": {
+        "base": 20,
+        "per_level_above_first": 0
+    },
+    "max_cost": {
+        "base": 70,
+        "per_level_above_first": 0
+    },
+    "anvil_cost": 8,
+    "slots": [
+        "any"
+    ],
+    "effects": {}
+}

gm4_reeling_rods/data/gm4_reeling_rods/enchantment/reeling.json

@@ -0,0 +1,24 @@
+# Applies the barbed damage to the hooked entity
+# @s = hooked entity
+# at bobber position
+# with {damage}
+# run from hooked_entity/select_type
+
+# immediate damage (amount scales with enchantment level)
+execute store result score $show_death_messages gm4_reeling_rods.barbed_damage_timer run gamerule showDeathMessages
+gamerule showDeathMessages false
+$damage @s $(damage) cactus by @p[tag=gm4_reeling_rods.player]
+playsound minecraft:entity.player.attack.crit player @a[distance=..16] ~ ~ ~ 1 1.82
+
+# handle death (@e only selects entities which are alive)
+# | this is of importance for entities which display death messages or re-spawn
+tag @s add gm4_reeling_rods.victim
+execute if entity @s[type=#gm4_reeling_rods:support_death_message] at @s unless entity @e[type=#gm4_reeling_rods:support_death_message,tag=gm4_reeling_rods.victim,distance=0,limit=1] run function gm4_reeling_rods:barbed/on_scratch_death
+
+# if the victim is still alive, schedule bleeding damage
+execute at @s if entity @e[tag=gm4_reeling_rods.victim,distance=0,limit=1] run function gm4_reeling_rods:barbed/schedule_bleeding
+
+# reset scores, gamerule and tag
+tag @s remove gm4_reeling_rods.victim
+execute if score $show_death_messages gm4_reeling_rods.barbed_damage_timer matches 1 run gamerule showDeathMessages true
+scoreboard players reset $show_death_messages gm4_reeling_rods.barbed_damage_timer

gm4_reeling_rods/data/gm4_reeling_rods/function/barbed/apply.mcfunction

@@ -0,0 +1,42 @@
+# updates the bleeding timer
+# @s = entity recently hit by a barbed fishing rod
+# at @s
+# run from barbed/find_affected
+
+# advance timer
+scoreboard players add @s gm4_reeling_rods.barbed_damage_timer 1
+
+# clear if timer exceeds 3s
+execute if score @s gm4_reeling_rods.barbed_damage_timer matches 61.. run return run function gm4_reeling_rods:barbed/clear
+
+# return unless phase of timer is 0
+scoreboard players operation $phase gm4_reeling_rods.barbed_damage_timer = @s gm4_reeling_rods.barbed_damage_timer
+scoreboard players operation $phase gm4_reeling_rods.barbed_damage_timer %= @s gm4_reeling_rods.barbed_damage_period
+execute unless score $phase gm4_reeling_rods.barbed_damage_timer matches 0 run return fail
+
+# find attacker 
+# | tags attacker with gm4_reeling_rods.barbed_attacker
+# | sets $found_attacker gm4_reeling_rods.barbed_attacker_uuid0
+execute summon snowball run function gm4_reeling_rods:barbed/find_attacker
+
+# prepare to handle player death
+execute store result score $show_death_messages gm4_reeling_rods.barbed_damage_timer run gamerule showDeathMessages
+gamerule showDeathMessages false
+
+# apply damage
+# | if the attacker was found, attribute it to the attacker, if not do not attribute it to anyone
+# | use cactus damage type as it has no knockback and respects armor
+# | print custom death message to obscure cactus death message
+execute if score $found_attacker gm4_reeling_rods.barbed_attacker_uuid0 matches 1.. run damage @s 2 cactus by @p[tag=gm4_reeling_rods.barbed_attacker]
+execute unless score $found_attacker gm4_reeling_rods.barbed_attacker_uuid0 matches 1.. run damage @s 2 cactus
+playsound minecraft:block.pointed_dripstone.drip_lava neutral @a[distance=..6] ~ ~ ~ 1 1.8
+execute anchored eyes run particle damage_indicator ^ ^ ^ .2 .2 .2 0 3
+execute anchored eyes run particle damage_indicator ^ ^ ^1 .5 .5 .5 0 8 normal @s
+
+# handle death (@e only selects entities which are alive)
+# | this is of importance for entities which display death messages or re-spawn
+tag @s add gm4_reeling_rods.victim
+execute if entity @s[type=#gm4_reeling_rods:support_death_message] at @s unless entity @e[type=#gm4_reeling_rods:support_death_message,tag=gm4_reeling_rods.victim,distance=0,limit=1] run function gm4_reeling_rods:barbed/on_bleeding_death
+tag @s remove gm4_reeling_rods.victim
+execute if score $show_death_messages gm4_reeling_rods.barbed_damage_timer matches 1 run gamerule showDeathMessages true
+scoreboard players reset $show_death_messages gm4_reeling_rods.barbed_damage_timer

gm4_reeling_rods/data/gm4_reeling_rods/function/barbed/bleed.mcfunction

@@ -0,0 +1,11 @@
+# stops bleeding damage
+# @s = entity recently hit by a barbed fishing rod
+# at @s
+# run from barbed/bleed, barbed/on_bleeding_death, and barbed/on_scratch_death
+
+scoreboard players reset @s gm4_reeling_rods.barbed_attacker_uuid0
+scoreboard players reset @s gm4_reeling_rods.barbed_attacker_uuid1
+scoreboard players reset @s gm4_reeling_rods.barbed_attacker_uuid2
+scoreboard players reset @s gm4_reeling_rods.barbed_attacker_uuid3
+scoreboard players reset @s gm4_reeling_rods.barbed_damage_period
+scoreboard players reset @s gm4_reeling_rods.barbed_damage_timer