Skip to content

Commit dba14ed

Browse files
committed
fix liquid minecarts
1 parent 1fedfb6 commit dba14ed

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

gm4_liquid_minecarts/data/gm4_liquid_minecarts/function/machine/create_cart.mcfunction

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
scoreboard players set $placed_block gm4_machine_data 1
77

88
# summon new command block minecart
9-
summon command_block_minecart ~ ~ ~ {Command:"execute if score @s gm4_lt_value matches 1.. run function gm4_liquid_minecarts:drain_minecart",CustomName:{"text":"Liquid Minecart","italic":false},Tags:["gm4_liquid_minecart","gm4_liquid_minecart_empty","gm4_machine_cart","gm4_new_machine"],DisplayState:{"Name":"minecraft:hopper"},Passengers:[{id:"minecraft:armor_stand",Tags:["gm4_no_edit","gm4_liquid_minecart_stand","gm4_machine_cart","smithed.entity","smithed.strict","gm4_new_machine"],Invisible:1b,DisabledSlots:2039583,Small:1b,equipment:{feet:{id:"minecraft:stick",count:1,components:{"minecraft:custom_data":{gm4_liquid_minecarts:{liquid_tag:"null"}}}}},Pose:{Head:[180.0f,0.0f,0.0f],RightArm:[0.0f,-90.0f,0.0f]}}]}
9+
summon command_block_minecart ~ ~ ~ {Command:"execute if score @s gm4_lt_value matches 1.. run function gm4_liquid_minecarts:drain_minecart",CustomName:{"text":"Liquid Minecart","italic":false},Tags:["gm4_liquid_minecart","gm4_liquid_minecart_empty","gm4_machine_cart","gm4_new_machine"],DisplayState:{"Name":"minecraft:hopper"},Passengers:[{id:"minecraft:marker",Tags:["gm4_liquid_minecart_marker","gm4_machine_cart","smithed.entity","smithed.strict","gm4_new_machine"]},{id:"minecraft:armor_stand",Tags:["gm4_no_edit","gm4_liquid_minecart_stand","gm4_machine_cart","smithed.entity","smithed.strict","gm4_new_machine"],Invisible:1b,DisabledSlots:2039583,Small:1b,equipment:{feet:{id:"minecraft:stick",count:1,components:{"minecraft:custom_data":{gm4_liquid_minecarts:{liquid_tag:"null"}}}}},Pose:{Head:[180.0f,0.0f,0.0f],RightArm:[0.0f,-90.0f,0.0f]}}]}
1010
tp @e[type=command_block_minecart,distance=..0.1,tag=gm4_new_machine] @s
1111
scoreboard players set @e[distance=..2,tag=gm4_new_machine] gm4_entity_version 1
1212
execute as @e[type=command_block_minecart,distance=..0.1,tag=gm4_new_machine,limit=1] run function gm4_liquid_minecarts:liquid_value_update

gm4_liquid_minecarts/data/gm4_liquid_minecarts/function/machine/destroy_cart.mcfunction

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
scoreboard players set $dropped_item gm4_machine_data 0
88
execute as @e[type=item,distance=..3,nbt={Age:0s,Item:{id:"minecraft:minecart",count:1,components:{"minecraft:custom_name":{"italic":false,"text":"Liquid Minecart"}}}},limit=1,sort=nearest] at @s run function gm4_liquid_minecarts:machine/destroy_cart/drop_item
99

10+
# remove the armor stand
11+
kill @n[type=armor_stand,distance=..3,limit=1,tag=gm4_liquid_minecart_stand]
12+
1013
# scan hoppers if no item was broken
1114
execute if score $dropped_item gm4_machine_data matches 0 run function gm4_liquid_minecarts:machine/destroy_cart/scan_hoppers
1215

gm4_liquid_minecarts/data/gm4_liquid_minecarts/function/machine/destroy_cart/drop_item.mcfunction

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,3 @@ execute store success score $dropped_item gm4_machine_data run loot spawn ~ ~ ~
88

99
# kill original (invalid) item
1010
kill @s
11-

gm4_liquid_minecarts/data/gm4_liquid_minecarts/function/machine/verify_destroy_cart.mcfunction

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
# located at @s
44
# run from #gm4_machines:destroy
55

6-
execute if entity @s[tag=gm4_liquid_minecart_stand] run function gm4_liquid_minecarts:machine/destroy_cart
6+
execute if entity @s[tag=gm4_liquid_minecart_marker] run function gm4_liquid_minecarts:machine/destroy_cart

0 commit comments

Comments
 (0)