Skip to content

Reeling Rods lead sound fix #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
misode merged 2 commits into from
Jan 29, 2026
Merged

Reeling Rods lead sound fix #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4d08b
Update leash sound
runcows Jan 28, 2026
bf44a69
Backport old sound
runcows Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...ods/backport_71/data/gm4_reeling_rods/function/hooked_entity/leash_knot/action.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Action for hooked leash knot
# @s = leash knot
# at bobber in @s
# run from hooked_entity/select_type

tag @s add gm4_reeling_rods.leash_knot

# distance=..12 is leash distance
execute at @s as @e[type=#gm4_reeling_rods:leashable,distance=..12] \
if function gm4_reeling_rods:hooked_entity/leash_knot/leaded_by_knot \
run function gm4_reeling_rods:hooked_entity/leash_knot/change_leader

kill @s

execute at @p[tag=gm4_reeling_rods.player] run playsound minecraft:entity.leash_knot.place neutral @a[distance=..16] ~ ~ ~
6 changes: 6 additions & 0 deletions gm4_reeling_rods/beet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ version: 1.0.X
data_pack:
load: .
overlays:
- formats:
min_inclusive: 1
max_inclusive: 71
min_format: 1
max_format: 71
directory: backport_71
- formats:
min_inclusive: 1
max_inclusive: 88
Expand Down
2 changes: 1 addition & 1 deletion gm4_reeling_rods/data/gm4_reeling_rods/function/hooked_entity/leash_knot/action.mcfunction
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ execute at @s as @e[type=#gm4_reeling_rods:leashable,distance=..12] \

kill @s

execute at @p[tag=gm4_reeling_rods.player] run playsound minecraft:entity.leash_knot.place neutral @a[distance=..16] ~ ~ ~
execute at @p[tag=gm4_reeling_rods.player] run playsound minecraft:item.lead.tied neutral @a[distance=..16] ~ ~ ~
Loading