-
-
Notifications
You must be signed in to change notification settings - Fork 68
Generate Soul Glass Predicate #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d74fe6c
generate soul glass predicate
BPR02 52e1d3d
make it work in the end and nether
BPR02 81b021c
Merge: Update to 26.1 (#1256)
misode 1f798cb
Add golden dandelion to blossoming pots (#1284)
runcows 631c015
Update beet & mecha to 26.1 (#1286)
runcows bec23ee
Merge remote-tracking branch 'upstream/master' into soul-glass-generate
BPR02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,9 +8,6 @@ data_pack: | |
| pipeline: | ||
| - gm4.plugins.extend.module | ||
|
|
||
| require: | ||
| - bolt | ||
|
|
||
| meta: | ||
| gm4: | ||
| versioning: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,9 @@ id: gm4_soul_glass | |
| name: Soul Glass | ||
| version: 1.7.X | ||
|
|
||
| require: | ||
| - bolt | ||
|
|
||
| data_pack: | ||
| load: . | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
71 changes: 71 additions & 0 deletions
71
gm4_soul_glass/data/gm4_soul_glass/predicate/has_beam_end.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| block_checks = [] | ||
|
|
||
| MIN = 1 | ||
| MAX = 256 | ||
|
|
||
| for y in range(MIN, MAX): | ||
| block_checks.append({ | ||
| "condition": "minecraft:any_of", | ||
| "terms": [ | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "predicate": { | ||
| "position": { | ||
| "y": { | ||
| "min": y | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "blocks": "#gm4_soul_glass:beacon_passable" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "extended": "true" | ||
| }, | ||
| "blocks": "#gm4_soul_glass:piston" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "type": "bottom" | ||
| }, | ||
| "blocks": "#minecraft:slabs" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "type": "top" | ||
| }, | ||
| "blocks": "#minecraft:slabs" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }) | ||
|
|
||
| { | ||
| "condition": "minecraft:all_of", | ||
| "terms": block_checks | ||
| } |
71 changes: 71 additions & 0 deletions
71
gm4_soul_glass/data/gm4_soul_glass/predicate/has_beam_nether.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| block_checks = [] | ||
|
|
||
| MIN = 1 | ||
| MAX = 256 | ||
|
|
||
| for y in range(MIN, MAX): | ||
| block_checks.append({ | ||
| "condition": "minecraft:any_of", | ||
| "terms": [ | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "predicate": { | ||
| "position": { | ||
| "y": { | ||
| "min": y | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "blocks": "#gm4_soul_glass:beacon_passable" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "extended": "true" | ||
| }, | ||
| "blocks": "#gm4_soul_glass:piston" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "type": "bottom" | ||
| }, | ||
| "blocks": "#minecraft:slabs" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "type": "top" | ||
| }, | ||
| "blocks": "#minecraft:slabs" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }) | ||
|
|
||
| { | ||
| "condition": "minecraft:all_of", | ||
| "terms": block_checks | ||
| } |
71 changes: 71 additions & 0 deletions
71
gm4_soul_glass/data/gm4_soul_glass/predicate/has_beam_overworld.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| block_checks = [] | ||
|
|
||
| MIN = -63 | ||
| MAX = 320 | ||
|
|
||
| for y in range(MIN, MAX): | ||
| block_checks.append({ | ||
| "condition": "minecraft:any_of", | ||
| "terms": [ | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "predicate": { | ||
| "position": { | ||
| "y": { | ||
| "min": y | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "blocks": "#gm4_soul_glass:beacon_passable" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "extended": "true" | ||
| }, | ||
| "blocks": "#gm4_soul_glass:piston" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "type": "bottom" | ||
| }, | ||
| "blocks": "#minecraft:slabs" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "condition": "minecraft:location_check", | ||
| "offsetY": MAX-y, | ||
| "predicate": { | ||
| "block": { | ||
| "state": { | ||
| "type": "top" | ||
| }, | ||
| "blocks": "#minecraft:slabs" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }) | ||
|
|
||
| { | ||
| "condition": "minecraft:all_of", | ||
| "terms": block_checks | ||
| } | ||
3 changes: 3 additions & 0 deletions
3
gm4_soul_glass/data/gm4_soul_glass/tags/function/run_beacon_check.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "values": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this location check is doing in the predicate?
I don't fully understand its purpose here or in the current nightmare-fuel predicate, but in this current implementation, this check succeeding would be enough for it to not check the remaining conditions, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait ok, i understand this location check now, its to exclude blocks under the beacon. This should be true AND the following block checks. The current version is OR and will succeed regardless of the block checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean current version as in the one that's in
masterright now, that was made beforeall_of(AND) was added, and thus needed to use DeMorgan's to derive anall_of(AND) usinginverted(OR) andany_of(OR). The current version does the same thing as this one.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No in that message, current was referring to this PR. For each block in the predicate in this PR, the condition is
any_ofand so the min block position check will cause each block position to succeed if above the execution position.Edit: I did not understand the predicate fully, it is complicated