Interaction response:1b -> /swing#1285
Open
runcows wants to merge 4 commits intoGamemode4Dev:masterfrom
Open
Conversation
Contributor
Author
|
This PR has been updated to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the interaction entities in Rope Ladders and Lively Lily Pads (
responseisn't used anywhere else), switches them to use the new/swingcommand.This fixes a visual bug where using the offhand would still play a mainhand arm swing.
For Lively Lily Pads, this has meant upping the minor version (again💀) for an upgrade path to remove
response:1bfrom existing interactions.I'm not super happy with the number of repeated score checks here, but i was feeling lazy and didnt want to make ~10 new functions, each with just 2 commands....