Skip to content

possieble fix for the dropdown not respecting the versions + (optional) enchancement #91

@surgamingoninsulin

Description

@surgamingoninsulin

NOTE:
I ive coppied the site with https://saveweb2zip.com/en and added to a new folder .sources
and reacreated the site form the .sources folder.
so i dont know how you called the site files and used the names from the .sources
p.s. i tried to enahce the messave below with ai to explain it better. I checked and it mirrors what i have changed!

All Modules version dropdown changes the UI, but downloads still use 26.1

Hey GM4 team,

I found a mismatch in the https://gm4.co/ build: selecting a different version in the All Modules dropdown updates the visible module list, but the actual downloads still use 26.1.

What I�m seeing

If I pick something like 1.21.5 - 1.21.11, the cards/filtering look correct, but when I download, the files are still resolved with 26.1.

Steps to reproduce

  1. Open All Modules.
  2. Change version to a non-default one (example: 1.21.5 - 1.21.11).
  3. Download selected modules.
  4. Result: download still targets 26.1.

Why this seems to happen

In ``site_url/xYjoVOR47NwX.co/includes/homepage_hash=dcbb4385.js, the dropdown change handler filters modules but does not update global `selectedVersion`.

Meanwhile, ``site_url/xYjoVOR47NwX.co/includes/module_hash=fa4747f8.js still starts with `selectedVersion = '26.1'`, and that value is used for download URLs.

So the UI state changes, but the download state doesn�t.

Suggested fix

In the dropdown change handler (else block) in ``site_url/xYjoVOR47NwX.co/includes/homepage_hash=dcbb4385.js:

  1. Set selectedVersion = versionSelect.value.
  2. Keep the existing filterModules(...) call.
  3. Optionally call updateIncludedModules(getIncludedModules()) so selection labels/buttons are immediately in sync.

Expected behavior after fix

Changing the version in All Modules should affect both:

  • what the user sees, and
  • what version actually gets downloaded.

Enhancement (Optional)

Match root behavior for resourcepack download flow

Separate from the dropdown bug above: I also have improved resourcepack download handling in root. It would be nice to bring that same behavior into site_url so resourcepack downloads are just as reliable there.

Suggested scope for this enhancement:

  1. Keep this as a separate change from the dropdown fix.
  2. Port only the resourcepack download handling from root.
  3. Leave normal module download flow untouched unless needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions