Replace https://gm4.co/discord and https://gm4.co/wiki with real URLs#90
Open
TransportLayer wants to merge 1 commit intoGamemode4Dev:masterfrom
Open
Replace https://gm4.co/discord and https://gm4.co/wiki with real URLs#90TransportLayer wants to merge 1 commit intoGamemode4Dev:masterfrom
TransportLayer wants to merge 1 commit intoGamemode4Dev:masterfrom
Conversation
This ensures that users can always access the real URLs even if the webserver is down or misbehaving and it is consistent with our links to other sites like GitHub and Patreon. While this means we have to replace the URL in a few different files if we ever start using a new Discord invite link, it's very easy to search and replace every instance in every file, and it's nice to have less redirects and dependency on external components (why make a new request that depends on our webserver configuration for an off-site URL when we could directly link the user?).
Contributor
Author
|
Note that this is only replacing the links on the website; the links themselves are not part of the website and will continue to work (they are part of the webserver configuration). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that users can always access the real URLs even if the webserver is down or misbehaving and it is consistent with our links to other sites like GitHub and Patreon.
While this means we have to replace the URL in a few different files if we ever start using a new Discord invite link, it's very easy to search and replace every instance in every file, and it's nice to have less redirects and dependency on external components (why make a new request that depends on our webserver configuration for an off-site URL when we could directly link the user?).
(I also fixed the indentation for the Discord link in site/server.php)