dstack-ingress/route53: preserve accounturi in Route53 CAA records - #1
Open
Garandor wants to merge 1 commit into
Open
dstack-ingress/route53: preserve accounturi in Route53 CAA records#1Garandor wants to merge 1 commit into
Garandor wants to merge 1 commit into
Conversation
The Route53 create_caa_record() was ignoring caa_record.value and hard-coding bare "letsencrypt.org" as the CAA issuer, stripping the accounturi parameter needed for strict CAA enforcement. Now uses the caller-provided value (like Cloudflare and Linode do). Also adds a cross-provider test verifying accounturi is preserved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Garandor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_caa_record()was ignoringcaa_record.valueand hard-coding bare"letsencrypt.org"as the CAA issuer, stripping theaccounturiparameter required for strict CAA enforcement.test_caa_accounturi.py) that verifies all providers preserve accounturi — fails on the old code, passes on the fix.Test plan
dig CAA <domain> +shortshould showaccounturi=in the letsencrypt.org entry🤖 Generated with Claude Code