Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Symfony console command to scan Etherpad instances across all discovered versions and derive file-hash-to-version ranges, supporting maintenance of the existing file-hash lookup mapping.
Changes:
- Add
ether:generate-file-hashes-all-versionscommand to fetch instances, scan a given file, and summarize hashes per version. - Introduce
InstanceResult/InstanceResultsto collect and group scan results. - Update
FileHashLookupServicehash/version range mappings (and type the class constant).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/Service/FileHashLookupService.php |
Updates the file-hash → version-range dataset and types the constant. |
src/Console/InstanceResults.php |
Adds a small collection helper to group instance scan results by version. |
src/Console/InstanceResult.php |
Adds a DTO for per-instance scan results. |
src/Console/GenerateFileHashesAllVersionsCommand.php |
New command that fetches instance inventory, scans versions, and prints summary tables. |
bin/console.php |
Registers the new console command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gared
force-pushed
the
feature/file-hash-generator
branch
from
0349d21 to
f7580a0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.