WIP: Add the optional argument of --reach to certain checks#210
Open
corlettim wants to merge 70 commits into
Open
WIP: Add the optional argument of --reach to certain checks#210corlettim wants to merge 70 commits into
corlettim wants to merge 70 commits into
Conversation
Collaborator
|
addresses issue #205 |
Collaborator
|
Hello @corlettim and @schultzh, please make sure that you update this branch with the new content that is in the master branch. I'm hoping that you find that merging in this fashion will resolve some of the issues that you were facing with builds not working correctly. Let me know what you discover! |
Member
|
@gkapfham @corlettim Note that this PR's body does not have a valid versioning sentence. It should probably match the "minor" regex mentioned in the README, and so the word "small" should be dropped. If it should be considered a "patch" change, instead of "feature" you should use "update" or "change", but since this is a new feature it should probably be a minor version increment. |
Collaborator
|
Thanks @Michionlion, I fixed the phrasing. |
…ator/gatorgrader into argument/optional-advanced-tag
gkapfham
changed the title
--reach to certain checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a feature that adds the
--reachargument to all of the checks. This PR must work in conjunction with the Feature/reach goal PR for the GatorGradle plugin.We thought it was an important feature to add because we have noticed that some students need a reach goal in mind to push them or challenge them a little more in the classroom. We are still unsure of how to connect this to the correct output if the user completes or does not complete this check. Further research and testing will assist with this. Consequently, there is still more work that needs to go in to this PR and topic.
Fixes #205
Notes: @gkapfham added a description that follows the pr-tag-release standard. Also, @gkapfham removed the following phrases from the start of this PR's description:
@corlettim and @schultzh if it is not possible to make this work for all of the checks, then can you please list the ones for which this will not work and explain why it won't work for each one?