From efa8fae0503f240a715fb89364208f2aa3a5a1f8 Mon Sep 17 00:00:00 2001 From: Roy-Orbison Date: Tue, 19 May 2020 12:20:43 +0930 Subject: [PATCH] Bug in terms_clauses() short circuit Never returns early because `if` cannot evaluate to `false`. --- gecka-terms-ordering.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gecka-terms-ordering.php b/gecka-terms-ordering.php index 84924e6..7a0848c 100644 --- a/gecka-terms-ordering.php +++ b/gecka-terms-ordering.php @@ -312,7 +312,7 @@ public function terms_clauses( $clauses, $taxonomies, $args ) { global $wpdb; $taxonomies = (array) $taxonomies; - if ( sizeof( $taxonomies === 1 ) ) { + if ( sizeof( $taxonomies ) === 1 ) { $taxonomy = array_shift( $taxonomies ); } else { return $clauses; @@ -418,4 +418,4 @@ function remove_term_ordering_support( $taxonomy ) { function has_term_ordering_support( $taxonomy ) { return Gecka_Terms_Ordering::has_support( $taxonomy ); } -} \ No newline at end of file +}