Skip to content

Commit 48f4c5e

Browse files
authored
Merge pull request #47 from GeekTree0101/bug/fix-invalid-merge-issue
Fix Invalid Merge Issue
2 parents c6735ed + b307eda commit 48f4c5e

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

Example/VEditorKit.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
607FACEB1AFB9204008FA782 /* VEditorParserSpec.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VEditorParserSpec.swift; sourceTree = "<group>"; };
7272
678C76B2ADE22C77779D368C /* LICENSE */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = LICENSE; path = ../LICENSE; sourceTree = "<group>"; };
7373
9B3036D921F4162D00489340 /* UIImage+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIImage+Extension.swift"; sourceTree = "<group>"; };
74-
9B3036E121F41BAF00489340 /* MockService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = MockService.swift; path = /Users/vingle/Desktop/VEditorKit/Example/VEditorKit/Services/MockService.swift; sourceTree = "<absolute>"; };
74+
9B3036E121F41BAF00489340 /* MockService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockService.swift; sourceTree = "<group>"; };
7575
9B3036E421F41BBE00489340 /* XMLViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = XMLViewController.swift; sourceTree = "<group>"; };
7676
9B3036E621F41BC800489340 /* EditorOpenGraphPlaceholder.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EditorOpenGraphPlaceholder.swift; sourceTree = "<group>"; };
7777
9B3036EA21F41C3800489340 /* VImageContent.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VImageContent.swift; sourceTree = "<group>"; };

VEditorKit/Classes/VEditorNode.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,9 @@ open class VEditorNode: ASDisplayNode, ASTableDelegate, ASTableDataSource {
198198
.subscribe(onNext: { [weak self] indexPath in
199199
self?.editorContents.remove(at: indexPath.row)
200200
self?.tableNode.deleteRows(at: [indexPath], with: .automatic)
201-
self?.mergeTextContents(target: .init(row: indexPath.row - 1,
202-
section: indexPath.section),
203-
to: indexPath,
201+
self?.mergeTextContents(target: indexPath,
202+
to: .init(row: indexPath.row - 1,
203+
section: indexPath.section),
204204
animated: false)
205205
})
206206
.disposed(by: cellNode.disposeBag)
@@ -589,12 +589,12 @@ open class VEditorNode: ASDisplayNode, ASTableDelegate, ASTableDataSource {
589589
}
590590

591591
// NOTE: make merged attributedText
592-
var mutableAttrText = NSMutableAttributedString(attributedString: targetAttributedText)
592+
var mutableAttrText = NSMutableAttributedString(attributedString: sourceAttributedText)
593593
var newlineAttribute = self.editorRule.defaultAttribute()
594594
newlineAttribute[VEditorAttributeKey] = [self.editorRule.defaultStyleXMLTag]
595595
mutableAttrText.append(NSAttributedString.init(string: "\n",
596596
attributes: newlineAttribute))
597-
mutableAttrText.append(sourceAttributedText)
597+
mutableAttrText.append(targetAttributedText)
598598

599599
// NOTE: update editor
600600
self.editorContents.remove(at: target.row)
@@ -629,8 +629,8 @@ open class VEditorNode: ASDisplayNode, ASTableDelegate, ASTableDataSource {
629629
.nodeForRow(at: .init(row: indexPath.row,
630630
section: indexPath.section)) as? VEditorTextCellNode
631631

632-
guard let target = beforeCell?.indexPath,
633-
let to = currentCell?.indexPath else {
632+
guard let target = currentCell?.indexPath,
633+
let to = beforeCell?.indexPath else {
634634
return
635635
}
636636

VEditorKit/Classes/VEditorParser.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,11 @@ public final class VEditorParser: NSObject, XMLStyler {
146146
Editor Content Parser
147147

148148
General pattern would be:
149-
xml: <content><p>hello <b>world</b></p><img src="~~~~" /><p>done></p></content>
149+
xml: <content><p>hello <b>world</b></p><img src="~~~~" /><p>done</p></content>
150150
will convert to
151151
- [0]: <p>hello <b>world</b></p>
152152
- [1]: VEditorMediaContent
153-
- [2]: <p>done></p>
153+
- [2]: <p>done</p>
154154
*/
155155
internal class VEditorContentParser: NSObject, XMLParserDelegate {
156156

0 commit comments

Comments
 (0)