GitHubSync update

Author: GeertvanHorrik

deployment/cake/components-tasks.cake

@@ -289,16 +289,17 @@ public class ComponentsProcessor : ProcessorBase
                 noBuild = false;
             }
 
-            if (isPackageContainerProject)
-            {
-                // In debug / local builds, automatic building of reference projects
-                // is enabled for convenience. If that is the case, noBuild must be
-                // set to false, but *only* in debug mode
-                if (BuildContext.General.IsLocalBuild)
-                {
-                    noBuild = false;
-                }
-            }
+            // Disabled on 2025-09-23 since it was causing issues on local builds during packaging
+            // if (isPackageContainerProject)
+            // {
+            //     // In debug / local builds, automatic building of reference projects
+            //     // is enabled for convenience. If that is the case, noBuild must be
+            //     // set to false, but *only* in debug mode
+            //     if (BuildContext.General.IsLocalBuild)
+            //     {
+            //         noBuild = false;
+            //     }
+            // }
 
             // As described in the this issue: https://github.com/NuGet/Home/issues/4360
             // we should not use IsTool, but set BuildOutputTargetFolder instead

deployment/cake/lib-msbuild.cake

@@ -56,20 +56,12 @@ private static void ConfigureMsBuild(BuildContext buildContext, MSBuildSettings
 
     msBuildSettings.WithProperty("PackageOutputPath", buildContext.General.OutputRootDirectory);
 
-    // Only optimize in release mode
-    if (!buildContext.General.IsLocalBuild)
-    {
-        buildContext.CakeContext.Information("This is NOT a local build, disabling building of project references");
+    buildContext.CakeContext.Information("This is NOT a local build, disabling building of project references");
 
-        // Don't build project references (should already be built)
-        msBuildSettings.WithProperty("BuildProjectReferences", "false");
+    // Don't build project references (should already be built)
+    msBuildSettings.WithProperty("BuildProjectReferences", "false");
 
-        //InjectAssemblySearchPathsInProjectFile(buildContext, projectName, GetProjectFileName(buildContext, projectName));
-    }
-    else
-    {
-        buildContext.CakeContext.Information("This is a local build, not disabling building of project references");
-    }
+    //InjectAssemblySearchPathsInProjectFile(buildContext, projectName, GetProjectFileName(buildContext, projectName));
 
     // Continuous integration build
     msBuildSettings.ContinuousIntegrationBuild = true;
@@ -87,6 +79,12 @@ private static void ConfigureMsBuild(BuildContext buildContext, MSBuildSettings
     // msBuildSettings.WithProperty("SolutionExt", ".sln");
     // msBuildSettings.WithProperty("DefineExplicitDefaults", "true");
 
+    // Path maps
+    if (!buildContext.General.IsLocalBuild)
+    {
+        msBuildSettings.WithProperty("PathMap", $"{buildContext.General.RootDirectory}=./");
+    }
+
     // Disable copyright info
     msBuildSettings.NoLogo = true;
 
@@ -143,21 +141,11 @@ private static void ConfigureMsBuildForDotNet(BuildContext buildContext, DotNetM
 
     msBuildSettings.WithProperty("PackageOutputPath", buildContext.General.OutputRootDirectory);
 
-    // Only optimize in release mode
-    if (!buildContext.General.IsLocalBuild)
-    {
-        buildContext.CakeContext.Information($"This is NOT a local build, disabling building of project references");
-
-        // Don't build project references (should already be built)
-        msBuildSettings.WithProperty("BuildProjectReferences", "false");
-
-        //InjectAssemblySearchPathsInProjectFile(buildContext, projectName, GetProjectFileName(buildContext, projectName));
-    }
-    else
-    {
-        buildContext.CakeContext.Information($"This is a local build, not disabling building of project references");
-    }
+    // Don't build project references (should already be built)
+    msBuildSettings.WithProperty("BuildProjectReferences", "false");
 
+    //InjectAssemblySearchPathsInProjectFile(buildContext, projectName, GetProjectFileName(buildContext, projectName));
+        
     // Continuous integration build
     msBuildSettings.ContinuousIntegrationBuild = true;
     //msBuildSettings.WithProperty("ContinuousIntegrationBuild", "true");
@@ -174,6 +162,12 @@ private static void ConfigureMsBuildForDotNet(BuildContext buildContext, DotNetM
     // msBuildSettings.WithProperty("SolutionExt", ".sln");
     // msBuildSettings.WithProperty("DefineExplicitDefaults", "true");
 
+    // Path maps
+    if (!buildContext.General.IsLocalBuild)
+    {
+        msBuildSettings.WithProperty("PathMap", $"{buildContext.General.RootDirectory}=./");
+    }
+
     // Disable copyright info
     msBuildSettings.NoLogo = true;
 

deployment/cake/tasks.cake

@@ -36,7 +36,7 @@
 // It probably means the tool is not correctly installed.
 // `dotnet tool install --global dotnet-sonarscanner --ignore-failed-sources`
 //#tool "nuget:?package=MSBuild.SonarQube.Runner.Tool&version=4.8.0"
-#tool "nuget:?package=dotnet-sonarscanner&version=10.3.0"
+#tool "nuget:?package=dotnet-sonarscanner&version=10.4.0"
 
 //-------------------------------------------------------------
 // BACKWARDS COMPATIBILITY CODE - START