configurable region detection from filename#248
Conversation
- regions from file in order of region prios and inlined into region prios by default - added config option (regionFromFilename) to control region detection from filename - updated regions doc and testcases
* Go through regionPrios from config before regionMap Appending regionMap to regionPrios before searching it will prioritise searching the config regionPrios first, and then if not found, move on to regionMap. May need to add a line to remove duplicates from this list as regions in regionPrios and regionMap may appear twice (removing the second occurrence should remove the regionMap appearence and leave the first one added via regionPrios) * Add an iteration through regionMap based on regionPrios to give new sortedMap order Made some fixes to ensure it compiles and also to do this is a more logical way (without duplication)
…raper into fb_regions_issue_242
|
Hi Gemba - thank you for all your help with this, much appreciated. I've ran some testing on 3.20.0 today, and the Sorry to have to changed it once you've already released the new version. It should be a quick fix, so I'll have a look at what needs to be changed to achieve this ordering. If you work out what needs editing before I work it out, then please let me know. To help explain, I've used your examples from the docs but edited it to be what I would expect: Example(s) Set to [snes]
regionFromFilename="inline"
regionPrios="eu, br, us, jp"... with game filename 'Game A (Japan, USA).zip' ... with game filename 'Game B (USA, Europe).zip' ... with game filename 'Game C (USA, World, Europe).zip' |
|
I have made the required modification in a fork, and created a pull request accordingly. Let me know if you think this is suitable. |
see #242