Skip to content

Commit 0f28fa3

Browse files
committed
fix: repad rollout samples after sample filtering
1 parent 193de86 commit 0f28fa3

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

slime/slime/ray/rollout.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -649,12 +649,13 @@ def _make_dummy_samples(count: int) -> list[Sample]:
649649
samples = _drop_removed_samples(samples)
650650
samples = self._drop_constant_reward_groups(samples)
651651
dp_size = self.train_parallel_config["dp_size"]
652-
if len(samples) < dp_size:
652+
remainder = len(samples) % dp_size
653+
if len(samples) < dp_size or remainder != 0:
653654
logger.warning(
654655
"Injecting %d dummy samples.",
655-
dp_size - len(samples),
656+
dp_size - remainder,
656657
)
657-
samples.extend(_make_dummy_samples(dp_size - len(samples)))
658+
samples.extend(_make_dummy_samples(dp_size - remainder))
658659

659660
raw_rewards, rewards = self._post_process_rewards(samples)
660661

0 commit comments

Comments
 (0)