refactor: remove UpgradeMode from sample server DTOs and logic#116
Merged
Conversation
- Remove UpgradeMode from VerifyDTO and VerificationResultDTO - Remove UpgradeMode-based filtering and logging in Program.cs Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Refactors the sample update server to remove the UpgradeMode concept from request/response DTOs and from verification-time filtering/logging, aligning the server with a unified-response approach (return all matching packages without mode-based filtering). The PR also introduces a new Hub sample markdown document that is unrelated to the stated scope/issue.
Changes:
- Removed
UpgradeModefromVerifyDTOandVerificationResultDTO. - Removed mode-based filtering and mode-label logging from the verification handler in
Program.cs. - Added a new markdown article under
src/Hub/Samples(scope mismatch with PR description/issue).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Server/Program.cs | Removes UpgradeMode logging/filtering so verification returns all matching packages. |
| src/Server/DTOs/VerifyDTO.cs | Drops UpgradeMode from the verification request DTO. |
| src/Server/DTOs/VerificationResultDTO.cs | Drops UpgradeMode from the verification response DTO. |
| src/Hub/Samples/VS-Code-Claude-Code-DeepSeek-V4-Pro-实战.md | Adds a new article; currently unrelated to the PR’s described purpose and includes a token-like placeholder string. |
Comments suppressed due to low confidence (2)
src/Hub/Samples/VS-Code-Claude-Code-DeepSeek-V4-Pro-实战.md:5
- This PR is scoped (per title/description and issue #115) to removing
UpgradeModefrom the sample server DTOs and verification logic, but it also adds an unrelated long-form article undersrc/Hub/Samples. If this file is intended, please update the PR description/scope; otherwise it should be moved to a separate PR to keep the change set focused and make the issue closure accurate.
src/Hub/Samples/VS-Code-Claude-Code-DeepSeek-V4-Pro-实战.md:26 - The example token value starts with
sk-…, which can look like a real secret and may trigger secret-scanning / false-positive alerts. Consider using a clearly non-secret placeholder that doesn’t resemble common API key formats.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Remove the
UpgradeModefield from the sample server'sVerifyDTOandVerificationResultDTO, along with the filtering and logging logic inProgram.csthat consumed it.