fix(Server): add missing /Upgrade/Report route#72
Closed
JusterZhu wants to merge 2 commits into
Closed
Conversation
The server registers both /Upgrade/Verification and /Update/Verification but only /Update/Report for status reporting. Add /Upgrade/Report so clients using the /Upgrade/* URL variant can report update status. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing route alias in the sample server by adding the /Upgrade/Report endpoint to mirror the existing /Update/Report route, matching the already-supported dual-path pattern used for Verification. This prevents 404s for clients configured to use the /Upgrade/* URL convention when posting update status reports.
Changes:
- Add
POST /Upgrade/Reportmapping to the existinghandleReporthandler to align with/Upgrade/Verification+/Update/Verificationdual routing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add Architecture.md: system architecture, update flow, component relationships - Add Pipeline.md: middleware pipeline deep dive, BSDiff/HDiffPatch algorithms - Add Security.md: TLS, auth (Bearer/API Key/HMAC), AES-256-CBC IPC encryption - Add Configuration.md: complete config reference for all components - Add FAQ.md: 24 frequently asked questions with code examples - Enhance PacketTool.md: add Simulate Update and Config Generator documentation - Enhance Packaging.md: expand from 2 links to comprehensive deployment guide - All new docs include English translations (i18n/en/) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the code fix (adding /Upgrade/Report route) is already in main, and the guide documentation has been merged via other PRs. The PacketTool.md changes conflict with PR #70's rewrite which has already been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server has two URL variants for Verification (
/Upgrade/Verificationand/Update/Verification) but only one for Report (/Update/Report). This causes 404 errors when clients using the/Upgrade/*convention attempt to report update status.Fix
Add
app.MapPost("/Upgrade/Report", handleReport)to mirror the Verification endpoint pattern.Related
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com