feat: generate generalupdate.manifest.json alongside sample project structure (#75)

* feat: generate generalupdate.manifest.json alongside sample project structure

When the user clicks 'Generate Sample Project Structure', the tool now
also writes generalupdate.manifest.json into the sample output directory.
This makes the sample output self-contained — users get both the
published binaries and the update manifest in one step.

Changes:
- SamplePublisherService.PublishAsync: add optional ManifestModel parameter;
  if provided, serialize and write generalupdate.manifest.json into output root
- ConfigViewModel.GenerateSample: build ManifestModel from UI fields
  (falling back to parsed csproj data via ManifestGeneratorService.FromCsprojInfo)
  and pass it to PublishAsync

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: use IsNullOrWhiteSpace in FromCsprojInfo and add semver validation to GenerateSample

- ManifestGeneratorService.FromCsprojInfo: replace ?? with
  !string.IsNullOrWhiteSpace() so that empty/unset UI fields
  correctly fall back to parsed csproj values (MainAppName,
  AppType, UpdateAppName, UpdatePath).
- ConfigViewModel.GenerateSample: run semver validation on
  ClientVersion and UpgradeClientVersion before writing the
  manifest, matching the behavior of the Generate pipeline.

Fixes review feedback from Copilot on PR #75.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: JusterZhu

src/Services/ManifestGeneratorService.cs

@@ -21,17 +21,31 @@ public static string GenerateJson(ManifestModel model)
         return JsonSerializer.Serialize(obj, new JsonSerializerOptions { WriteIndented = true });
     }
 
+    /// <summary>
+    ///     Builds a <see cref="ManifestModel"/> from parsed csproj data,
+    ///     with user input overriding where a non-blank value was supplied.
+    ///     Uses <see cref="string.IsNullOrWhiteSpace"/> so that empty strings
+    ///     (the default for unedited UI fields) still fall back to csproj data.
+    /// </summary>
     public static ManifestModel FromCsprojInfo(CsprojInfo client, CsprojInfo? upgrade, ManifestModel? userInput = null)
     {
         return new ManifestModel
         {
-            MainAppName = userInput?.MainAppName ?? client.AssemblyName,
+            MainAppName = !string.IsNullOrWhiteSpace(userInput?.MainAppName)
+                ? userInput.MainAppName
+                : client.AssemblyName,
             ClientVersion = userInput?.ClientVersion ?? "",
-            AppType = userInput?.AppType ?? "Client",
-            UpdateAppName = userInput?.UpdateAppName ?? upgrade?.AssemblyName ?? "Update.exe",
+            AppType = !string.IsNullOrWhiteSpace(userInput?.AppType)
+                ? userInput.AppType
+                : "Client",
+            UpdateAppName = !string.IsNullOrWhiteSpace(userInput?.UpdateAppName)
+                ? userInput.UpdateAppName
+                : upgrade?.AssemblyName ?? "Update.exe",
             UpgradeClientVersion = userInput?.UpgradeClientVersion ?? "",
             ProductId = userInput?.ProductId ?? "",
-            UpdatePath = userInput?.UpdatePath ?? "update/"
+            UpdatePath = !string.IsNullOrWhiteSpace(userInput?.UpdatePath)
+                ? userInput.UpdatePath
+                : "update/"
         };
     }
 }

src/Services/SamplePublisherService.cs

@@ -11,8 +11,15 @@ public static class SamplePublisherService
     /// <summary>
     ///     Runs <c>dotnet publish</c> for the client and upgrade projects,
     ///     then assembles the output into the Tools running directory.
+    ///     When <paramref name="manifest"/> is provided, also writes
+    ///     <c>generalupdate.manifest.json</c> into the output root.
     /// </summary>
-    public static async Task<string> PublishAsync(CsprojInfo client, CsprojInfo? upgrade, string updatePath, string? baseOutput = null)
+    public static async Task<string> PublishAsync(
+        CsprojInfo client,
+        CsprojInfo? upgrade,
+        string updatePath,
+        string? baseOutput = null,
+        ManifestModel? manifest = null)
     {
         var outputRoot = baseOutput ?? Path.Combine(AppContext.BaseDirectory, "sample_output");
         if (Directory.Exists(outputRoot))
@@ -33,6 +40,14 @@ public static async Task<string> PublishAsync(CsprojInfo client, CsprojInfo? upg
             await RunDotnetPublishAsync(upgrade.CsprojPath, updateDir);
         }
 
+        // Write manifest.json into the output root if provided
+        if (manifest != null)
+        {
+            var json = ManifestGeneratorService.GenerateJson(manifest);
+            var manifestPath = Path.Combine(outputRoot, "generalupdate.manifest.json");
+            await File.WriteAllTextAsync(manifestPath, json);
+        }
+
         return outputRoot;
     }
 

src/ViewModels/ConfigViewModel.cs

@@ -225,7 +225,30 @@ private async Task GenerateSample()
                 return;
             }
 
-            var output = await SamplePublisherService.PublishAsync(client, upgrade, Model.UpdatePath);
+            // Build manifest from current UI fields, falling back to parsed csproj data
+            var manifest = ManifestGeneratorService.FromCsprojInfo(client, upgrade,
+                new ManifestModel
+                {
+                    MainAppName = Model.MainAppName,
+                    ClientVersion = Model.ClientVersion,
+                    AppType = Model.AppType,
+                    UpdateAppName = Model.UpdateAppName,
+                    UpgradeClientVersion = Model.UpgradeClientVersion,
+                    ProductId = Model.ProductId,
+                    UpdatePath = Model.UpdatePath
+                });
+
+            // Validate semver before writing manifest (same check as the Generate pipeline)
+            var validateCtx = new PipelineContext();
+            SemverValidateStep.Validate(manifest.ClientVersion, nameof(manifest.ClientVersion), validateCtx);
+            SemverValidateStep.Validate(manifest.UpgradeClientVersion, nameof(manifest.UpgradeClientVersion), validateCtx);
+            if (validateCtx.Errors.Count > 0)
+            {
+                Model.StatusText = string.Join("; ", validateCtx.Errors);
+                return;
+            }
+
+            var output = await SamplePublisherService.PublishAsync(client, upgrade, Model.UpdatePath, manifest: manifest);
             Model.StatusText = $"{_loc["Config.SampleGenerated"]}: {output}";
 
             await DialogHelper.ShowInfoAsync(_loc["Config.Title"],