Skip to content

Commit 3a46d53

Browse files
committed
fix: start server before generating scripts so port is correct
- Server starts first, reads actual bound port - Scripts generated after with correct port in URLs - Fixes port mismatch when 5000 is occupied
1 parent a6c6ee5 commit 3a46d53

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

src/Services/SimulationService.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,8 @@ public async Task<SimulationResult> RunAsync(
3535
Log($"STEP 2: Preparing {config.OutputDirectory}", progress);
3636
Directory.CreateDirectory(config.OutputDirectory);
3737

38-
// 3. Generate scripts
39-
Log("STEP 3: Generating client.csx and upgrade.csx", progress);
40-
await _generator.GenerateAsync(config, config.OutputDirectory);
41-
Log($" client.csx → {config.OutputDirectory}", progress);
42-
Log($" upgrade.csx → {config.OutputDirectory}", progress);
43-
44-
// 4. Start server
45-
Log("STEP 4: Starting local server", progress);
38+
// 3. Start server first (get actual port)
39+
Log("STEP 3: Starting local server", progress);
4640
var serverPatchDir = Path.Combine(config.OutputDirectory, ".server");
4741
Directory.CreateDirectory(serverPatchDir);
4842
var patchName = Path.GetFileName(config.PatchFilePath);
@@ -54,8 +48,14 @@ public async Task<SimulationResult> RunAsync(
5448
_server.Updates.Add((config.CurrentVersion, config.TargetVersion, hash, patchDest, config.AppType));
5549

5650
await _server.StartAsync(config.ServerPort);
57-
Log($" Server running on {_server.BaseUrl}", progress);
5851
config.ServerPort = _server.Port;
52+
Log($" Server running on {_server.BaseUrl}", progress);
53+
54+
// 4. Generate scripts (now with actual port)
55+
Log("STEP 4: Generating client.csx and upgrade.csx", progress);
56+
await _generator.GenerateAsync(config, config.OutputDirectory);
57+
Log($" client.csx → {config.OutputDirectory}", progress);
58+
Log($" upgrade.csx → {config.OutputDirectory}", progress);
5959

6060
// 5. Run client
6161
Log("STEP 5: Running client (dotnet script client.csx)", progress);

0 commit comments

Comments
 (0)