Skip to content

Commit 87abb9c

Browse files
JusterZhuclaude
andcommitted
fix(ci): fix release job losing build artifacts
Two bugs introduced in 0254b74 caused releases to have no usable apps: 1. actions/checkout@v6 does not exist — changed to @v4 2. Checkout step ran after packaging, and git clean (default) deleted the zip files before the release step could upload them. Moved checkout+changelog before download-artifact so packaging happens after checkout and zips survive until the release step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 0254b74 commit 87abb9c

1 file changed

Lines changed: 17 additions & 17 deletions

File tree

.github/workflows/publish.yml

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -76,24 +76,8 @@ jobs:
7676
permissions:
7777
contents: write
7878
steps:
79-
- uses: actions/download-artifact@v4
80-
81-
- name: Get timestamp
82-
id: ts
83-
run: echo "timestamp=$(date -u '+%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
84-
85-
- name: Package win
86-
working-directory: win-x64
87-
run: zip ../GeneralUpdate.Tools_${{ steps.ts.outputs.timestamp }}_win-x64.zip -r *
88-
89-
- name: Package linux
90-
working-directory: linux-x64
91-
run: |
92-
chmod +x *
93-
zip ../GeneralUpdate.Tools_${{ steps.ts.outputs.timestamp }}_linux-x64.zip -r *
94-
9579
- name: Checkout for changelog
96-
uses: actions/checkout@v6
80+
uses: actions/checkout@v4
9781
with:
9882
fetch-depth: 0
9983

@@ -144,6 +128,22 @@ jobs:
144128
echo "=== Generated changelog ==="
145129
cat changelog.md
146130
131+
- uses: actions/download-artifact@v4
132+
133+
- name: Get timestamp
134+
id: ts
135+
run: echo "timestamp=$(date -u '+%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
136+
137+
- name: Package win
138+
working-directory: win-x64
139+
run: zip ../GeneralUpdate.Tools_${{ steps.ts.outputs.timestamp }}_win-x64.zip -r *
140+
141+
- name: Package linux
142+
working-directory: linux-x64
143+
run: |
144+
chmod +x *
145+
zip ../GeneralUpdate.Tools_${{ steps.ts.outputs.timestamp }}_linux-x64.zip -r *
146+
147147
- name: Create Release
148148
uses: softprops/action-gh-release@v2
149149
with:

0 commit comments

Comments
 (0)