fix: harden config module against corruption, I/O failures, and silent data loss

JusterZhu · claude · JusterZhu · commit d6dfbe842224 · 2026-06-02T15:19:42.000+08:00
Risks discovered in security review and their mitigations:

1. [HIGH] Invalid enum deserialization from manual JSON edits
   - Add AppConfig.Sanitize() + AuthCredential.Sanitize() to repair invalid
     AuthScheme values and null nested objects on load

2. [HIGH] Narrow exception catch in Load() — only caught JsonException
   - Expanded to catch IOException + UnauthorizedAccessException to handle
     disk-full and permission-denied scenarios gracefully

3. [HIGH] Fire-and-forget SaveAsync exceptions silently lost
   - Added ConfigService.SafeFireAndForgetSave() that logs failures to Trace
   - Updated all 12 fire-and-forget call sites in App + 4 ViewModels

4. [MEDIUM] Unnecessary disk write on every startup
   - OnAutoUploadEnabledChanged in PatchViewModel constructor triggered
     SaveAsync during init. Added _initialized guard to skip during construction

5. [LOW] Corrupted config silently overwrites backup before recovery attempt
   - Sanitize() is called on recovered configs before re-saving to disk

Co-Authored-By: Claude Opus 4.8 &lt;noreply@anthropic.com&gt;
diff --git a/src/App.axaml.cs b/src/App.axaml.cs
@@ -69,8 +69,8 @@ public override void OnFrameworkInitializationCompleted()
                     config.WindowHeight = mainWindow.Height;
                 }
 
-                // Fire-and-forget save
-                _ = configService.SaveAsync();
+                // Fire-and-forget save (exceptions logged to Trace, not lost)
+                ConfigService.SafeFireAndForgetSave(configService);
             };
 
             desktop.MainWindow = mainWindow;
diff --git a/src/Configuration/AppConfig.cs b/src/Configuration/AppConfig.cs
@@ -112,4 +112,28 @@ public class AppConfig
 
     [JsonProperty("showJsonPreview")]
     public bool ShowJsonPreview { get; set; } = true;
+
+    // ── Sanitization ───────────────────────────────────────────
+
+    /// <summary>
+    /// Repair invalid values that may have been introduced by manual JSON editing
+    /// or deserialization of an unknown/invalid enum value.
+    /// Called automatically by <see cref="ConfigService.Load"/> after deserialization.
+    /// </summary>
+    internal void Sanitize()
+    {
+        // Repair null nested objects (should never be null, but guard against manual JSON edits)
+        UploadAuth ??= new AuthCredential();
+        SimulationAuth ??= new AuthCredential();
+
+        // Validate numeric ranges
+        if (UploadTimeoutSeconds < 10)
+            UploadTimeoutSeconds = 300;
+        if (UploadRetryCount is < 0 or > 10)
+            UploadRetryCount = 3;
+
+        // Repair invalid enum values in auth credentials
+        UploadAuth.Sanitize();
+        SimulationAuth.Sanitize();
+    }
 }
diff --git a/src/Configuration/AuthCredential.cs b/src/Configuration/AuthCredential.cs
@@ -1,3 +1,5 @@
+using System;
+
 namespace GeneralUpdate.Tools.Configuration;
 
 /// <summary>
@@ -35,4 +37,14 @@ public class AuthCredential
 
     /// <summary>DPAPI-encrypted API key value.</summary>
     public string EncryptedApiKey { get; set; } = string.Empty;
+
+    /// <summary>
+    /// Repair invalid enum values that may result from manual JSON editing
+    /// or unknown future scheme values.
+    /// </summary>
+    internal void Sanitize()
+    {
+        if (!Enum.IsDefined(typeof(AuthScheme), Scheme))
+            Scheme = AuthScheme.None;
+    }
 }
diff --git a/src/Configuration/ConfigService.cs b/src/Configuration/ConfigService.cs
@@ -50,7 +50,8 @@ public void Load()
                 {
                     var backupJson = File.ReadAllText(_backupPath);
                     Config = JsonConvert.DeserializeObject<AppConfig>(backupJson, JsonSettings) ?? new AppConfig();
-                    Save(); // Restore main file from backup
+                    Config.Sanitize();  // repair invalid enum values etc.
+                    Save();
                     return;
                 }
                 catch
@@ -59,7 +60,6 @@ public void Load()
                 }
             }
 
-            // First run: save defaults so the file exists
             Config = new AppConfig();
             Save();
             return;
@@ -69,19 +69,21 @@ public void Load()
         {
             var json = File.ReadAllText(_configPath);
             Config = JsonConvert.DeserializeObject<AppConfig>(json, JsonSettings) ?? new AppConfig();
+            Config.Sanitize();
 
             // Run schema migrations
             Migrate();
         }
-        catch (JsonException)
+        catch (Exception ex) when (ex is JsonException or IOException or UnauthorizedAccessException)
         {
-            // Config file is corrupted; try backup
+            // Config file is corrupted or inaccessible; try backup
             if (File.Exists(_backupPath))
             {
                 try
                 {
                     var backupJson = File.ReadAllText(_backupPath);
                     Config = JsonConvert.DeserializeObject<AppConfig>(backupJson, JsonSettings) ?? new AppConfig();
+                    Config.Sanitize();
                     Save();
                     return;
                 }
@@ -158,15 +160,16 @@ public async Task LoadAsync()
             // Run schema migrations
             Migrate();
         }
-        catch (JsonException)
+        catch (Exception ex) when (ex is JsonException or IOException or UnauthorizedAccessException)
         {
-            // Config file is corrupted; try backup
+            // Config file is corrupted or inaccessible; try backup
             if (File.Exists(_backupPath))
             {
                 try
                 {
                     var backupJson = await File.ReadAllTextAsync(_backupPath);
                     Config = JsonConvert.DeserializeObject<AppConfig>(backupJson, JsonSettings) ?? new AppConfig();
+                    Config.Sanitize();
                     await SaveAsync();
                     return;
                 }
@@ -181,6 +184,26 @@ public async Task LoadAsync()
         }
     }
 
+    /// <summary>
+    /// Fire-and-forget safe save. Logs exceptions via System.Diagnostics.Trace
+    /// rather than losing them silently — no crash, no dialog, just a trace log.
+    /// </summary>
+    public static void SafeFireAndForgetSave(ConfigService service)
+    {
+        _ = Task.Run(async () =>
+        {
+            try
+            {
+                await service.SaveAsync();
+            }
+            catch (Exception ex)
+            {
+                System.Diagnostics.Trace.WriteLine(
+                    $"[GeneralUpdate.Tools] Config save failed: {ex.Message}");
+            }
+        });
+    }
+
     /// <inheritdoc />
     public async Task SaveAsync()
     {
diff --git a/src/ViewModels/ConfigViewModel.cs b/src/ViewModels/ConfigViewModel.cs
@@ -65,7 +65,7 @@ private async Task BrowseClient()
         {
             Model.ClientPath = files[0].Path.LocalPath;
             _config.LastConfigClientPath = files[0].Path.LocalPath;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
@@ -88,7 +88,7 @@ private async Task BrowseUpgrade()
         {
             Model.UpgradePath = files[0].Path.LocalPath;
             _config.LastConfigUpgradePath = files[0].Path.LocalPath;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
diff --git a/src/ViewModels/ExtensionViewModel.cs b/src/ViewModels/ExtensionViewModel.cs
@@ -64,7 +64,7 @@ async Task SelectExt()
         {
             Config.ExtensionDirectory = p;
             _config.LastExtensionDir = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
@@ -76,7 +76,7 @@ async Task SelectExport()
         {
             Config.ExportPath = p;
             _config.LastExtensionOutputDir = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
diff --git a/src/ViewModels/MainWindowViewModel.cs b/src/ViewModels/MainWindowViewModel.cs
@@ -80,7 +80,7 @@ private void ToggleTheme()
 
         // Persist
         _config.Theme = IsDarkTheme ? "Dark" : "Light";
-        _ = ConfigServiceSingleton.Instance.SaveAsync();
+        ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
     }
 
     [RelayCommand]
@@ -97,7 +97,7 @@ private void ToggleLocale()
 
         // Persist
         _config.Language = newLocale;
-        _ = ConfigServiceSingleton.Instance.SaveAsync();
+        ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
     }
 
     private static void ApplyTheme(bool isDark)
diff --git a/src/ViewModels/PatchViewModel.cs b/src/ViewModels/PatchViewModel.cs
@@ -43,13 +43,17 @@ public PatchViewModel(AppConfig config)
         AutoUploadEnabled = config.AutoUploadEnabled;
 
         _status = _loc["Patch.Ready"];
+        _initialized = true;
     }
 
-    /// <summary>Persist auto-upload toggle changes immediately.</summary>
+    private bool _initialized;
+
+    /// <summary>Persist auto-upload toggle changes immediately (skip during construction).</summary>
     partial void OnAutoUploadEnabledChanged(bool value)
     {
+        if (!_initialized) return;
         _config.AutoUploadEnabled = value;
-        _ = ConfigServiceSingleton.Instance.SaveAsync();
+        ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
     }
 
     async Task<string?> Pick()
@@ -71,7 +75,7 @@ async Task SelectOld()
         {
             Config.OldDirectory = p;
             _config.LastPatchOldDir = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
             L(_loc.T("Patch.OldSelected", p));
         }
     }
@@ -84,7 +88,7 @@ async Task SelectNew()
         {
             Config.NewDirectory = p;
             _config.LastPatchNewDir = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
             L(_loc.T("Patch.NewSelected", p));
         }
     }
@@ -97,7 +101,7 @@ async Task SelectOut()
         {
             Config.OutputPath = p;
             _config.LastPatchOutputDir = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
@@ -118,7 +122,7 @@ async Task Build()
 
         // Persist encryption scan preference
         _config.EncryptionScanEnabled = Config.EnableEncryptionCheck;
-        _ = ConfigServiceSingleton.Instance.SaveAsync();
+        ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
 
         IsBuilding = true;
         Log.Clear();
diff --git a/src/ViewModels/SimulateViewModel.cs b/src/ViewModels/SimulateViewModel.cs
@@ -94,7 +94,7 @@ async Task SelectAppDir()
         {
             Config.AppDirectory = p;
             _config.LastSimulateAppDir = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
@@ -106,7 +106,7 @@ async Task SelectPatch()
         {
             Config.PatchFilePath = p;
             _config.LastSimulatePatchFile = p;
-            _ = ConfigServiceSingleton.Instance.SaveAsync();
+            ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
         }
     }
 
@@ -130,7 +130,7 @@ async Task StartSimulation()
         _config.SimulationServerPort = Config.ServerPort.ToString();
         _config.SimulationPlatformType = Config.Platform == 2 ? "Linux" : "Windows";
         _config.SimulationAppType = Config.AppType == 2 ? "UpgradeApp" : "ClientApp";
-        _ = ConfigServiceSingleton.Instance.SaveAsync();
+        ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);
 
         IsRunning = true; StartButtonText = "⏳ Running..."; Log.Clear(); Status = _loc["Sim.Starting"];
         try

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,8 @@ public override void OnFrameworkInitializationCompleted()`
`69`	`69`	`config.WindowHeight = mainWindow.Height;`
`70`	`70`	`}`
`71`	`71`
`72`		`- // Fire-and-forget save`
`73`		`- _ = configService.SaveAsync();`
	`72`	`+ // Fire-and-forget save (exceptions logged to Trace, not lost)`
	`73`	`+ ConfigService.SafeFireAndForgetSave(configService);`
`74`	`74`	`};`
`75`	`75`
`76`	`76`	`desktop.MainWindow = mainWindow;`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,8 @@ public void Load()`
`50`	`50`	`{`
`51`	`51`	`var backupJson = File.ReadAllText(_backupPath);`
`52`	`52`	`Config = JsonConvert.DeserializeObject<AppConfig>(backupJson, JsonSettings) ?? new AppConfig();`
`53`		`- Save(); // Restore main file from backup`
	`53`	`+ Config.Sanitize(); // repair invalid enum values etc.`
	`54`	`+ Save();`
`54`	`55`	`return;`
`55`	`56`	`}`
`56`	`57`	`catch`
`@@ -59,7 +60,6 @@ public void Load()`
`59`	`60`	`}`
`60`	`61`	`}`
`61`	`62`
`62`		`- // First run: save defaults so the file exists`
`63`	`63`	`Config = new AppConfig();`
`64`	`64`	`Save();`
`65`	`65`	`return;`
`@@ -69,19 +69,21 @@ public void Load()`
`69`	`69`	`{`
`70`	`70`	`var json = File.ReadAllText(_configPath);`
`71`	`71`	`Config = JsonConvert.DeserializeObject<AppConfig>(json, JsonSettings) ?? new AppConfig();`
	`72`	`+ Config.Sanitize();`
`72`	`73`
`73`	`74`	`// Run schema migrations`
`74`	`75`	`Migrate();`
`75`	`76`	`}`
`76`		`- catch (JsonException)`
	`77`	`+ catch (Exception ex) when (ex is JsonException or IOException or UnauthorizedAccessException)`
`77`	`78`	`{`
`78`		`- // Config file is corrupted; try backup`
	`79`	`+ // Config file is corrupted or inaccessible; try backup`
`79`	`80`	`if (File.Exists(_backupPath))`
`80`	`81`	`{`
`81`	`82`	`try`
`82`	`83`	`{`
`83`	`84`	`var backupJson = File.ReadAllText(_backupPath);`
`84`	`85`	`Config = JsonConvert.DeserializeObject<AppConfig>(backupJson, JsonSettings) ?? new AppConfig();`
	`86`	`+ Config.Sanitize();`
`85`	`87`	`Save();`
`86`	`88`	`return;`
`87`	`89`	`}`
`@@ -158,15 +160,16 @@ public async Task LoadAsync()`
`158`	`160`	`// Run schema migrations`
`159`	`161`	`Migrate();`
`160`	`162`	`}`
`161`		`- catch (JsonException)`
	`163`	`+ catch (Exception ex) when (ex is JsonException or IOException or UnauthorizedAccessException)`
`162`	`164`	`{`
`163`		`- // Config file is corrupted; try backup`
	`165`	`+ // Config file is corrupted or inaccessible; try backup`
`164`	`166`	`if (File.Exists(_backupPath))`
`165`	`167`	`{`
`166`	`168`	`try`
`167`	`169`	`{`
`168`	`170`	`var backupJson = await File.ReadAllTextAsync(_backupPath);`
`169`	`171`	`Config = JsonConvert.DeserializeObject<AppConfig>(backupJson, JsonSettings) ?? new AppConfig();`
	`172`	`+ Config.Sanitize();`
`170`	`173`	`await SaveAsync();`
`171`	`174`	`return;`
`172`	`175`	`}`
`@@ -181,6 +184,26 @@ public async Task LoadAsync()`
`181`	`184`	`}`
`182`	`185`	`}`
`183`	`186`
	`187`	`+ /// <summary>`
	`188`	`+ /// Fire-and-forget safe save. Logs exceptions via System.Diagnostics.Trace`
	`189`	`+ /// rather than losing them silently — no crash, no dialog, just a trace log.`
	`190`	`+ /// </summary>`
	`191`	`+ public static void SafeFireAndForgetSave(ConfigService service)`
	`192`	`+ {`
	`193`	`+ _ = Task.Run(async () =>`
	`194`	`+ {`
	`195`	`+ try`
	`196`	`+ {`
	`197`	`+ await service.SaveAsync();`
	`198`	`+ }`
	`199`	`+ catch (Exception ex)`
	`200`	`+ {`
	`201`	`+ System.Diagnostics.Trace.WriteLine(`
	`202`	`+ $"[GeneralUpdate.Tools] Config save failed: {ex.Message}");`
	`203`	`+ }`
	`204`	`+ });`
	`205`	`+ }`
	`206`	`+`
`184`	`207`	`/// <inheritdoc />`
`185`	`208`	`public async Task SaveAsync()`
`186`	`209`	`{`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ private async Task BrowseClient()`
`65`	`65`	`{`
`66`	`66`	`Model.ClientPath = files[0].Path.LocalPath;`
`67`	`67`	`_config.LastConfigClientPath = files[0].Path.LocalPath;`
`68`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`68`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
`@@ -88,7 +88,7 @@ private async Task BrowseUpgrade()`
`88`	`88`	`{`
`89`	`89`	`Model.UpgradePath = files[0].Path.LocalPath;`
`90`	`90`	`_config.LastConfigUpgradePath = files[0].Path.LocalPath;`
`91`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`91`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ async Task SelectExt()`
`64`	`64`	`{`
`65`	`65`	`Config.ExtensionDirectory = p;`
`66`	`66`	`_config.LastExtensionDir = p;`
`67`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`67`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`@@ -76,7 +76,7 @@ async Task SelectExport()`
`76`	`76`	`{`
`77`	`77`	`Config.ExportPath = p;`
`78`	`78`	`_config.LastExtensionOutputDir = p;`
`79`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`79`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`80`	`80`	`}`
`81`	`81`	`}`
`82`	`82`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ private void ToggleTheme()`
`80`	`80`
`81`	`81`	`// Persist`
`82`	`82`	`_config.Theme = IsDarkTheme ? "Dark" : "Light";`
`83`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`83`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`[RelayCommand]`
`@@ -97,7 +97,7 @@ private void ToggleLocale()`
`97`	`97`
`98`	`98`	`// Persist`
`99`	`99`	`_config.Language = newLocale;`
`100`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`100`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`private static void ApplyTheme(bool isDark)`
Original file line number	Diff line number	Diff line change
`@@ -43,13 +43,17 @@ public PatchViewModel(AppConfig config)`
`43`	`43`	`AutoUploadEnabled = config.AutoUploadEnabled;`
`44`	`44`
`45`	`45`	`_status = _loc["Patch.Ready"];`
	`46`	`+ _initialized = true;`
`46`	`47`	`}`
`47`	`48`
`48`		`- /// <summary>Persist auto-upload toggle changes immediately.</summary>`
	`49`	`+ private bool _initialized;`
	`50`	`+`
	`51`	`+ /// <summary>Persist auto-upload toggle changes immediately (skip during construction).</summary>`
`49`	`52`	`partial void OnAutoUploadEnabledChanged(bool value)`
`50`	`53`	`{`
	`54`	`+ if (!_initialized) return;`
`51`	`55`	`_config.AutoUploadEnabled = value;`
`52`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`56`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`53`	`57`	`}`
`54`	`58`
`55`	`59`	`async Task<string?> Pick()`
`@@ -71,7 +75,7 @@ async Task SelectOld()`
`71`	`75`	`{`
`72`	`76`	`Config.OldDirectory = p;`
`73`	`77`	`_config.LastPatchOldDir = p;`
`74`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`78`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`75`	`79`	`L(_loc.T("Patch.OldSelected", p));`
`76`	`80`	`}`
`77`	`81`	`}`
`@@ -84,7 +88,7 @@ async Task SelectNew()`
`84`	`88`	`{`
`85`	`89`	`Config.NewDirectory = p;`
`86`	`90`	`_config.LastPatchNewDir = p;`
`87`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`91`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`88`	`92`	`L(_loc.T("Patch.NewSelected", p));`
`89`	`93`	`}`
`90`	`94`	`}`
`@@ -97,7 +101,7 @@ async Task SelectOut()`
`97`	`101`	`{`
`98`	`102`	`Config.OutputPath = p;`
`99`	`103`	`_config.LastPatchOutputDir = p;`
`100`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`104`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`101`	`105`	`}`
`102`	`106`	`}`
`103`	`107`
`@@ -118,7 +122,7 @@ async Task Build()`
`118`	`122`
`119`	`123`	`// Persist encryption scan preference`
`120`	`124`	`_config.EncryptionScanEnabled = Config.EnableEncryptionCheck;`
`121`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`125`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`122`	`126`
`123`	`127`	`IsBuilding = true;`
`124`	`128`	`Log.Clear();`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ async Task SelectAppDir()`
`94`	`94`	`{`
`95`	`95`	`Config.AppDirectory = p;`
`96`	`96`	`_config.LastSimulateAppDir = p;`
`97`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`97`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`@@ -106,7 +106,7 @@ async Task SelectPatch()`
`106`	`106`	`{`
`107`	`107`	`Config.PatchFilePath = p;`
`108`	`108`	`_config.LastSimulatePatchFile = p;`
`109`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`109`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
`@@ -130,7 +130,7 @@ async Task StartSimulation()`
`130`	`130`	`_config.SimulationServerPort = Config.ServerPort.ToString();`
`131`	`131`	`_config.SimulationPlatformType = Config.Platform == 2 ? "Linux" : "Windows";`
`132`	`132`	`_config.SimulationAppType = Config.AppType == 2 ? "UpgradeApp" : "ClientApp";`
`133`		`- _ = ConfigServiceSingleton.Instance.SaveAsync();`
	`133`	`+ ConfigService.SafeFireAndForgetSave(ConfigServiceSingleton.Instance);`
`134`	`134`
`135`	`135`	`IsRunning = true; StartButtonText = "⏳ Running..."; Log.Clear(); Status = _loc["Sim.Starting"];`
`136`	`136`	`try`