-
Notifications
You must be signed in to change notification settings - Fork 75
Expand file tree
/
Copy pathDownloadPlanBuilderTests.cs
More file actions
483 lines (438 loc) · 18.8 KB
/
Copy pathDownloadPlanBuilderTests.cs
File metadata and controls
483 lines (438 loc) · 18.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
using GeneralUpdate.Core.Configuration;
using GeneralUpdate.Core.Download;
using GeneralUpdate.Core.Download.Models;
namespace CoreTest.Download;
public class DownloadPlanBuilderTests
{
private static DownloadAsset Asset(string name = "a", string version = "2.0.0", string url = "http://u",
long size = 100, string hash = null, bool isFreeze = false, bool isForcibly = false,
int packageType = (int)PackageType.Chain, string minClientVersion = null)
=> new(name, url, size, hash, version,
IsFreeze: isFreeze, IsForcibly: isForcibly,
PackageType: packageType, MinClientVersion: minClientVersion);
[Fact]
public void Build_AssetsNull_ReturnsEmpty()
{
var result = DownloadPlanBuilder.Build(null, "1.0.0");
Assert.False(result.HasAssets);
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
[InlineData("invalid")]
public void Build_CurrentVersionInvalid_ReturnsEmpty(string version)
{
var result = DownloadPlanBuilder.Build(new[] { Asset("a", "2.0.0") }, version);
Assert.False(result.HasAssets);
}
[Fact]
public void Build_AllAssetsFrozen_ReturnsEmpty()
{
var assets = new[]
{
Asset("a", "2.0.0", isFreeze: true),
Asset("b", "3.0.0", isFreeze: true)
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.False(result.HasAssets);
}
[Fact]
public void Build_SingleAssetVersionAboveCurrent_HasAssets()
{
var assets = new[] { Asset("update", "2.0.0") };
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.True(result.HasAssets);
Assert.Single(result.Assets);
}
[Fact]
public void Build_AllVersionsBelowOrEqual_ReturnsEmpty()
{
var assets = new[] { Asset("old", "1.0.0"), Asset("older", "0.9.0") };
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.False(result.HasAssets);
}
[Fact]
public void Build_AnyAssetIsForcibly_IsForciblyTrue()
{
var assets = new[]
{
Asset("a", "2.0.0"),
Asset("b", "2.1.0", isForcibly: true)
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.True(result.IsForcibly);
}
[Fact]
public void Build_NoAssetIsForcibly_IsForciblyFalse()
{
var assets = new[] { Asset("a", "2.0.0") };
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.False(result.IsForcibly);
}
[Fact]
public void Build_FullPackageSelected_WhenChainTotalExceedsFullSize()
{
// 2 chain packages (total 200), full=100 → 200 >= 100 → full selected
var assets = new[]
{
Asset("chain1", "1.1.0", size: 100),
Asset("chain2", "2.0.0", size: 100),
Asset("full", "2.0.0", packageType: (int)PackageType.Full),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.True(result.HasAssets);
Assert.Single(result.Assets);
Assert.Equal((int)PackageType.Full, result.Assets[0].PackageType);
Assert.Equal("2.0.0", result.Assets[0].Version);
}
[Fact]
public void Build_FullPackageSelected_WhenChainCountExceedsMaxChainBeforeFallback()
{
// 12 small chain packages (total 120), full=500, maxChainBeforeFallback=10
// → chain count 12 > 10 → full selected despite chain being much smaller
var assets = new List<DownloadAsset>();
for (int i = 1; i <= 12; i++)
assets.Add(Asset($"chain{i}", $"1.{i}.0", size: 10));
assets.Add(Asset("full", "2.0.0", size: 500, packageType: (int)PackageType.Full));
var result = DownloadPlanBuilder.Build(assets, "1.0.0", null, maxChainBeforeFallback: 10);
Assert.True(result.HasAssets);
Assert.Single(result.Assets);
Assert.Equal((int)PackageType.Full, result.Assets[0].PackageType);
}
[Fact]
public void Build_ChainSelected_WhenCountBelowThresholdAndTotalBelowFullSize()
{
// 3 chain packages (total 150), full=500, maxChainBeforeFallback=default(8)
// → chain count 3 <= 8 AND 150 < 500 → chain selected
var assets = new[]
{
Asset("chain1", "1.1.0", size: 50),
Asset("chain2", "1.2.0", size: 50),
Asset("chain3", "2.0.0", size: 50),
Asset("full", "2.0.0", size: 500, packageType: (int)PackageType.Full),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.True(result.HasAssets);
Assert.Equal(3, result.Assets.Count);
Assert.All(result.Assets, a => Assert.Equal((int)PackageType.Chain, a.PackageType));
}
[Fact]
public void Build_FullPackageSelected_WhenChainTotalEqualsFullSize()
{
// chain total == full size → full selected (boundary: >= not >)
var assets = new[]
{
Asset("chain1", "1.1.0", size: 200),
Asset("chain2", "2.0.0", size: 300),
Asset("full", "2.0.0", size: 500, packageType: (int)PackageType.Full),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0", null, maxChainBeforeFallback: 10);
Assert.True(result.HasAssets);
Assert.Single(result.Assets);
Assert.Equal((int)PackageType.Full, result.Assets[0].PackageType);
}
[Fact]
public void Build_ChainSelected_WhenMaxChainBeforeFallbackIsZero()
{
// maxChainBeforeFallback=0 disables count-based fallback
// 25 chain packages (total 400), full=500 → 400 < 500 → chain selected
var assets = new List<DownloadAsset>();
for (int i = 1; i <= 25; i++)
assets.Add(Asset($"chain{i}", $"1.{i}.0", size: 16));
assets.Add(Asset("full", "2.0.0", size: 500, packageType: (int)PackageType.Full));
var result = DownloadPlanBuilder.Build(assets, "1.0.0", null, maxChainBeforeFallback: 0);
Assert.True(result.HasAssets);
Assert.Equal(25, result.Assets.Count);
Assert.All(result.Assets, a => Assert.Equal((int)PackageType.Chain, a.PackageType));
}
[Fact]
public void Build_MixedAppType_FullSwitchKeepsOtherAppTypeChains()
{
// Client full v2.0 + 12 Client chains (trigger count) + 3 Upgrade chains.
// → Client chains replaced by Client full, Upgrade chains kept.
var assets = new List<DownloadAsset>();
for (int i = 1; i <= 12; i++)
assets.Add(AssetWithType($"client-chain{i}", $"1.{i}.0", size: 10, appType: (int)AppType.Client));
for (int i = 1; i <= 3; i++)
assets.Add(AssetWithType($"upgrade-chain{i}", $"1.{i}.0", size: 10, appType: (int)AppType.Upgrade));
assets.Add(AssetWithType("client-full", "2.0.0", size: 500, packageType: (int)PackageType.Full, appType: (int)AppType.Client));
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "1.0.0", maxChainBeforeFallback: 8);
Assert.True(result.HasAssets);
// 1 Client full + 3 Upgrade chains = 4 assets
Assert.Equal(4, result.Assets.Count);
Assert.Contains(result.Assets, a => a.PackageType == (int)PackageType.Full && a.AppType == (int)AppType.Client);
Assert.Equal(3, result.Assets.Count(a => a.AppType == (int)AppType.Upgrade));
}
[Fact]
public void Build_MixedAppType_OnlyFullForUpgrade_DoesNotAffectClientChains()
{
// Upgrade full v2.0 + 3 Upgrade chains (below threshold) + 5 Client chains.
// No Client full → count/size check scoped to Upgrade chains only.
// 3 Upgrade chains ≤ 8, total 30 < 500 → chain plan with Upgrade fallback.
var assets = new List<DownloadAsset>();
for (int i = 1; i <= 5; i++)
assets.Add(AssetWithType($"client-chain{i}", $"1.{i}.0", size: 20, appType: (int)AppType.Client));
for (int i = 1; i <= 3; i++)
assets.Add(AssetWithType($"upgrade-chain{i}", $"1.{i}.0", size: 10, appType: (int)AppType.Upgrade));
assets.Add(AssetWithType("upgrade-full", "2.0.0", size: 500, packageType: (int)PackageType.Full, appType: (int)AppType.Upgrade));
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "1.0.0", maxChainBeforeFallback: 8);
Assert.True(result.HasAssets);
// All 8 chain packages selected, none replaced
Assert.Equal(8, result.Assets.Count);
Assert.All(result.Assets, a => Assert.Equal((int)PackageType.Chain, a.PackageType));
}
[Fact]
public void Build_MixedAppType_CountTriggersForClient_UpgradeChainsUnaffected()
{
// Client full + 12 Client chains (triggers count) + 12 Upgrade chains (no Upgrade full).
// → Client chains replaced by Client full, all 12 Upgrade chains kept.
var assets = new List<DownloadAsset>();
for (int i = 1; i <= 12; i++)
assets.Add(AssetWithType($"client-chain{i}", $"1.{i}.0", size: 5, appType: (int)AppType.Client));
for (int i = 1; i <= 12; i++)
assets.Add(AssetWithType($"upgrade-chain{i}", $"1.{i}.0", size: 5, appType: (int)AppType.Upgrade));
assets.Add(AssetWithType("client-full", "2.0.0", size: 500, packageType: (int)PackageType.Full, appType: (int)AppType.Client));
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "1.0.0", maxChainBeforeFallback: 8);
Assert.True(result.HasAssets);
// 1 Client full + 12 Upgrade chains (no Upgrade full → kept as-is)
Assert.Equal(13, result.Assets.Count);
Assert.Equal(12, result.Assets.Count(a => a.AppType == (int)AppType.Upgrade));
Assert.Single(result.Assets, a => a.PackageType == (int)PackageType.Full);
}
[Fact]
public void Build_MinClientVersionTooHigh_FilteredOut()
{
var assets = new[]
{
Asset("high", "3.0.0", minClientVersion: "2.0.0")
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.False(result.HasAssets);
}
[Fact]
public void Build_MinClientVersionOk_Included()
{
var assets = new[]
{
Asset("ok", "3.0.0", minClientVersion: "1.0.0")
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.True(result.HasAssets);
}
[Fact]
public void Build_ChainOrderedByVersionAscending()
{
var assets = new[]
{
Asset("c", "3.0.0"), Asset("a", "1.1.0"), Asset("b", "2.0.0")
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.Equal(3, result.Assets.Count);
Assert.Equal("1.1.0", result.Assets[0].Version);
Assert.Equal("2.0.0", result.Assets[1].Version);
Assert.Equal("3.0.0", result.Assets[2].Version);
}
[Fact]
public void Build_MixedFrozenAndActive_FiltersFrozen()
{
var assets = new[]
{
Asset("active", "2.0.0"),
Asset("frozen", "3.0.0", isFreeze: true)
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.Single(result.Assets);
Assert.Equal("2.0.0", result.Assets[0].Version);
}
// ════════════════════════════════════════════════════════════
// HasUpdate — max server version vs local manifest version
// ════════════════════════════════════════════════════════════
private static DownloadAsset AssetWithType(string name = "a", string version = "2.0.0",
string url = "http://u", long size = 100, string? hash = null,
bool isFreeze = false, bool isForcibly = false,
int packageType = (int)PackageType.Chain,
string? minClientVersion = null, int? appType = null)
=> new(name, url, size, hash, version,
IsFreeze: isFreeze, IsForcibly: isForcibly,
PackageType: packageType, MinClientVersion: minClientVersion, AppType: appType);
[Fact]
public void HasUpdate_EmptyAssets_ReturnsFalse()
{
var assets = Array.Empty<DownloadAsset>();
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "1.0.0"));
}
[Fact]
public void HasUpdate_ServerMaxGreaterThanLocal_ReturnsTrue()
{
var assets = new[]
{
AssetWithType("v1", "1.5.0", appType: (int)AppType.Client),
AssetWithType("v2", "2.0.0", appType: (int)AppType.Client),
};
Assert.True(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "1.0.0"));
}
[Fact]
public void HasUpdate_ServerMaxEqualToLocal_ReturnsFalse()
{
var assets = new[]
{
AssetWithType("v1", "1.0.0", appType: (int)AppType.Client),
AssetWithType("v2", "2.0.0", appType: (int)AppType.Client),
};
// max is 2.0.0, local is 2.0.0 → not greater
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "2.0.0"));
}
[Fact]
public void HasUpdate_ServerMaxLessThanLocal_ReturnsFalse()
{
var assets = new[]
{
AssetWithType("v1", "1.0.0", appType: (int)AppType.Client),
};
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "3.0.0"));
}
[Fact]
public void HasUpdate_NoAssetsForAppType_ReturnsFalse()
{
var assets = new[]
{
AssetWithType("v1", "2.0.0", appType: (int)AppType.Client),
};
// No Upgrade assets at all
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Upgrade, "1.0.0"));
}
[Fact]
public void HasUpdate_AllAssetsFrozen_ReturnsFalse()
{
var assets = new[]
{
AssetWithType("frozen", "2.0.0", appType: (int)AppType.Client, isFreeze: true),
};
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "1.0.0"));
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
[InlineData("invalid")]
public void HasUpdate_UnreadableLocalVersion_ReturnsTrue(string? localVersion)
{
// When local version can't be determined, err on the side of updating.
var assets = new[]
{
AssetWithType("v1", "2.0.0", appType: (int)AppType.Client),
};
Assert.True(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, localVersion));
}
[Fact]
public void HasUpdate_UnreadableLocalVersion_NoServerAssets_ReturnsFalse()
{
// Can't read local version AND server has no matching assets → no update
var assets = new[]
{
AssetWithType("v1", "2.0.0", appType: (int)AppType.Upgrade),
};
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, null));
}
[Fact]
public void HasUpdate_ClientAndUpgradeIndependent()
{
var assets = new[]
{
AssetWithType("client", "2.0.0", appType: (int)AppType.Client),
AssetWithType("upgrade", "1.5.0", appType: (int)AppType.Upgrade),
};
// Client: 2.0.0 > 1.0.0 → true
Assert.True(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "1.0.0"));
// Upgrade: 1.5.0 > 2.0.0 → false (local upgrade is newer)
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Upgrade, "2.0.0"));
}
[Fact]
public void HasUpdate_NullAppType_TreatedAsClient()
{
var assets = new[]
{
AssetWithType("v1", "2.0.0", appType: null), // null → treated as Client
};
Assert.True(DownloadPlanBuilder.HasUpdate(assets, AppType.Client, "1.0.0"));
// Null AppType is not treated as Upgrade
Assert.False(DownloadPlanBuilder.HasUpdate(assets, AppType.Upgrade, "1.0.0"));
}
// ════════════════════════════════════════════════════════════
// Build — AppType-aware dual-version overload
// ════════════════════════════════════════════════════════════
[Fact]
public void Build_DualVersion_ClientNewer_OnlyClientIncluded()
{
var assets = new[]
{
AssetWithType("c", "2.0.0", appType: (int)AppType.Client),
AssetWithType("u", "2.0.0", appType: (int)AppType.Upgrade),
};
// ClientVersion=1.0.0, UpgradeClientVersion=2.0.0 → only Client asset passes
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "2.0.0");
Assert.True(result.HasAssets);
Assert.Single(result.Assets);
Assert.Equal((int)AppType.Client, result.Assets[0].AppType);
}
[Fact]
public void Build_DualVersion_BothNewer_BothIncluded()
{
var assets = new[]
{
AssetWithType("c", "2.0.0", appType: (int)AppType.Client),
AssetWithType("u", "1.5.0", appType: (int)AppType.Upgrade),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "1.0.0");
Assert.Equal(2, result.Assets.Count);
}
[Fact]
public void Build_DualVersion_BothSameAsLocal_ReturnsEmpty()
{
var assets = new[]
{
AssetWithType("c", "1.0.0", appType: (int)AppType.Client),
AssetWithType("u", "1.0.0", appType: (int)AppType.Upgrade),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "1.0.0");
Assert.False(result.HasAssets);
}
[Fact]
public void Build_DualVersion_NullUpgradeClient_FallsBackToClient()
{
var assets = new[]
{
AssetWithType("u", "1.5.0", appType: (int)AppType.Upgrade),
};
// upgradeClientVersion=null → falls back to clientVersion=1.0.0
// 1.5.0 > 1.0.0 → passes
var result = DownloadPlanBuilder.Build(assets, "1.0.0", null);
Assert.True(result.HasAssets);
Assert.Equal("1.5.0", result.Assets[0].Version);
}
[Fact]
public void Build_DualVersion_MinClientVersionFiltered()
{
var assets = new[]
{
AssetWithType("ok", "2.0.0", appType: (int)AppType.Client, minClientVersion: "1.0.0"),
AssetWithType("too-high", "3.0.0", appType: (int)AppType.Client, minClientVersion: "3.0.0"),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0", "1.0.0");
Assert.Single(result.Assets);
Assert.Equal("2.0.0", result.Assets[0].Version);
}
[Fact]
public void Build_SingleVersionOverload_BackwardCompat()
{
var assets = new[]
{
Asset("a", "2.0.0"),
Asset("b", "1.0.0"),
};
var result = DownloadPlanBuilder.Build(assets, "1.0.0");
Assert.Single(result.Assets);
Assert.Equal("2.0.0", result.Assets[0].Version);
}
}