fix: Copilot review — Hub startup, macOS detection, binary compat, cleanup

- HubDownloadSource: call StartAsync() on injection, dispose in finally
- GetPlatform(): add OSPlatform.OSX -> PlatformType.MacOS in both locations
- VersionService.Validate: keep int overload for backward binary compat
- ClientUpdateStrategy: DownloadSource resolved from extension registry + comment fix
- SharedMemoryProvider: catch broader exceptions on Linux (non-Windows MMF)
- CI: document ConfiginfoBuilderTests exclusion rationale

Author: JusterZhu

.github/workflows/ci.yml

@@ -29,6 +29,8 @@ jobs:
 
       - name: Test (Windows)
         if: runner.os == 'Windows'
+        # ConfiginfoBuilderTests excluded: pre-existing regression (tracked in issue tracker),
+        # does not block CI signal for the changes in this PR.
         run: dotnet test ./src/c#/GeneralUpdate.slnx -c Release --no-build --filter "FullyQualifiedName!~ConfiginfoBuilderTests"
 
       - name: Test (Ubuntu - cross-platform)

src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs

@@ -94,14 +94,25 @@ private async Task<GeneralUpdateBootstrap> LaunchWithStrategy(IStrategy roleStra
             {
                 clientStrat.Hooks = hooks;
                 clientStrat.Reporter = reporter;
-                // Inject SignalR Hub download source if configured
-                var hubConfig = GetOption(UpdateOptions.Hub);
-                if (hubConfig != null && !string.IsNullOrEmpty(hubConfig.Url))
+                // Resolve DownloadSource from extension registry (Hub, custom, etc.)
+                var resolvedSource = ResolveExtension<Download.Abstractions.IDownloadSource>();
+
+                // Inject SignalR Hub download source if configured (not available in AOT)
+#if !AOT
+                if (resolvedSource == null)
                 {
-                    clientStrat.DownloadSource = new Download.Sources.HubDownloadSource(
-                        hubConfig.Url, GetOption(UpdateOptions.Token), GetOption(UpdateOptions.AppSecretKey));
-                    GeneralTracer.Info("GeneralUpdateBootstrap: HubDownloadSource injected from HubConfig.");
+                    var hubConfig = GetOption(UpdateOptions.Hub);
+                    if (hubConfig != null && !string.IsNullOrEmpty(hubConfig.Url))
+                    {
+                        var hubSource = new Download.Sources.HubDownloadSource(
+                            hubConfig.Url, GetOption(UpdateOptions.Token), GetOption(UpdateOptions.AppSecretKey));
+                        await hubSource.StartAsync().ConfigureAwait(false);
+                        resolvedSource = hubSource;
+                        GeneralTracer.Info("GeneralUpdateBootstrap: HubDownloadSource started from HubConfig.");
+                    }
                 }
+#endif
+                clientStrat.DownloadSource = resolvedSource;
                 if (_updatePrecheck != null)
                     clientStrat.UseUpdatePrecheck(_updatePrecheck);
                 foreach (var opt in _customOptions)
@@ -129,6 +140,9 @@ private async Task<GeneralUpdateBootstrap> LaunchWithStrategy(IStrategy roleStra
         }
         finally
         {
+            // Dispose HubDownloadSource if it was started
+            if (roleStrategy is ClientUpdateStrategy cs && cs.DownloadSource is IDisposable d)
+                d.Dispose();
             _cts?.Dispose();
             _cts = null;
         }

src/c#/GeneralUpdate.Core/Ipc/IProcessInfoProvider.cs

@@ -139,6 +139,16 @@ public Task SendAsync(ProcessInfo info, CancellationToken token = default)
         {
             return Task.FromResult<ProcessInfo?>(null);
         }
+        catch (DirectoryNotFoundException)
+        {
+            return Task.FromResult<ProcessInfo?>(null);
+        }
+        catch (Exception ex) when (ex is not OutOfMemoryException)
+        {
+            // Platform-specific failures (e.g. Linux /dev/shm not mounted)
+            GeneralTracer.Warn($"SharedMemoryProvider: receive failed: {ex.Message}");
+            return Task.FromResult<ProcessInfo?>(null);
+        }
     }
 }
 

src/c#/GeneralUpdate.Core/Network/VersionService.cs

@@ -54,6 +54,7 @@ public static Task Report(string url, int recordId, int status, int? type,
             return new VersionService(a).ReportAsync(url, recordId, status, type, ct);
         }
 
+        // Strongly-typed overload (preferred)
         public static Task<VersionRespDTO> Validate(string url, string version,
             AppType appType, string appKey, PlatformType platform, string productId,
             string scheme = null, string token = null, CancellationToken ct = default)
@@ -62,6 +63,12 @@ public static Task<VersionRespDTO> Validate(string url, string version,
             return new VersionService(a).ValidateAsync(url, version, (int)appType, (int)platform, productId, ct);
         }
 
+        // Backward-compatible int overload (binary compat for existing callers)
+        public static Task<VersionRespDTO> Validate(string url, string version,
+            int appType, string appKey, int platform, string productId,
+            string scheme = null, string token = null, CancellationToken ct = default)
+            => Validate(url, version, (AppType)appType, appKey, (PlatformType)platform, productId, scheme, token, ct);
+
         private async Task ReportAsync(string url, int recordId, int status, int? type, CancellationToken t = default)
         {
             var p = new Dictionary<string, object> { ["RecordId"] = recordId, ["Status"] = status, ["Type"] = type };

src/c#/GeneralUpdate.Core/Silent/SilentPollOrchestrator.cs

@@ -199,6 +199,7 @@ private static PlatformType GetPlatform()
     {
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) return PlatformType.Windows;
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) return PlatformType.Linux;
+        if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) return PlatformType.MacOS;
         return PlatformType.Unknown;
     }
 

src/c#/GeneralUpdate.Core/Strategy/ClientUpdateStrategy.cs

@@ -38,7 +38,7 @@ public class ClientUpdateStrategy : IStrategy
     public Hooks.IUpdateHooks Hooks { get; set; } = new Hooks.NoOpUpdateHooks();
     /// <summary>Update status reporter injected by the bootstrap.</summary>
     public Download.Reporting.IUpdateReporter Reporter { get; set; } = new Download.Reporting.NoOpUpdateReporter();
-    /// <summary>Download source (e.g., HTTP, SignalR Hub). Override via <c>.DownloadSource&lt;T&gt;()</c>.</summary>
+    /// <summary>Download source (e.g., HTTP, SignalR Hub). Injected by bootstrap via HubConfig or extension registry (<c>.DownloadSource&lt;T&gt;()</c>).</summary>
     public Download.Abstractions.IDownloadSource? DownloadSource { get; set; }
 
     public ClientUpdateStrategy(Download.Abstractions.IDownloadOrchestrator? orchestrator = null) { _orchestrator = orchestrator; }
@@ -276,6 +276,7 @@ private static PlatformType GetPlatform()
     {
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) return PlatformType.Windows;
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) return PlatformType.Linux;
+        if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) return PlatformType.MacOS;
         return PlatformType.Unknown;
     }