fix: resolve 14 code-review issues across Core/Differential/Bowl/Drivelution/Extension (#513)

* fix: resolve 14 code-review issues across Core/Differential/Bowl/Drivelution/Extension

## Bug fixes

- **Brotli patch detection**: add BrotliFormatVersion (0x02) to format detection
  and decompression switch in BsdiffDiffer (#512)
- **ReadFileWithBudget**: trim buffer to actual bytes read to prevent zero-padded
  data corrupting patch computation (#512)
- **BsdiffDiffer.Search**: guard against sentinel -1 values from Split() that
  would cause IndexOutOfRangeException (#512)
- **Bowl EnsureDirectory**: stop deleting the fail directory on every Prepare()
  call — preserves crash diagnostics from prior sessions (#512)
- **FileNode.Equals**: return false for incompatible types instead of throwing
  ArgumentException, conforming to the IEquatable contract (#512)
- **EventManager.Dispatch**: snapshot the delegate invocation list before
  enumerating to avoid race with concurrent AddListener/RemoveListener (#512)
- **DiffPipeline**: add 'using' to both SemaphoreSlim instances to fix kernel
  handle leaks (#512)
- **FileTree.Compare**: guard all 'node0' access paths with null-conditional
  operators to prevent NullReferenceException (#512)
- **ClientStrategy.CheckFail**: use Version.TryParse instead of bare
  new Version() to avoid crashing on malformed version strings (#512)
- **GeneralTracer**: wrap InitializeFileListener with lock to prevent duplicate
  TextTraceListener creation on concurrent day-rollover (#512)
- **ProcessRunner**: cancel the Task.Delay timer via CancellationTokenSource
  when the process exits first, preventing timer leak (#512)
- **OssStrategy**: resolve upgrade app name and search pattern based on
  RuntimeInformation.IsOSPlatform instead of hardcoding .exe (#512)
- **VersionComparer**: use long instead of int for major/minor/patch to
  prevent overflow on extremely large version numbers (#512)
- **ExtensionGeneralHost**: move name extraction before lifecycle hook calls
  and use extensionName (not file path) as Id in ExtensionMetadata (#512)

## Test coverage

- BsdiffDifferTests: 6 new edge-case tests (single-byte, two-byte, repeating
  patterns, single-byte-change round-trips)
- VersionComparerTests: 3 new large-number overflow tests
- FileTreeTests: 6 new tests for null node0, imbalanced trees, matching trees
- FileNodeTests: update Equals_NonFileNodeType test to match new behaviour

All 1864 tests pass across 5 test suites (0 failures).

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: address 5 Copilot review suggestions

1. BsdiffDiffer: recognize Brotli marker (0x02) as extended-header format
   even on netstandard2.0 (fail-fast) instead of mis-detecting as legacy BZip2
2. VersionComparer.ParseVersion: use TryParseNumeric with overflow guard
   instead of bare long.Parse (can throw on > Int64 values)
3. VersionComparer.ComparePrerelease: add IsNumericString fallback for
   purely-numeric identifiers that exceed long.MaxValue (length+ordinal)
4. OssStrategy: limit diagnostic file listing to 20 entries to prevent
   unbounded log noise on non-Windows
5. VersionComparerTests: fix doc comment (long.MaxValue -> int.MaxValue)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: JusterZhu

src/c#/GeneralUpdate.Bowl/Strategies/LinuxBowlStrategy.cs

@@ -275,8 +275,10 @@ private static string DetectDistro()
 
     private static void EnsureDirectory(string path)
     {
-        if (Directory.Exists(path))
-            Directory.Delete(path, recursive: true);
-        Directory.CreateDirectory(path);
+        // Create the fail directory if it does not yet exist.
+        // Do NOT delete an existing directory — that would destroy
+        // crash diagnostics from previous surveillance sessions.
+        if (!Directory.Exists(path))
+            Directory.CreateDirectory(path);
     }
 }

src/c#/GeneralUpdate.Bowl/Strategies/ProcessRunner.cs

@@ -28,6 +28,7 @@ public static async Task<ProcessExitResult> RunAsync(
         var outputLines = new List<string>();
 
         using var process = new Process { StartInfo = startInfo };
+        using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(ct);
         var tcs = new TaskCompletionSource<int>(TaskCreationOptions.RunContinuationsAsynchronously);
 
         process.OutputDataReceived += (_, e) =>
@@ -61,14 +62,17 @@ public static async Task<ProcessExitResult> RunAsync(
         process.BeginOutputReadLine();
         process.BeginErrorReadLine();
 
-        // Wait for exit or timeout/cancellation
-        var completedTask = await Task.WhenAny(
-            tcs.Task,
-            Task.Delay(timeoutMs, ct)
-        );
+        // Wait for exit or timeout/cancellation.
+        // Cancel the delay when the process exits first to avoid a timer leak.
+        var delayTask = Task.Delay(timeoutMs, timeoutCts.Token);
+        var completedTask = await Task.WhenAny(tcs.Task, delayTask);
+
+        // Cancel the opposing task so timers/resources are reclaimed promptly.
+        timeoutCts.Cancel();
 
         if (completedTask == tcs.Task)
         {
+            try { await delayTask; } catch (OperationCanceledException) { /* cancelled — expected */ }
             var exitCode = await tcs.Task;
             GeneralTracer.Info($"ProcessRunner.RunAsync: process exited, ExitCode={exitCode}");
             // Snapshot output under lock to avoid race with in-flight handlers

src/c#/GeneralUpdate.Bowl/Strategies/WindowsBowlStrategy.cs

@@ -63,8 +63,10 @@ public Task PostProcessAsync(in BowlContext context,
 
     private static void EnsureDirectory(string path)
     {
-        if (Directory.Exists(path))
-            StorageHelper.DeleteDirectory(path);
-        Directory.CreateDirectory(path);
+        // Create the fail directory if it does not yet exist.
+        // Do NOT delete an existing directory — that would destroy
+        // crash diagnostics from previous surveillance sessions.
+        if (!Directory.Exists(path))
+            Directory.CreateDirectory(path);
     }
 }

src/c#/GeneralUpdate.Core/Event/EventManager.cs

@@ -119,9 +119,15 @@ public void Dispatch<TEventArgs>(object sender, TEventArgs eventArgs) where TEve
             var type = typeof(Action<object, TEventArgs>);
             if (_dicDelegates.TryGetValue(type, out var existingDelegate))
             {
+                // Snapshot the delegate invocation list to avoid a race with
+                // concurrent AddListener / RemoveListener mutating the delegate
+                // while we enumerate it. The ConcurrentDictionary protects the
+                // dictionary structure but not the Delegate value itself.
+                var invocationList = existingDelegate.GetInvocationList();
+
                 // Invoke each handler individually so one handler's exception
                 // doesn't prevent others from being called.
-                foreach (var handler in existingDelegate.GetInvocationList())
+                foreach (var handler in invocationList)
                 {
                     try
                     {

src/c#/GeneralUpdate.Core/FileSystem/FileNode.cs

@@ -232,8 +232,7 @@ public FileNode SearchParent(long id)
     public override bool Equals(object obj)
     {
         if (obj == null) return false;
-        var tempNode = obj as FileNode;
-        if (tempNode == null) throw new ArgumentException(nameof(tempNode));
+        if (obj is not FileNode tempNode) return false;
         return string.Equals(Hash, tempNode.Hash, StringComparison.OrdinalIgnoreCase) &&
                string.Equals(Name, tempNode.Name, StringComparison.OrdinalIgnoreCase);
     }

src/c#/GeneralUpdate.Core/FileSystem/FileTree.cs

@@ -209,23 +209,23 @@ public void Compare(FileNode node, FileNode node0, ref List<FileNode> nodes)
             if (node != null && node.Left != null)
             {
                 if (!node.Equals(node0) && node0 != null) nodes.Add(node0);
-                Compare(node.Left, node0.Left, ref nodes);
+                Compare(node.Left, node0?.Left, ref nodes);
             }
             else if (node0 != null && node0.Left != null)
             {
                 nodes.Add(node0);
-                Compare(node.Left, node0.Left, ref nodes);
+                Compare(node?.Left, node0.Left, ref nodes);
             }
 
             if (node != null && node.Right != null)
             {
                 if (!node.Equals(node0) && node0 != null) nodes.Add(node0);
-                Compare(node.Right, node0 == null ? null : node0.Right, ref nodes);
+                Compare(node.Right, node0?.Right, ref nodes);
             }
             else if (node0 != null && node0.Right != null)
             {
                 nodes.Add(node0);
-                Compare(node == null ? null : node.Right, node0.Right, ref nodes);
+                Compare(node?.Right, node0.Right, ref nodes);
             }
             else if (node0 != null)
             {

src/c#/GeneralUpdate.Core/Pipeline/DiffPipeline.cs

@@ -222,7 +222,7 @@ public async Task CleanAsync(
         }
 
         int completed = 0;
-        var semaphore = new SemaphoreSlim(_options.MaxDegreeOfParallelism);
+        using var semaphore = new SemaphoreSlim(_options.MaxDegreeOfParallelism);
 
         var tasks = differentFiles.Select(file => Task.Run(async () =>
         {
@@ -342,7 +342,7 @@ public async Task DirtyAsync(
         }
 
         int completed = 0;
-        var semaphore = new SemaphoreSlim(_options.MaxDegreeOfParallelism);
+        using var semaphore = new SemaphoreSlim(_options.MaxDegreeOfParallelism);
 
         var matchedPairs = new List<(FileInfo OldFile, FileInfo PatchFile)>();
         foreach (var oldFile in oldFiles)

src/c#/GeneralUpdate.Core/Strategy/ClientStrategy.cs

@@ -903,7 +903,10 @@ private bool CheckFail(string version)
         var fail = Environments.GetEnvironmentVariable("UpgradeFail");
         if (string.IsNullOrEmpty(fail) || string.IsNullOrEmpty(version))
             return false;
-        return new Version(fail) >= new Version(version);
+        if (!Version.TryParse(fail, out var failVersion) ||
+            !Version.TryParse(version, out var versionParsed))
+            return false;
+        return failVersion >= versionParsed;
     }
 
     /// <summary>

src/c#/GeneralUpdate.Core/Strategy/OssStrategy.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
+using System.Runtime.InteropServices;
 using System.Text;
 using System.Text.Json;
 using System.Threading.Tasks;
@@ -258,15 +259,25 @@ private async Task ExecuteClientAsync()
             : installPath;
         var upgradeAppName = !string.IsNullOrWhiteSpace(_configInfo.UpdateAppName)
             ? _configInfo.UpdateAppName
-            : "GeneralUpdate.Upgrade.exe";
+            : RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
+                ? "GeneralUpdate.Upgrade.exe"
+                : "GeneralUpdate.Upgrade";
         var appPath = Path.Combine(upgradeDir, upgradeAppName);
         GeneralTracer.Info($"[OssClient] Resolved upgrade path: {appPath}");
 
-        // List exe files in the directory to help diagnose missing file issues
+        // List executables in the directory to help diagnose missing file issues
         try
         {
-            var dirFiles = Directory.GetFiles(upgradeDir, "*.exe").Select(f => Path.GetFileName(f));
-            GeneralTracer.Info($"[OssClient] *.exe files in {upgradeDir}: [{string.Join(", ", dirFiles)}]");
+            var searchPattern = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "*.exe" : "*";
+            const int maxDisplay = 20;
+            var dirFiles = Directory.EnumerateFiles(upgradeDir, searchPattern)
+                .Take(maxDisplay + 1)
+                .Select(f => Path.GetFileName(f))
+                .ToList();
+            var summary = dirFiles.Count > maxDisplay
+                ? $"[{string.Join(", ", dirFiles.Take(maxDisplay))}, ... and {dirFiles.Count - maxDisplay} more]"
+                : $"[{string.Join(", ", dirFiles)}]";
+            GeneralTracer.Info($"[OssClient] Files in {upgradeDir}: {summary}");
         }
         catch (Exception ex)
         {

src/c#/GeneralUpdate.Core/Tracer/GeneralTracer.cs

@@ -34,27 +34,30 @@ static GeneralTracer()
 
     private static void InitializeFileListener()
     {
-        //Ensure that log files are rotated on a daily basis
-        var today = DateTime.Now.ToString("yyyy-MM-dd");
-        if (today == _currentLogDate && _fileListener != null)
-            return;
-
-        if (_fileListener != null)
+        lock (_lockObj)
         {
-            Trace.Listeners.Remove(_fileListener);
-            _fileListener.Flush();
-            _fileListener.Close();
-            _fileListener.Dispose();
-        }
+            // Ensure that log files are rotated on a daily basis
+            var today = DateTime.Now.ToString("yyyy-MM-dd");
+            if (today == _currentLogDate && _fileListener != null)
+                return;
 
-        var logDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Logs");
-        Directory.CreateDirectory(logDir);
+            if (_fileListener != null)
+            {
+                Trace.Listeners.Remove(_fileListener);
+                _fileListener.Flush();
+                _fileListener.Close();
+                _fileListener.Dispose();
+            }
+
+            var logDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Logs");
+            Directory.CreateDirectory(logDir);
 
-        var logFileName = Path.Combine(logDir, $"generalupdate-trace {today}.log");
-        _fileListener = new TextTraceListener(logFileName);
-            
-        Trace.Listeners.Add(_fileListener);
-        _currentLogDate = today;
+            var logFileName = Path.Combine(logDir, $"generalupdate-trace {today}.log");
+            _fileListener = new TextTraceListener(logFileName);
+
+            Trace.Listeners.Add(_fileListener);
+            _currentLogDate = today;
+        }
     }
 
     public static void Debug(string message) => WriteTraceMessage(TraceLevel.Verbose, message);