Commit 3851056
refactor: remove UpgradeMode pass-through field from Core (#509)
* feat: simplify ClientTest/UpgradeTest for chain and cross-version integration testing
- Replace OSS/deprecated silent mode with a single mode-agnostic ClientTest entry point
- Remove CLI argument branching (chain/cross-version); the SDK's DownloadPlanBuilder
selects CVP vs chain automatically based on server response (IsCrossVersion + FromVersion)
- Fix MSBuild CopyUpgradeTest target: stop excluding *.json so UpgradeTest.runtimeconfig.json
is bundled as Update.exe, fixing 'hostpolicy.dll not found' launch error
- Improve events logging (IsCrossVersion/AppType/FromVersion display in OnUpdateInfo)
- Update UpgradeTest with clearer IPC flow documentation
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: address Copilot review feedback
- Replace hard-coded '%TEMP%/...' IPC path with Path.GetTempPath() at runtime
- Use OS-agnostic wording for strategy comments (WindowsStrategy → OS strategy)
- Use switch expression for AppType display to handle null/unknown values
* refactor: remove UpgradeMode field and related logic from Core
UpgradeMode was only a pass-through field in GeneralUpdate.Core with no
consuming logic. The server-side UpgradeService now always uses the
unified response flow (CVP first + chain fallback) instead of three-way
branching on UpgradeMode.
Changes:
- Remove UpgradeMode property from VersionEntry, DownloadAsset
- Remove UpgradeMode mapping in HttpDownloadSource and ClientStrategy
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent ae8eb95 commit 3851056
4 files changed
Lines changed: 0 additions & 21 deletions
File tree
- src/c#/GeneralUpdate.Core
- Configuration
- Download
- Models
- Sources
- Strategy
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | 167 | | |
186 | 168 | | |
187 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
182 | 181 | | |
183 | 182 | | |
184 | 183 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
497 | 497 | | |
498 | 498 | | |
499 | 499 | | |
500 | | - | |
501 | 500 | | |
502 | 501 | | |
503 | 502 | | |
| |||
0 commit comments