Merge pull request #488 from GeneralLibrary/fix/ssl-policy-and-httpclient-lifecycle

fix: SSL policy not covering file downloads + HttpClient lifecycle issues

Author: JusterZhu

src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs

@@ -153,7 +153,11 @@ private async Task<GeneralUpdateBootstrap> LaunchWithStrategy(IStrategy roleStra
 
             // ── Network-level extensions (global, applied before any HTTP call) ──
             var sslPolicy = ResolveExtension<Security.ISslValidationPolicy>();
-            if (sslPolicy != null) Network.VersionService.SetSslValidationPolicy(sslPolicy);
+            if (sslPolicy != null)
+            {
+                Network.VersionService.SetSslValidationPolicy(sslPolicy);
+                Network.HttpClientProvider.SetSslValidationPolicy(sslPolicy);
+            }
             var authProvider = ResolveExtension<Security.IHttpAuthProvider>();
             if (authProvider != null) Network.VersionService.SetDefaultAuthProvider(authProvider);
 
@@ -403,7 +407,11 @@ private async Task<GeneralUpdateBootstrap> LaunchSilentAsync()
 
         // Network-level extensions (global, applied before any HTTP call)
         var sslPolicy = ResolveExtension<Security.ISslValidationPolicy>();
-        if (sslPolicy != null) Network.VersionService.SetSslValidationPolicy(sslPolicy);
+        if (sslPolicy != null)
+        {
+            Network.VersionService.SetSslValidationPolicy(sslPolicy);
+            Network.HttpClientProvider.SetSslValidationPolicy(sslPolicy);
+        }
         var authProvider = ResolveExtension<Security.IHttpAuthProvider>();
         if (authProvider != null) Network.VersionService.SetDefaultAuthProvider(authProvider);
 

src/c#/GeneralUpdate.Core/Network/HttpClientProvider.cs

@@ -1,15 +1,65 @@
+using System;
 using System.Net.Http;
+using System.Net.Security;
+using System.Security.Cryptography.X509Certificates;
+using GeneralUpdate.Core.Security;
 
 namespace GeneralUpdate.Core.Network;
 
 /// <summary>
-/// Provides a shared static <see cref="HttpClient"/> instance.
+/// Provides a shared static <see cref="HttpClient"/> instance with configurable SSL validation.
 /// Reusing a single HttpClient prevents socket exhaustion.
 /// Do NOT dispose clients obtained from here.
 /// </summary>
+/// <remarks>
+/// <para>
+/// SSL certificate validation behaviour is controlled by the
+/// <see cref="SetSslValidationPolicy"/> method. The default policy is
+/// <see cref="StrictSslValidationPolicy"/> (rejects any certificate with SSL errors).
+/// </para>
+/// <para>
+/// This class mirrors the SSL validation pattern used by <see cref="VersionService"/>,
+/// ensuring that both API calls and file downloads respect the same global SSL policy.
+/// </para>
+/// </remarks>
 public static class HttpClientProvider
 {
-    private static readonly HttpClient _shared = new();
+    private static ISslValidationPolicy _sslPolicy = new StrictSslValidationPolicy();
+    private static readonly HttpClient _shared;
+
+    static HttpClientProvider()
+    {
+        var handler = new HttpClientHandler();
+        handler.ServerCertificateCustomValidationCallback = (req, cert, chain, errors) =>
+            _sslPolicy.ValidateCertificate(cert, chain, errors);
+        _shared = new HttpClient(handler, disposeHandler: false)
+        {
+            // Let per-request CancellationTokenSource.CancelAfter (set by
+            // HttpDownloadExecutor & VersionService) control timeout — the
+            // global HttpClient.Timeout (default ~100s) would otherwise cap
+            // requests before a caller-configured longer DownloadTimeout.
+            Timeout = System.Threading.Timeout.InfiniteTimeSpan
+        };
+    }
+
+    /// <summary>
+    /// Sets the global SSL certificate validation policy for all download requests.
+    /// </summary>
+    /// <param name="policy">The SSL validation policy instance. Must not be null.</param>
+    /// <exception cref="ArgumentNullException">Thrown when <paramref name="policy"/> is null.</exception>
+    /// <remarks>
+    /// <para>
+    /// This policy affects all HTTPS download requests made through
+    /// <see cref="HttpDownloadExecutor"/> and other components that use the shared
+    /// <see cref="HttpClient"/>. The default is <see cref="StrictSslValidationPolicy"/>.
+    /// </para>
+    /// <para>
+    /// The validation callback delegates to the stored policy instance, so the policy
+    /// can be changed at any time — new requests will use the updated policy.
+    /// </para>
+    /// </remarks>
+    public static void SetSslValidationPolicy(ISslValidationPolicy policy)
+        => _sslPolicy = policy ?? throw new ArgumentNullException(nameof(policy));
 
     /// <summary>
     /// Gets the shared <see cref="HttpClient"/> instance. Do NOT dispose.

src/c#/GeneralUpdate.Core/Strategy/OssStrategy.cs

@@ -3,7 +3,6 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
-using System.Net.Http;
 using System.Text;
 using System.Text.Json;
 using System.Threading.Tasks;
@@ -462,8 +461,7 @@ private static async Task DownloadVersionConfig(string url, string path)
             File.SetAttributes(path, FileAttributes.Normal);
             File.Delete(path);
         }
-        using var httpClient = GeneralUpdate.Core.Network.HttpClientProvider.Shared;
-        var bytes = await httpClient.GetByteArrayAsync(url).ConfigureAwait(false);
+        var bytes = await Network.HttpClientProvider.Shared.GetByteArrayAsync(url).ConfigureAwait(false);
         File.WriteAllBytes(path, bytes);
     }
 
@@ -506,11 +504,13 @@ private async Task DownloadAssetsAsync(List<DownloadAsset> assets, string target
         }
         else
         {
-            using var httpClient = new HttpClient
+            var options = new DownloadOrchestratorOptions
             {
-                Timeout = TimeSpan.FromSeconds(_configInfo?.DownloadTimeOut > 0 ? _configInfo!.DownloadTimeOut : DefaultTimeOut)
+                DownloadTimeout = TimeSpan.FromSeconds(
+                    _configInfo?.DownloadTimeOut > 0 ? _configInfo!.DownloadTimeOut : DefaultTimeOut)
             };
-            var orchestrator = new DefaultDownloadOrchestrator(httpClient);
+            var orchestrator = new DefaultDownloadOrchestrator(
+                Network.HttpClientProvider.Shared, options);
             await orchestrator.ExecuteAsync(plan, targetPath).ConfigureAwait(false);
         }
     }