Skip to content

Commit 4b50eb5

Browse files
committed
fix: update ParameterMatrixAndEventTests for relaxed Validate()
1 parent 0735936 commit 4b50eb5

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

tests/CoreTest/Bootstrap/ParameterMatrixAndEventTests.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,9 @@ public void Configinfo_Validate_MissingUpdateUrl_Throws()
190190
}
191191

192192
[Fact]
193-
public void Configinfo_Validate_MissingMainAppName_Throws()
193+
public void Configinfo_Validate_MissingMainAppName_DoesNotThrow()
194194
{
195+
// MainAppName is optional — filled from manifest by strategies.
195196
var config = new UpdateRequest
196197
{
197198
UpdateUrl = "https://api.example.com",
@@ -200,12 +201,14 @@ public void Configinfo_Validate_MissingMainAppName_Throws()
200201
MainAppName = null!
201202
};
202203

203-
Assert.Throws<ArgumentException>(() => config.Validate());
204+
var ex = Record.Exception(() => config.Validate());
205+
Assert.Null(ex);
204206
}
205207

206208
[Fact]
207-
public void Configinfo_Validate_MissingClientVersion_Throws()
209+
public void Configinfo_Validate_MissingClientVersion_DoesNotThrow()
208210
{
211+
// ClientVersion is optional — filled from manifest by strategies.
209212
var config = new UpdateRequest
210213
{
211214
UpdateUrl = "https://api.example.com",
@@ -214,7 +217,8 @@ public void Configinfo_Validate_MissingClientVersion_Throws()
214217
ClientVersion = null!
215218
};
216219

217-
Assert.Throws<ArgumentException>(() => config.Validate());
220+
var ex = Record.Exception(() => config.Validate());
221+
Assert.Null(ex);
218222
}
219223

220224
[Theory]

0 commit comments

Comments
 (0)