Add ServerUrl to ExtensionHostConfig and update service to use it for downloads

Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>

Author: Copilot

src/c#/ExtensionTest/Services/ExtensionServiceTests.cs

@@ -81,7 +81,7 @@ private List<AvailableExtension> CreateTestExtensions()
         private ExtensionService CreateExtensionService(List<AvailableExtension> extensions)
         {
             var updateQueue = new GeneralUpdate.Extension.Download.UpdateQueue();
-            return new ExtensionService(extensions, "/tmp/test-downloads", updateQueue);
+            return new ExtensionService(extensions, "/tmp/test-downloads", updateQueue, "https://test-server.com/api/extensions");
         }
 
         [Fact]

src/c#/GeneralUpdate.Extension/Examples/ExtensionSystemExample.cs

@@ -21,6 +21,7 @@ public void Initialize()
             var hostVersion = new Version(1, 5, 0);
             var installPath = @"C:\MyApp\Extensions";
             var downloadPath = @"C:\MyApp\Temp\Downloads";
+            var serverUrl = "https://your-server.com/api/extensions";
 
             // Detect current platform
             var currentPlatform = DetectCurrentPlatform();
@@ -31,6 +32,7 @@ public void Initialize()
                 HostVersion = hostVersion,
                 InstallBasePath = installPath,
                 DownloadPath = downloadPath,
+                ServerUrl = serverUrl,
                 TargetPlatform = currentPlatform,
                 DownloadTimeout = 300 // 5 minutes
             };

src/c#/GeneralUpdate.Extension/ExtensionHostConfig.cs

@@ -26,6 +26,13 @@ public class ExtensionHostConfig
         /// </summary>
         public string DownloadPath { get; set; } = null!;
 
+        /// <summary>
+        /// Gets or sets the server URL for extension queries and downloads.
+        /// This is the base URL used to construct Query and Download endpoints.
+        /// Example: "https://your-server.com/api/extensions"
+        /// </summary>
+        public string ServerUrl { get; set; } = null!;
+
         /// <summary>
         /// Gets or sets the target platform (Windows/Linux/macOS).
         /// Defaults to Windows if not specified.
@@ -62,6 +69,8 @@ public void Validate()
                 throw new ArgumentNullException(nameof(InstallBasePath));
             if (string.IsNullOrWhiteSpace(DownloadPath))
                 throw new ArgumentNullException(nameof(DownloadPath));
+            if (string.IsNullOrWhiteSpace(ServerUrl))
+                throw new ArgumentNullException(nameof(ServerUrl));
         }
     }
 }

src/c#/GeneralUpdate.Extension/GeneralExtensionHost.cs

@@ -109,6 +109,7 @@ public GeneralExtensionHost(ExtensionHostConfig config)
                 new List<Metadata.AvailableExtension>(),
                 config.DownloadPath,
                 _updateQueue,
+                config.ServerUrl,
                 config.HostVersion,
                 _validator,
                 config.DownloadTimeout,
@@ -130,6 +131,7 @@ public GeneralExtensionHost(ExtensionHostConfig config)
         /// <param name="hostVersion">The current host application version.</param>
         /// <param name="installBasePath">Base directory for extension installations.</param>
         /// <param name="downloadPath">Directory for downloading extension packages.</param>
+        /// <param name="serverUrl">Server base URL for extension queries and downloads.</param>
         /// <param name="targetPlatform">The current platform (Windows/Linux/macOS).</param>
         /// <param name="downloadTimeout">Download timeout in seconds (default: 300).</param>
         /// <param name="authScheme">Optional HTTP authentication scheme (e.g., "Bearer", "Basic").</param>
@@ -140,6 +142,7 @@ public GeneralExtensionHost(
             Version hostVersion,
             string installBasePath,
             string downloadPath,
+            string serverUrl,
             Metadata.TargetPlatform targetPlatform = Metadata.TargetPlatform.Windows,
             int downloadTimeout = 300,
             string? authScheme = null,
@@ -149,6 +152,7 @@ public GeneralExtensionHost(
                 HostVersion = hostVersion,
                 InstallBasePath = installBasePath,
                 DownloadPath = downloadPath,
+                ServerUrl = serverUrl,
                 TargetPlatform = targetPlatform,
                 DownloadTimeout = downloadTimeout,
                 AuthScheme = authScheme,

src/c#/GeneralUpdate.Extension/README.md

@@ -34,12 +34,17 @@ Note: This library is currently distributed as source. A NuGet package may be av
 using GeneralUpdate.Extension;
 using GeneralUpdate.Extension.Metadata;
 
-// Create extension host
-var host = new ExtensionHost(
-    hostVersion: new Version(1, 0, 0),
-    installPath: @"C:\MyApp\Extensions",
-    downloadPath: @"C:\MyApp\Downloads",
-    targetPlatform: TargetPlatform.Windows);
+// Create extension host with configuration
+var config = new ExtensionHostConfig
+{
+    HostVersion = new Version(1, 0, 0),
+    InstallBasePath = @"C:\MyApp\Extensions",
+    DownloadPath = @"C:\MyApp\Downloads",
+    ServerUrl = "https://your-server.com/api/extensions",
+    TargetPlatform = TargetPlatform.Windows
+};
+
+var host = new GeneralExtensionHost(config);
 
 // Load installed extensions
 host.LoadInstalledExtensions();
@@ -70,25 +75,29 @@ public class YourModule : IModule
 {
     public void RegisterTypes(IContainerRegistry containerRegistry)
     {
-        var hostVersion = new Version(1, 0, 0);
-        var installPath = @"C:\MyApp\Extensions";
-        var downloadPath = @"C:\MyApp\Downloads";
-        var platform = Metadata.TargetPlatform.Windows;
+        var config = new ExtensionHostConfig
+        {
+            HostVersion = new Version(1, 0, 0),
+            InstallBasePath = @"C:\MyApp\Extensions",
+            DownloadPath = @"C:\MyApp\Downloads",
+            ServerUrl = "https://your-server.com/api/extensions",
+            TargetPlatform = Metadata.TargetPlatform.Windows
+        };
 
         // Register as singletons
         containerRegistry.RegisterSingleton<Core.IExtensionCatalog>(() => 
-            new Core.ExtensionCatalog(installPath));
+            new Core.ExtensionCatalog(config.InstallBasePath));
 
         containerRegistry.RegisterSingleton<Compatibility.ICompatibilityValidator>(() => 
-            new Compatibility.CompatibilityValidator(hostVersion));
+            new Compatibility.CompatibilityValidator(config.HostVersion));
 
         containerRegistry.RegisterSingleton<Download.IUpdateQueue, Download.UpdateQueue>();
 
         containerRegistry.RegisterSingleton<PackageGeneration.IExtensionPackageGenerator, 
             PackageGeneration.ExtensionPackageGenerator>();
 
         containerRegistry.RegisterSingleton<IExtensionHost>(() => 
-            new ExtensionHost(hostVersion, installPath, downloadPath, platform));
+            new GeneralExtensionHost(config));
     }
 }
 
@@ -102,24 +111,28 @@ var host = container.Resolve<IExtensionHost>();
 using Microsoft.Extensions.DependencyInjection;
 
 var services = new ServiceCollection();
-var hostVersion = new Version(1, 0, 0);
-var installPath = @"C:\Extensions";
-var downloadPath = @"C:\Downloads";
+var config = new ExtensionHostConfig
+{
+    HostVersion = new Version(1, 0, 0),
+    InstallBasePath = @"C:\Extensions",
+    DownloadPath = @"C:\Downloads",
+    ServerUrl = "https://your-server.com/api/extensions",
+    TargetPlatform = Metadata.TargetPlatform.Windows
+};
 
 services.AddSingleton<Core.IExtensionCatalog>(sp => 
-    new Core.ExtensionCatalog(installPath));
+    new Core.ExtensionCatalog(config.InstallBasePath));
 
 services.AddSingleton<Compatibility.ICompatibilityValidator>(sp => 
-    new Compatibility.CompatibilityValidator(hostVersion));
+    new Compatibility.CompatibilityValidator(config.HostVersion));
 
 services.AddSingleton<Download.IUpdateQueue, Download.UpdateQueue>();
 
 services.AddSingleton<PackageGeneration.IExtensionPackageGenerator, 
     PackageGeneration.ExtensionPackageGenerator>();
 
 services.AddSingleton<IExtensionHost>(sp => 
-    new ExtensionHost(hostVersion, installPath, downloadPath, 
-        Metadata.TargetPlatform.Windows));
+    new GeneralExtensionHost(config));
 
 var provider = services.BuildServiceProvider();
 var host = provider.GetRequiredService<IExtensionHost>();
@@ -128,11 +141,16 @@ var host = provider.GetRequiredService<IExtensionHost>();
 #### Without DI (Direct Instantiation)
 
 ```csharp
-var host = new ExtensionHost(
-    new Version(1, 0, 0),
-    @"C:\Extensions",
-    @"C:\Downloads",
-    Metadata.TargetPlatform.Windows);
+var config = new ExtensionHostConfig
+{
+    HostVersion = new Version(1, 0, 0),
+    InstallBasePath = @"C:\Extensions",
+    DownloadPath = @"C:\Downloads",
+    ServerUrl = "https://your-server.com/api/extensions",
+    TargetPlatform = Metadata.TargetPlatform.Windows
+};
+
+var host = new GeneralExtensionHost(config);
 ```
 
 ### 2. Loading and Managing Extensions

src/c#/GeneralUpdate.Extension/Services/ExtensionService.cs

@@ -25,6 +25,7 @@ public class ExtensionService : IExtensionService
         private readonly Download.IUpdateQueue _updateQueue;
         private readonly string? _authScheme;
         private readonly string? _authToken;
+        private readonly string _serverUrl;
 
         /// <summary>
         /// Occurs when download progress updates during package retrieval.
@@ -47,6 +48,7 @@ public class ExtensionService : IExtensionService
         /// <param name="availableExtensions">List of available extensions</param>
         /// <param name="downloadPath">Directory path where extension packages will be downloaded</param>
         /// <param name="updateQueue">The update queue for managing operation state</param>
+        /// <param name="serverUrl">Server base URL for extension queries and downloads</param>
         /// <param name="hostVersion">Optional host version for compatibility checking</param>
         /// <param name="validator">Optional compatibility validator</param>
         /// <param name="downloadTimeout">Timeout in seconds for download operations (default: 300)</param>
@@ -56,6 +58,7 @@ public ExtensionService(
             List<AvailableExtension> availableExtensions,
             string downloadPath,
             Download.IUpdateQueue updateQueue,
+            string serverUrl,
             Version? hostVersion = null,
             Compatibility.ICompatibilityValidator? validator = null,
             int downloadTimeout = 300,
@@ -67,7 +70,11 @@ public ExtensionService(
             if (string.IsNullOrWhiteSpace(downloadPath))
                 throw new ArgumentNullException(nameof(downloadPath));
 
+            if (string.IsNullOrWhiteSpace(serverUrl))
+                throw new ArgumentNullException(nameof(serverUrl));
+            
             _downloadPath = downloadPath;
+            _serverUrl = serverUrl.TrimEnd('/'); // Remove trailing slash for consistent URL construction
             _updateQueue = updateQueue ?? throw new ArgumentNullException(nameof(updateQueue));
             _downloadTimeout = downloadTimeout;
             _hostVersion = hostVersion;
@@ -302,18 +309,14 @@ public async Task<HttpResponseDTO<DownloadExtensionDTO>> Download(string id)
 
             var descriptor = operation.Extension.Descriptor;
 
-            if (string.IsNullOrWhiteSpace(descriptor.DownloadUrl))
-            {
-                _updateQueue.ChangeState(operation.OperationId, GeneralUpdate.Extension.Download.UpdateState.UpdateFailed, "Download URL is missing");
-                OnDownloadFailed(descriptor.Name, descriptor.DisplayName);
-                return null;
-            }
+            // Construct download URL from server URL and extension ID
+            var downloadUrl = $"{_serverUrl}/Download/{descriptor.Name}";
 
             try
             {
                 _updateQueue.ChangeState(operation.OperationId, GeneralUpdate.Extension.Download.UpdateState.Updating);
 
-                // Determine file format from URL or default to .zip
+                // Determine file format from descriptor or default to .zip
                 var format = !string.IsNullOrWhiteSpace(descriptor.DownloadUrl) && descriptor.DownloadUrl!.Contains(".")
                     ? Path.GetExtension(descriptor.DownloadUrl)
                     : ".zip";
@@ -322,7 +325,7 @@ public async Task<HttpResponseDTO<DownloadExtensionDTO>> Download(string id)
                 var versionInfo = new VersionInfo
                 {
                     Name = $"{descriptor.Name}_{descriptor.Version}",
-                    Url = descriptor.DownloadUrl,
+                    Url = downloadUrl,
                     Hash = descriptor.PackageHash,
                     Version = descriptor.Version,
                     Size = descriptor.PackageSize,