refactor: make SilentPollOrchestrator delegate to ClientStrategy instead of reimplementing update logic

The silent update flow was a completely separate reimplementation of the
standard ClientStrategy workflow, leading to three critical bugs:

1. DiffPipeline was never injected into the strategy, causing PatchMiddleware
   to throw InvalidOperationException on every poll cycle (infinite retry loop)
2. OnProcessExit unconditionally launched the upgrade process even when only
   Upgrade packages were applied (unnecessary app restart)
3. Download orchestrator was created without DownloadOrchestratorOptions,
   ignoring user-configured timeout, concurrency, retry, and checksum settings

Solution:
- ClientStrategy: add LaunchAfterPrepare flag (default true) and
  HasPreparedClientUpdate property
- GeneralUpdateBootstrap: extract ConfigureStrategy() shared by standard
  and silent paths, ensuring identical extension injection
- SilentPollOrchestrator: rewritten from ~600 to ~175 lines; now a thin
  scheduling layer that delegates all update work to ClientStrategy
- UpdateOptions: add LaunchClientAfterUpdate option for silent mode

Files changed: 5 | +208 -596

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: JusterZhu

src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs

@@ -135,76 +135,10 @@ private async Task<GeneralUpdateBootstrap> LaunchWithStrategy(IStrategy roleStra
             var authProvider = ResolveExtension<Security.IHttpAuthProvider>();
             if (authProvider != null) Network.VersionService.SetDefaultAuthProvider(authProvider);
 
-            // Resolve hooks from extensions
-            var hooks = ResolveExtension<Hooks.IUpdateHooks>() ?? new Hooks.NoOpUpdateHooks();
-            roleStrategy.Hooks = hooks;
+            ConfigureStrategy(roleStrategy);
 
-            // Resolve reporter from extensions; default to HttpUpdateReporter.
-            // When ReportUrl is not configured, HttpUpdateReporter is effectively a no-op.
-            var reporter = ResolveExtension<Download.Reporting.IUpdateReporter>() ??
-                           new Download.Reporting.HttpUpdateReporter();
-
-            if (reporter is Download.Reporting.HttpUpdateReporter httpReporter)
-                httpReporter.ReportUrl = _configInfo.ReportUrl;
-
-            roleStrategy.Reporter = reporter;
-
-            // ── Download components ──
-            var downloadOrchestrator = ResolveExtension<Download.Abstractions.IDownloadOrchestrator>();
-            var downloadPolicy = ResolveExtension<Download.Abstractions.IDownloadPolicy>();
-            var downloadExecutor = ResolveExtension<Download.Abstractions.IDownloadExecutor>();
-
-            // Build download pipeline factory from registered extension type
-            Func<string?, Download.Abstractions.IDownloadPipeline>? downloadPipelineFactory = null;
-            var pipelineType = ResolveExtensionType<Download.Abstractions.IDownloadPipeline>();
-            if (pipelineType != null)
-            {
-                var stringCtor = pipelineType.GetConstructor([typeof(string)]);
-                if (stringCtor != null)
-                    downloadPipelineFactory = hash => (Download.Abstractions.IDownloadPipeline)stringCtor.Invoke([hash]);
-                else
-                    downloadPipelineFactory = _ => (Download.Abstractions.IDownloadPipeline)Activator.CreateInstance(pipelineType);
-            }
-
-            var diffPipeline = BuildDiffPipeline();
-
-            switch (roleStrategy)
-            {
-                case ClientStrategy cs:
-                    cs.DownloadSource = ResolveExtension<Download.Abstractions.IDownloadSource>();
-
-                    if (_updatePrecheck != null)
-                        cs.UseUpdatePrecheck(_updatePrecheck);
-
-                    await CallSmallBowlHomeAsync(_configInfo.Bowl).ConfigureAwait(false);
-
-                    cs.SetDiffPipeline(diffPipeline);
-                    if (downloadOrchestrator != null) cs.SetOrchestrator(downloadOrchestrator);
-                    if (downloadPolicy != null) cs.SetDownloadPolicy(downloadPolicy);
-                    if (downloadExecutor != null) cs.SetDownloadExecutor(downloadExecutor);
-                    if (downloadPipelineFactory != null) cs.SetDownloadPipelineFactory(downloadPipelineFactory);
-                    break;
-
-                case UpdateStrategy us:
-                    us.SetDiffPipeline(diffPipeline);
-                    us.SetReportType(_configInfo.ReportType);
-                    break;
-            }
-
-            // Inject custom OS-level strategy if registered via Strategy<T>()
-            var customOsStrategy = ResolveExtension<IStrategy>();
-            if (customOsStrategy != null)
-            {
-                switch (roleStrategy)
-                {
-                    case ClientStrategy cs:
-                        cs.SetOsStrategy(customOsStrategy);
-                        break;
-                    case UpdateStrategy us:
-                        us.SetOsStrategy(customOsStrategy);
-                        break;
-                }
-            }
+            if (roleStrategy is ClientStrategy cs)
+                await CallSmallBowlHomeAsync(_configInfo.Bowl).ConfigureAwait(false);
 
             roleStrategy.Create(_configInfo);
 
@@ -420,34 +354,103 @@ private void ApplyRuntimeOptions()
 
     /// <summary>
     /// Silent update mode — starts a background poll loop and returns immediately.
-    /// The orchestrator checks for updates periodically and prepares them.
-    /// When the host process exits, the prepared update is applied.
+    /// Uses the same fully-configured <see cref="ClientStrategy"/> as the standard flow;
+    /// the orchestrator only adds polling and deferred-upgrade-on-exit on top.
     /// </summary>
-    private async Task LaunchSilentAsync()
+    private async Task<GeneralUpdateBootstrap> LaunchSilentAsync()
     {
         GeneralTracer.Info("GeneralUpdateBootstrap: starting silent update mode.");
+
+        ApplyRuntimeOptions();
+
+        // Network-level extensions (global, applied before any HTTP call)
+        var sslPolicy = ResolveExtension<Security.ISslValidationPolicy>();
+        if (sslPolicy != null) Network.VersionService.SetSslValidationPolicy(sslPolicy);
+        var authProvider = ResolveExtension<Security.IHttpAuthProvider>();
+        if (authProvider != null) Network.VersionService.SetDefaultAuthProvider(authProvider);
+
+        var strategy = new ClientStrategy();
+        ConfigureStrategy(strategy);
+
+        strategy.LaunchAfterPrepare = false;
+
         var pollMinutes = GetOption(UpdateOptions.SilentPollIntervalMinutes);
+        var launchClient = GetOption(UpdateOptions.LaunchClientAfterUpdate);
         var silentOptions = new Silent.SilentOptions
         {
-            PollInterval = TimeSpan.FromMinutes(pollMinutes)
+            PollInterval = TimeSpan.FromMinutes(pollMinutes),
+            LaunchClientAfterUpdate = launchClient
         };
+
+        var orchestrator = new Silent.SilentPollOrchestrator(strategy, _configInfo, silentOptions);
+        await orchestrator.StartAsync().ConfigureAwait(false);
+        GeneralTracer.Info("GeneralUpdateBootstrap: silent update mode started, returning to caller.");
+
+        return this;
+    }
+
+    /// <summary>
+    /// Applies all registered extensions (hooks, reporter, download components,
+    /// DiffPipeline, custom OS strategy) to a role strategy. Shared by the standard
+    /// and silent boot paths so they are always configured identically.
+    /// </summary>
+    private void ConfigureStrategy(IStrategy roleStrategy)
+    {
         var hooks = ResolveExtension<Hooks.IUpdateHooks>() ?? new Hooks.NoOpUpdateHooks();
+        roleStrategy.Hooks = hooks;
+
         var reporter = ResolveExtension<Download.Reporting.IUpdateReporter>() ??
                        new Download.Reporting.HttpUpdateReporter();
-        if (reporter is Download.Reporting.HttpUpdateReporter httpRep)
-            httpRep.ReportUrl = _configInfo.ReportUrl;
-        var sslPolicy = ResolveExtension<Security.ISslValidationPolicy>();
-        if (sslPolicy != null) Network.VersionService.SetSslValidationPolicy(sslPolicy);
-        var authProvider = ResolveExtension<Security.IHttpAuthProvider>();
-        if (authProvider != null) Network.VersionService.SetDefaultAuthProvider(authProvider);
+        if (reporter is Download.Reporting.HttpUpdateReporter httpReporter)
+            httpReporter.ReportUrl = _configInfo.ReportUrl;
+        roleStrategy.Reporter = reporter;
 
-        var orchestrator = new Silent.SilentPollOrchestrator(_configInfo, silentOptions)
-            .WithHooks(hooks)
-            .WithReporter(reporter)
-            .WithOsStrategy(ResolveExtension<IStrategy>());
+        var diffPipeline = BuildDiffPipeline();
 
-        await orchestrator.StartAsync().ConfigureAwait(false);
-        GeneralTracer.Info("GeneralUpdateBootstrap: silent update mode started, returning to caller.");
+        // Download components
+        var downloadOrchestrator = ResolveExtension<Download.Abstractions.IDownloadOrchestrator>();
+        var downloadPolicy = ResolveExtension<Download.Abstractions.IDownloadPolicy>();
+        var downloadExecutor = ResolveExtension<Download.Abstractions.IDownloadExecutor>();
+
+        Func<string?, Download.Abstractions.IDownloadPipeline>? downloadPipelineFactory = null;
+        var pipelineType = ResolveExtensionType<Download.Abstractions.IDownloadPipeline>();
+        if (pipelineType != null)
+        {
+            var stringCtor = pipelineType.GetConstructor([typeof(string)]);
+            if (stringCtor != null)
+                downloadPipelineFactory = hash => (Download.Abstractions.IDownloadPipeline)stringCtor.Invoke([hash]);
+            else
+                downloadPipelineFactory = _ => (Download.Abstractions.IDownloadPipeline)Activator.CreateInstance(pipelineType);
+        }
+
+        switch (roleStrategy)
+        {
+            case ClientStrategy cs:
+                cs.DownloadSource = ResolveExtension<Download.Abstractions.IDownloadSource>();
+                cs.SetDiffPipeline(diffPipeline);
+                if (downloadOrchestrator != null) cs.SetOrchestrator(downloadOrchestrator);
+                if (downloadPolicy != null) cs.SetDownloadPolicy(downloadPolicy);
+                if (downloadExecutor != null) cs.SetDownloadExecutor(downloadExecutor);
+                if (downloadPipelineFactory != null) cs.SetDownloadPipelineFactory(downloadPipelineFactory);
+                if (_updatePrecheck != null) cs.UseUpdatePrecheck(_updatePrecheck);
+                break;
+
+            case UpdateStrategy us:
+                us.SetDiffPipeline(diffPipeline);
+                us.SetReportType(_configInfo.ReportType);
+                break;
+        }
+
+        // Custom OS-level strategy (registered via Strategy<T>())
+        var customOsStrategy = ResolveExtension<IStrategy>();
+        if (customOsStrategy != null)
+        {
+            switch (roleStrategy)
+            {
+                case ClientStrategy cs: cs.SetOsStrategy(customOsStrategy); break;
+                case UpdateStrategy us: us.SetOsStrategy(customOsStrategy); break;
+            }
+        }
     }
 
     private DiffPipeline BuildDiffPipeline()

src/c#/GeneralUpdate.Core/Configuration/UpdateOptions.cs

@@ -113,6 +113,12 @@ public static class UpdateOptions
         /// </summary>
         public static UpdateOption<int> SilentPollIntervalMinutes { get; } = UpdateOption.ValueOf<int>("SILENTPOLLINTERVALMINUTES", 60);
 
+        /// <summary>
+        ///     Whether to automatically launch the client application after the upgrade process completes in silent mode.
+        ///     Defaults to <c>true</c>.
+        /// </summary>
+        public static UpdateOption<bool> LaunchClientAfterUpdate { get; } = UpdateOption.ValueOf<bool>("LAUNCHCLIENTAFTERUPDATE", true);
+
         // ════════════════════════════════════════
         //  Concurrency and Resume Options
         // ════════════════════════════════════════