fix: address PR review — parameter order and Discover() scope

1. Fix SetSource parameter order: updateUrl first, appSecretKey second
   (was swapped by earlier linter edit, causing confusion with docs).

2. Move AppMetadataDiscoverer.Discover() from SetConfig() into SetSource().
   SetConfig is for explicit user-provided config — manifest must not
   override user values. SetSource is the zero-config path where manifest
   fills identity gaps.

3. Align ClientTest call site to new parameter order.

Author: JusterZhu

src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs

@@ -214,18 +214,16 @@ private async Task<GeneralUpdateBootstrap> LaunchWithStrategy(IStrategy roleStra
     }
 
     /// <summary>
-    /// Applies the primary configuration object. Missing identity fields are
-    /// auto-discovered from <c>generalupdate.manifest.json</c> or defaults.
-    /// Validates required fields, maps to the internal <see cref="GlobalConfigInfo"/>,
-    /// and initialises the blacklist matcher for file exclusion during update operations.
+    /// Applies the primary configuration object. Validates required fields, maps to
+    /// the internal <see cref="GlobalConfigInfo"/>, and initialises the blacklist
+    /// matcher for file exclusion during update operations.
     /// </summary>
-    /// <param name="configInfo">User-facing configuration. Secrets (<c>UpdateUrl</c>,
-    /// <c>AppSecretKey</c>, <c>Token</c>) must be set. Identity fields are auto-filled
-    /// when omitted.</param>
+    /// <param name="configInfo">User-facing configuration. All required fields must
+    /// be set explicitly — no auto-discovery is performed. Use
+    /// <see cref="SetSource"/> for the zero-config path.</param>
     /// <returns>This bootstrap instance for chaining.</returns>
     public GeneralUpdateBootstrap SetConfig(Configinfo configInfo)
     {
-        configInfo = AppMetadataDiscoverer.Discover(configInfo);
         configInfo.Validate();
         _configInfo = ConfigurationMapper.MapToGlobalConfigInfo(configInfo);
 
@@ -280,25 +278,27 @@ public GeneralUpdateBootstrap SetConfig(string filePath)
     }
 
     /// <summary>
-    ///     Minimal entry-point: supply only secrets. Identity metadata is auto-discovered
+    ///     Zero-config entry-point: supply only secrets. Identity metadata is auto-discovered
     ///     from <c>generalupdate.manifest.json</c> and hard-coded defaults.
     /// </summary>
     /// <returns>This bootstrap instance for chaining.</returns>
     public GeneralUpdateBootstrap SetSource(
-        string appSecretKey,
         string updateUrl,
-        string? reportUrl = null,
+        string appSecretKey,
         string? token = null,
-        string? scheme = null)
+        string? scheme = null,
+        string? reportUrl = null)
     {
-        return SetConfig(new Configinfo
+        var config = new Configinfo
         {
             UpdateUrl = updateUrl,
             AppSecretKey = appSecretKey,
             Token = token,
             Scheme = scheme,
             ReportUrl = reportUrl
-        });
+        };
+        config = AppMetadataDiscoverer.Discover(config);
+        return SetConfig(config);
     }
 
     /// <summary>

tests/ClientTest/Program.cs

@@ -20,9 +20,8 @@
 
     // Identity metadata (MainAppName, ClientVersion, UpdateAppName, UpdatePath, …)
     // is auto-discovered from generalupdate.manifest.json (generated by GeneralUpdate.Tools).
-    // SetSource params: (appSecretKey, updateUrl, reportUrl?, token?, scheme?)
     await new GeneralUpdateBootstrap()
-        .SetSource(appSecretKey, updateUrl, reportUrl)
+        .SetSource(updateUrl, appSecretKey, reportUrl: reportUrl)
         .Option(UpdateOptions.AppType, AppType.Client)
         .Hooks<ClientTestHooks>()
         .AddListenerMultiDownloadStatistics(OnDownloadStatistics)