Commit 94c7a72
fix: delegate upgrade process launch to ClientStrategy in silent mode
OnProcessExit was manually resolving the updater path and calling
Process.Start, bypassing the configured OS strategy. This meant:
- Custom strategies registered via Strategy<T>() were ignored for path
resolution
- The OnBeforeStartAppAsync lifecycle hook (e.g. UnixPermissionHooks for
chmod +x) was never invoked in silent mode
Solution:
- AbstractStrategy: add internal StartProcess() that reuses ResolveAppPath
- ClientStrategy: add LaunchUpgradeProcessSync() that runs the pre-launch
hook and delegates path resolution + process start to the OS strategy
- SilentPollOrchestrator: OnProcessExit now calls the strategy instead of
hand-rolling path logic
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 14e88b2 commit 94c7a72
3 files changed
Lines changed: 69 additions & 18 deletions
File tree
- src/c#/GeneralUpdate.Core
- Silent
- Strategy
Lines changed: 5 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | 2 | | |
5 | 3 | | |
6 | 4 | | |
| |||
142 | 140 | | |
143 | 141 | | |
144 | 142 | | |
145 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 162 | + | |
| 163 | + | |
177 | 164 | | |
178 | 165 | | |
179 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
322 | 323 | | |
323 | 324 | | |
324 | 325 | | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
325 | 343 | | |
326 | 344 | | |
327 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
674 | 674 | | |
675 | 675 | | |
676 | 676 | | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
677 | 723 | | |
678 | 724 | | |
679 | 725 | | |
| |||
0 commit comments