Skip to content

Commit a6c573b

Browse files
JusterZhuJusterZhu
authored
Merge pull request #428 from GeneralLibrary/feature/core-unit-tests-round3
test: Round 3 — 50 tests for Download orchestrator, HttpDownloadExecutor, VersionService, SilentPollOrchestrator (closes #427)
2 parents 97c374e + be1a5ec commit a6c573b

4 files changed

Lines changed: 466 additions & 0 deletions

File tree

‎tests/CoreTest/Download/DefaultDownloadOrchestratorTests.cs‎

Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
using GeneralUpdate.Core.Configuration;
2+
using GeneralUpdate.Core.Download.Models;
3+
using GeneralUpdate.Core.Download.Orchestrators;
4+
using GeneralUpdate.Core.Download.Policy;
5+
6+
namespace CoreTest.Download;
7+
8+
public class DefaultDownloadOrchestratorTests
9+
{
10+
[Fact]
11+
public void Ctor_HttpClientNull_ThrowsArgumentNullException()
12+
{
13+
Assert.Throws<ArgumentNullException>(() =>
14+
new DefaultDownloadOrchestrator(null));
15+
}
16+
17+
[Fact]
18+
public void Ctor_WithValidClient_CreatesInstance()
19+
{
20+
var client = new HttpClient();
21+
var orchestrator = new DefaultDownloadOrchestrator(client);
22+
Assert.NotNull(orchestrator);
23+
}
24+
25+
[Fact]
26+
public void Ctor_WithCustomOptions_UsesProvidedOptions()
27+
{
28+
var client = new HttpClient();
29+
var options = new DownloadOrchestratorOptions
30+
{
31+
MaxConcurrency = 2,
32+
EnableResume = false,
33+
RetryCount = 1,
34+
VerifyChecksum = false,
35+
DiffMode = DiffMode.Serial
36+
};
37+
var orchestrator = new DefaultDownloadOrchestrator(client, options);
38+
Assert.NotNull(orchestrator);
39+
}
40+
41+
[Fact]
42+
public void Ctor_WithCustomPolicy_UsesProvidedPolicy()
43+
{
44+
var client = new HttpClient();
45+
var policy = new DefaultRetryPolicy(5, TimeSpan.FromSeconds(2));
46+
var orchestrator = new DefaultDownloadOrchestrator(client, null, policy);
47+
Assert.NotNull(orchestrator);
48+
}
49+
50+
[Fact]
51+
public async Task ExecuteAsync_PlanNull_ReturnsEmptyReport()
52+
{
53+
var client = new HttpClient();
54+
var orchestrator = new DefaultDownloadOrchestrator(client);
55+
var dest = Path.Combine(Path.GetTempPath(), $"dl_{Guid.NewGuid():N}");
56+
try
57+
{
58+
var report = await orchestrator.ExecuteAsync(null, dest);
59+
Assert.Equal(0, report.SuccessCount);
60+
Assert.Equal(0, report.FailedCount);
61+
}
62+
finally { if (Directory.Exists(dest)) Directory.Delete(dest, true); }
63+
}
64+
65+
[Fact]
66+
public async Task ExecuteAsync_PlanHasNoAssets_ReturnsEmptyReport()
67+
{
68+
var client = new HttpClient();
69+
var orchestrator = new DefaultDownloadOrchestrator(client);
70+
var plan = new DownloadPlan(Array.Empty<DownloadAsset>(), false);
71+
var dest = Path.Combine(Path.GetTempPath(), $"dl_{Guid.NewGuid():N}");
72+
try
73+
{
74+
var report = await orchestrator.ExecuteAsync(plan, dest);
75+
Assert.Equal(0, report.SuccessCount);
76+
Assert.Equal(0, report.FailedCount);
77+
}
78+
finally { if (Directory.Exists(dest)) Directory.Delete(dest, true); }
79+
}
80+
81+
[Fact]
82+
public async Task ExecuteAsync_DestinationDirectoryCreated()
83+
{
84+
var client = new HttpClient();
85+
var orchestrator = new DefaultDownloadOrchestrator(client);
86+
var plan = new DownloadPlan(
87+
new[] { new DownloadAsset("test", "http://example.com/f", 100, null, "1.0") }, false);
88+
var dest = Path.Combine(Path.GetTempPath(), $"dl_{Guid.NewGuid():N}");
89+
Directory.CreateDirectory(dest);
90+
try
91+
{
92+
var report = await orchestrator.ExecuteAsync(plan, dest);
93+
Assert.NotNull(report);
94+
}
95+
finally { if (Directory.Exists(dest)) Directory.Delete(dest, true); }
96+
}
97+
98+
[Fact]
99+
public async Task ExecuteAsync_GetFileName_ExtractsFromUri()
100+
{
101+
var client = new HttpClient();
102+
var orchestrator = new DefaultDownloadOrchestrator(client);
103+
// Asset with a proper URL should have file name extracted from URI path
104+
var asset = new DownloadAsset("test", "http://example.com/path/to/update.zip", 100, null, "1.0");
105+
Assert.NotNull(asset.Url);
106+
Assert.Contains("update.zip", asset.Url);
107+
}
108+
}

‎tests/CoreTest/Download/HttpDownloadExecutorTests.cs‎

Lines changed: 161 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,161 @@
1+
using System.Net;
2+
using GeneralUpdate.Core.Download.Executors;
3+
using GeneralUpdate.Core.Download.Models;
4+
5+
namespace CoreTest.Download;
6+
7+
public class HttpDownloadExecutorTests
8+
{
9+
// ── Constructor ──
10+
[Fact]
11+
public void Ctor_ClientNull_ThrowsArgumentNullException()
12+
{
13+
Assert.Throws<ArgumentNullException>(() => new HttpDownloadExecutor(null));
14+
}
15+
16+
[Fact]
17+
public void Ctor_DefaultTimeout30Seconds()
18+
{
19+
var client = new HttpClient();
20+
var executor = new HttpDownloadExecutor(client);
21+
Assert.NotNull(executor);
22+
}
23+
24+
[Fact]
25+
public void Ctor_ResumeEnabledByDefault()
26+
{
27+
var client = new HttpClient();
28+
var executor = new HttpDownloadExecutor(client);
29+
Assert.NotNull(executor);
30+
}
31+
32+
[Fact]
33+
public void Ctor_ResumeDisabled()
34+
{
35+
var client = new HttpClient();
36+
var executor = new HttpDownloadExecutor(client, enableResume: false);
37+
Assert.NotNull(executor);
38+
}
39+
40+
[Fact]
41+
public void Ctor_CustomTimeout()
42+
{
43+
var client = new HttpClient();
44+
var executor = new HttpDownloadExecutor(client, TimeSpan.FromSeconds(60));
45+
Assert.NotNull(executor);
46+
}
47+
48+
// ── ExecuteAsync ──
49+
[Fact]
50+
public async Task ExecuteAsync_Success_DownloadsFile()
51+
{
52+
var handler = new MockHttpMessageHandler()
53+
.Returns(HttpStatusCode.OK, "file contents");
54+
var client = new HttpClient(handler);
55+
var executor = new HttpDownloadExecutor(client, enableResume: false);
56+
var asset = new DownloadAsset("test", "http://example.com/file", 12, null, "1.0");
57+
var dest = Path.GetTempFileName();
58+
try
59+
{
60+
var result = await executor.ExecuteAsync(asset, dest);
61+
Assert.True(result.Success);
62+
Assert.True(File.Exists(dest));
63+
}
64+
finally { if (File.Exists(dest)) File.Delete(dest); }
65+
}
66+
67+
[Fact]
68+
public async Task ExecuteAsync_ServerError_ReturnsFailedResult()
69+
{
70+
var handler = new MockHttpMessageHandler()
71+
.Returns(HttpStatusCode.InternalServerError);
72+
var client = new HttpClient(handler);
73+
var executor = new HttpDownloadExecutor(client);
74+
var asset = new DownloadAsset("test", "http://example.com/file", 100, null, "1.0");
75+
var dest = Path.GetTempFileName();
76+
try
77+
{
78+
var result = await executor.ExecuteAsync(asset, dest);
79+
Assert.False(result.Success);
80+
Assert.NotNull(result.ErrorMessage);
81+
}
82+
finally { if (File.Exists(dest)) File.Delete(dest); }
83+
}
84+
85+
[Fact]
86+
public async Task ExecuteAsync_NotFound_ReturnsFailedResult()
87+
{
88+
var handler = new MockHttpMessageHandler()
89+
.Returns(HttpStatusCode.NotFound);
90+
var client = new HttpClient(handler);
91+
var executor = new HttpDownloadExecutor(client);
92+
var asset = new DownloadAsset("test", "http://example.com/missing", 0, null, "1.0");
93+
var dest = Path.GetTempFileName();
94+
try
95+
{
96+
var result = await executor.ExecuteAsync(asset, dest);
97+
Assert.False(result.Success);
98+
}
99+
finally { if (File.Exists(dest)) File.Delete(dest); }
100+
}
101+
102+
[Fact]
103+
public async Task ExecuteAsync_ExistingPartialFileWithResumeEnabled_AppendsToFile()
104+
{
105+
var handler = new MockHttpMessageHandler()
106+
.Returns(HttpStatusCode.PartialContent, "remaining_data");
107+
var client = new HttpClient(handler);
108+
var executor = new HttpDownloadExecutor(client, enableResume: true);
109+
var asset = new DownloadAsset("test", "http://example.com/file", 100, null, "1.0");
110+
var dest = Path.GetTempFileName();
111+
File.WriteAllText(dest, "prefix_"); // Simulate partial download
112+
try
113+
{
114+
var result = await executor.ExecuteAsync(asset, dest);
115+
Assert.True(result.Success);
116+
}
117+
finally { if (File.Exists(dest)) File.Delete(dest); }
118+
}
119+
120+
[Fact]
121+
public async Task ExecuteAsync_ResumeDisabled_ExistingFile_Overwritten()
122+
{
123+
var handler = new MockHttpMessageHandler()
124+
.Returns(HttpStatusCode.OK, "new content");
125+
var client = new HttpClient(handler);
126+
var executor = new HttpDownloadExecutor(client, enableResume: false);
127+
var asset = new DownloadAsset("test", "http://example.com/file", 11, null, "1.0");
128+
var dest = Path.GetTempFileName();
129+
File.WriteAllText(dest, "old content longer");
130+
try
131+
{
132+
var result = await executor.ExecuteAsync(asset, dest);
133+
Assert.True(result.Success);
134+
}
135+
finally { if (File.Exists(dest)) File.Delete(dest); }
136+
}
137+
138+
public class MockHttpMessageHandler : HttpMessageHandler
139+
{
140+
private HttpStatusCode _status = HttpStatusCode.OK;
141+
private string _content = "";
142+
143+
public MockHttpMessageHandler Returns(HttpStatusCode code, string content = "")
144+
{
145+
_status = code;
146+
_content = content;
147+
return this;
148+
}
149+
150+
protected override Task<HttpResponseMessage> SendAsync(
151+
HttpRequestMessage request, CancellationToken ct)
152+
{
153+
var response = new HttpResponseMessage(_status)
154+
{
155+
Content = new StringContent(_content)
156+
};
157+
response.Content.Headers.ContentLength = _content.Length;
158+
return Task.FromResult(response);
159+
}
160+
}
161+
}

‎tests/CoreTest/Network/VersionServiceRetryTests.cs‎

Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
using GeneralUpdate.Core.Network;
2+
3+
namespace CoreTest.Network;
4+
5+
public class VersionServiceRetryTests
6+
{
7+
[Fact]
8+
public void IsRetryable_OperationCanceledException_ReturnsFalse()
9+
{
10+
Assert.False(IsRetryable(new OperationCanceledException("cancel")));
11+
}
12+
13+
[Fact]
14+
public void IsRetryable_TaskCanceledException_ReturnsFalse()
15+
{
16+
// TaskCanceledException inherits from OperationCanceledException,
17+
// which is checked first → not retryable
18+
Assert.False(IsRetryable(new TaskCanceledException("timeout")));
19+
}
20+
21+
[Fact]
22+
public void IsRetryable_TimeoutException_ReturnsTrue()
23+
{
24+
Assert.True(IsRetryable(new TimeoutException("timeout")));
25+
}
26+
27+
[Fact]
28+
public void IsRetryable_IOException_ReturnsTrue()
29+
{
30+
Assert.True(IsRetryable(new IOException("network down")));
31+
}
32+
33+
[Fact]
34+
public void IsRetryable_HttpRequestExceptionWithoutTimeout_ReturnsFalse()
35+
{
36+
Assert.False(IsRetryable(new HttpRequestException("Forbidden 403")));
37+
Assert.False(IsRetryable(new HttpRequestException("Not Found 404")));
38+
Assert.False(IsRetryable(new HttpRequestException("Connection refused")));
39+
}
40+
41+
[Fact]
42+
public void IsRetryable_InvalidOperationException_ReturnsFalse()
43+
{
44+
Assert.False(IsRetryable(new InvalidOperationException("boom")));
45+
}
46+
47+
[Fact]
48+
public void IsRetryable_NullReferenceException_ReturnsFalse()
49+
{
50+
Assert.False(IsRetryable(new NullReferenceException()));
51+
}
52+
53+
[Fact]
54+
public void HttpClientProvider_Shared_ReturnsSameInstance()
55+
{
56+
var client1 = HttpClientProvider.Shared;
57+
var client2 = HttpClientProvider.Shared;
58+
Assert.Same(client1, client2);
59+
}
60+
61+
[Fact]
62+
public void HttpClientProvider_Shared_IsNotNull()
63+
{
64+
Assert.NotNull(HttpClientProvider.Shared);
65+
}
66+
67+
// Matches actual VersionService.IsRetryable logic
68+
private static bool IsRetryable(Exception ex)
69+
{
70+
if (ex is OperationCanceledException) return false;
71+
if (ex is TaskCanceledException or TimeoutException or IOException) return true;
72+
if (ex is HttpRequestException h &&
73+
(h.Message ?? "").Contains("timeout", StringComparison.OrdinalIgnoreCase))
74+
return true;
75+
return false;
76+
}
77+
}

0 commit comments

Comments
 (0)