Merge pull request #452 from GeneralLibrary/fix/async-anti-patterns

fix: eliminate sync-over-async anti-patterns (.GetAwaiter().GetResult())

Author: JusterZhu

src/c#/ExtensionTest/Communication/ExtensionHttpClientTests.cs

@@ -81,7 +81,7 @@ public void 构造函数_ServerUrl末尾斜杠被Trim()
     }
 
     [Fact]
-    public void 构造函数_Scheme和Token非空_设置AuthorizationHeader()
+    public async Task 构造函数_Scheme和Token非空_设置AuthorizationHeader()
     {
         var handler = new Mock<HttpMessageHandler>();
         HttpRequestMessage? capturedRequest = null;
@@ -98,7 +98,7 @@ public void 构造函数_Scheme和Token非空_设置AuthorizationHeader()
         using var httpClient = new HttpClient(handler.Object);
         using var client = new ExtensionHttpClient("http://test", "Bearer", "my-token", httpClient);
 
-        client.QueryExtensionsAsync(new ExtensionQueryDTO()).GetAwaiter().GetResult();
+        await client.QueryExtensionsAsync(new ExtensionQueryDTO());
 
         Assert.NotNull(capturedRequest);
         Assert.NotNull(capturedRequest!.Headers.Authorization);
@@ -107,7 +107,7 @@ public void 构造函数_Scheme和Token非空_设置AuthorizationHeader()
     }
 
     [Fact]
-    public void 构造函数_Scheme为空_不设置Authorization()
+    public async Task 构造函数_Scheme为空_不设置Authorization()
     {
         var handler = new Mock<HttpMessageHandler>();
         HttpRequestMessage? capturedRequest = null;
@@ -123,7 +123,7 @@ public void 构造函数_Scheme为空_不设置Authorization()
 
         using var httpClient = new HttpClient(handler.Object);
         using var client = new ExtensionHttpClient("http://test", "", "", httpClient);
-        client.QueryExtensionsAsync(new ExtensionQueryDTO()).GetAwaiter().GetResult();
+        await client.QueryExtensionsAsync(new ExtensionQueryDTO());
 
         Assert.Null(capturedRequest!.Headers.Authorization);
     }

src/c#/GeneralUpdate.Bowl/Bowl.cs

@@ -280,7 +280,7 @@ public static void Launch(MonitorParameter? monitorParameter = null)
         }
 
         var bowl = new Bowl();
-        bowl.LaunchAsync(context).ConfigureAwait(false).GetAwaiter().GetResult();
+        bowl.LaunchAsync(context).GetAwaiter().GetResult();
     }
 
     /// <summary>

src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs

@@ -174,8 +174,8 @@ private async Task<GeneralUpdateBootstrap> LaunchWithStrategy(IStrategy roleStra
         finally
         {
             // Dispose HubDownloadSource if it was started
-            if (roleStrategy is ClientUpdateStrategy cs && cs.DownloadSource is IDisposable d)
-                d.Dispose();
+            if (roleStrategy is ClientUpdateStrategy cs && cs.DownloadSource is IAsyncDisposable ad)
+                await ad.DisposeAsync();
             _cts?.Dispose();
             _cts = null;
         }

src/c#/GeneralUpdate.Core/Download/Sources/HubDownloadSource.cs

@@ -15,7 +15,7 @@ namespace GeneralUpdate.Core.Download.Sources;
 /// SignalR Hub download source — receives update push notifications
 /// and converts them to DownloadAssets for the orchestrator.
 /// </summary>
-public class HubDownloadSource : IDownloadSource, IDisposable
+public class HubDownloadSource : IDownloadSource, IAsyncDisposable
 {
     private readonly string _hubUrl;
     private readonly string? _token;
@@ -77,8 +77,9 @@ public async Task<IReadOnlyList<DownloadAsset>> ListAsync(CancellationToken toke
         return _assets.ToList();
     }
 
-    public void Dispose()
+    public async ValueTask DisposeAsync()
     {
-        _hub?.DisposeAsync().GetAwaiter().GetResult();
+        if (_hub != null)
+            await _hub.DisposeAsync();
     }
 }

src/c#/GeneralUpdate.Core/Strategy/AbstractStrategy.cs

@@ -34,9 +34,7 @@ public abstract class AbstractStrategy : IStrategy
         /// <summary>DiffPipeline for parallel patch application with progress reporting.</summary>
         public DiffPipeline? DiffPipeline { get; set; }
 
-        public virtual void Execute() => throw new NotImplementedException();
-        
-        public virtual void StartApp() => throw new NotImplementedException();
+        public virtual Task StartAppAsync() => throw new NotImplementedException();
 
         public virtual async Task ExecuteAsync()
         {
@@ -72,7 +70,7 @@ await VersionService.Report(_configinfo.ReportUrl
 
                 Clear(patchPath);
                 Clear(_configinfo.TempPath);
-                OnExecuteComplete();
+                await OnExecuteCompleteAsync();
             }
             catch (Exception e)
             {
@@ -120,9 +118,9 @@ protected virtual PipelineContext CreatePipelineContext(VersionInfo version, str
         /// Called after ExecuteAsync completes successfully.
         /// Override this method to add platform-specific post-execution logic.
         /// </summary>
-        protected virtual void OnExecuteComplete()
+        protected virtual Task OnExecuteCompleteAsync()
         {
-            // Default implementation does nothing
+            return Task.CompletedTask;
         }
 
         /// <summary>

src/c#/GeneralUpdate.Core/Strategy/ClientUpdateStrategy.cs

@@ -73,11 +73,6 @@ public async Task ExecuteAsync()
         }
     }
 
-    public void Execute()
-    {
-        ExecuteAsync().GetAwaiter().GetResult();
-    }
-
     private IDirtyStrategy? _pendingDirtyStrategy;
 
     /// <summary>Sets the directory-level dirty strategy on the underlying OS-level strategy for differential patch updates.
@@ -104,9 +99,10 @@ public void SetDiffPipeline(DiffPipeline? diffPipeline)
             abs.DiffPipeline = diffPipeline;
     }
 
-    public void StartApp()
+    public async Task StartAppAsync()
     {
-        _osStrategy?.StartApp();
+        if (_osStrategy != null)
+            await _osStrategy.StartAppAsync();
     }
 
     /// <summary>Register a precheck callback invoked when update info is available.</summary>

src/c#/GeneralUpdate.Core/Strategy/IStrategy.cs

@@ -11,17 +11,12 @@ public interface IStrategy
         /// <summary>
         /// Execution strategy.
         /// </summary>
-        void Execute();
+        Task ExecuteAsync();
 
         /// <summary>
         /// After the update is complete.
         /// </summary>
-        void StartApp();
-        
-        /// <summary>
-        /// Execution strategy.
-        /// </summary>
-        Task ExecuteAsync();
+        Task StartAppAsync();
 
         /// <summary>
         /// Create a strategy.

src/c#/GeneralUpdate.Core/Strategy/LinuxStrategy.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Diagnostics;
+using System.Threading.Tasks;
 using GeneralUpdate.Core;
 using GeneralUpdate.Core.Configuration;
 using GeneralUpdate.Core.Event;
@@ -26,18 +27,13 @@ protected override PipelineBuilder BuildPipeline(PipelineContext context)
         return builder;
     }
 
-    public override void Execute()
-    {
-        ExecuteAsync().Wait();
-    }
-
-    protected override void OnExecuteComplete()
+    protected override async Task OnExecuteCompleteAsync()
     {
         GeneralTracer.Info("GeneralUpdate.Core.LinuxStrategy.OnExecuteComplete: all versions processed, starting application.");
-        StartApp();
+        await StartAppAsync();
     }
 
-    public override void StartApp()
+    public override async Task StartAppAsync()
     {
         try
         {
@@ -59,7 +55,7 @@ public override void StartApp()
         {
             GeneralTracer.Info("GeneralUpdate.Core.LinuxStrategy.StartApp: releasing tracer and terminating updater process.");
             GeneralTracer.Dispose();
-            GracefulExit.CurrentProcessAsync().GetAwaiter().GetResult();
+            await GracefulExit.CurrentProcessAsync();
         }
     }
 

src/c#/GeneralUpdate.Core/Strategy/MacStrategy.cs

@@ -11,15 +11,13 @@ namespace GeneralUpdate.Core.Strategy;
 /// <summary>macOS update strategy — follows Linux conventions.</summary>
 public class MacStrategy : AbstractStrategy
 {
-    public override void Execute() => ExecuteAsync().GetAwaiter().GetResult();
-
     public override async Task ExecuteAsync()
     {
         GeneralTracer.Info("MacStrategy: executing pipeline");
         await base.ExecuteAsync().ConfigureAwait(false);
     }
 
-    public override void StartApp()
+    public override async Task StartAppAsync()
     {
         try
         {
@@ -42,7 +40,7 @@ public override void StartApp()
         {
             GeneralTracer.Info("MacStrategy.StartApp: releasing tracer and terminating updater process.");
             GeneralTracer.Dispose();
-            GracefulExit.CurrentProcessAsync().GetAwaiter().GetResult();
+            await GracefulExit.CurrentProcessAsync();
         }
     }
 

src/c#/GeneralUpdate.Core/Strategy/OSSUpdateStrategy.cs

@@ -182,7 +182,7 @@ private async Task ExecuteUpgradeAsync()
             await SafeOnBeforeStartAppAsync(ctx).ConfigureAwait(false);
 
             GeneralTracer.Debug("OSSUpdateStrategy (upgrade): launching main app.");
-            StartApp();
+            await StartAppAsync();
         }
         catch (Exception ex)
         {
@@ -197,19 +197,18 @@ private async Task ExecuteUpgradeAsync()
         }
     }
 
-    public void Execute() => ExecuteAsync().GetAwaiter().GetResult();
-
-    public void StartApp()
+    public Task StartAppAsync()
     {
         var appName = _configInfo?.MainAppName ?? _configInfo?.AppName;
-        if (string.IsNullOrEmpty(appName)) return;
+        if (string.IsNullOrEmpty(appName)) return Task.CompletedTask;
 
         var appPath = Path.Combine(_appPath, appName);
         if (!File.Exists(appPath))
             throw new FileNotFoundException($"Application not found: {appPath}");
 
         Process.Start(appPath);
         GeneralTracer.Debug("OSSUpdateStrategy: main application started.");
+        return Task.CompletedTask;
     }
 
     #region Helpers