Skip to content

Commit b49543b

Browse files
committed
refactor: reorder SetSource params — URLs first
SetSource(updateUrl, appSecretKey, reportUrl?, scheme?, token?) Three URL-related params near the front, consumer code uses clean positional args without named parameters.
1 parent 58a1197 commit b49543b

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/c#/GeneralUpdate.Core/Bootstrap/GeneralUpdateBootstrap.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,9 @@ public GeneralUpdateBootstrap SetConfig(string filePath)
285285
public GeneralUpdateBootstrap SetSource(
286286
string updateUrl,
287287
string appSecretKey,
288-
string? token = null,
288+
string? reportUrl = null,
289289
string? scheme = null,
290-
string? reportUrl = null)
290+
string? token = null)
291291
{
292292
var config = new Configinfo
293293
{

tests/ClientTest/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// Identity metadata (MainAppName, ClientVersion, UpdateAppName, UpdatePath, …)
2222
// is auto-discovered from generalupdate.manifest.json (generated by GeneralUpdate.Tools).
2323
await new GeneralUpdateBootstrap()
24-
.SetSource(updateUrl, appSecretKey, reportUrl: reportUrl)
24+
.SetSource(updateUrl, appSecretKey, reportUrl)
2525
.Option(UpdateOptions.AppType, AppType.Client)
2626
.Hooks<ClientTestHooks>()
2727
.AddListenerMultiDownloadStatistics(OnDownloadStatistics)

0 commit comments

Comments
 (0)