Commit c81842d
fix: address 5 Copilot review suggestions
1. BsdiffDiffer: recognize Brotli marker (0x02) as extended-header format
even on netstandard2.0 (fail-fast) instead of mis-detecting as legacy BZip2
2. VersionComparer.ParseVersion: use TryParseNumeric with overflow guard
instead of bare long.Parse (can throw on > Int64 values)
3. VersionComparer.ComparePrerelease: add IsNumericString fallback for
purely-numeric identifiers that exceed long.MaxValue (length+ordinal)
4. OssStrategy: limit diagnostic file listing to 20 entries to prevent
unbounded log noise on non-Windows
5. VersionComparerTests: fix doc comment (long.MaxValue -> int.MaxValue)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent cd54051 commit c81842d
4 files changed
Lines changed: 61 additions & 12 deletions
File tree
- src/c#
- GeneralUpdate.Core/Strategy
- GeneralUpdate.Differential/Differ
- GeneralUpdate.Drivelution/Core/Utilities
- tests/DrivelutionTest/Utilities
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | | - | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
274 | 281 | | |
275 | 282 | | |
276 | 283 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
313 | 312 | | |
314 | | - | |
315 | 313 | | |
316 | 314 | | |
317 | 315 | | |
| |||
444 | 442 | | |
445 | 443 | | |
446 | 444 | | |
447 | | - | |
448 | 445 | | |
449 | | - | |
450 | 446 | | |
451 | 447 | | |
452 | 448 | | |
| |||
Lines changed: 50 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
106 | 113 | | |
107 | 114 | | |
108 | | - | |
109 | | - | |
110 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
111 | 118 | | |
112 | 119 | | |
113 | 120 | | |
114 | 121 | | |
115 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
116 | 135 | | |
117 | 136 | | |
118 | 137 | | |
| |||
122 | 141 | | |
123 | 142 | | |
124 | 143 | | |
125 | | - | |
126 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
127 | 151 | | |
128 | 152 | | |
129 | 153 | | |
130 | 154 | | |
131 | 155 | | |
132 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
133 | 165 | | |
134 | 166 | | |
135 | 167 | | |
| |||
150 | 182 | | |
151 | 183 | | |
152 | 184 | | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
153 | 198 | | |
154 | 199 | | |
155 | 200 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
221 | | - | |
| 221 | + | |
| 222 | + | |
222 | 223 | | |
223 | 224 | | |
224 | 225 | | |
| |||
0 commit comments