Refactor error handling and improve logging

Removed try-catch blocks from several methods to allow exceptions to propagate naturally and centralized error logging. Enhanced download and patching methods with more detailed tracing and logging. Moved GetPacketHash to AbstractBootstrap for reuse. Cleaned up redundant code and improved code clarity in differential update logic.

Author: JusterZhu

src/c#/GeneralUpdate.ClientCore/GeneralClientBootstrap.cs

@@ -250,25 +250,17 @@ private async Task ExecuteWorkflowAsync()
 
     private async Task Download()
     {
-        try
-        {
-            var manager = new DownloadManager(_configInfo.TempPath, _configInfo.Format, _configInfo.DownloadTimeOut);
-            manager.MultiAllDownloadCompleted += OnMultiAllDownloadCompleted;
-            manager.MultiDownloadCompleted += OnMultiDownloadCompleted;
-            manager.MultiDownloadError += OnMultiDownloadError;
-            manager.MultiDownloadStatistics += OnMultiDownloadStatistics;
-            foreach (var versionInfo in _configInfo.UpdateVersions)
-            {
-                manager.Add(new DownloadTask(manager, versionInfo));
-            }
-
-            await manager.LaunchTasksAsync();
-        }
-        catch (Exception exception)
+        var manager = new DownloadManager(_configInfo.TempPath, _configInfo.Format, _configInfo.DownloadTimeOut);
+        manager.MultiAllDownloadCompleted += OnMultiAllDownloadCompleted;
+        manager.MultiDownloadCompleted += OnMultiDownloadCompleted;
+        manager.MultiDownloadError += OnMultiDownloadError;
+        manager.MultiDownloadStatistics += OnMultiDownloadStatistics;
+        foreach (var versionInfo in _configInfo.UpdateVersions)
         {
-            GeneralTracer.Error("The Download method in the GeneralClientBootstrap class throws an exception." , exception);
-            EventManager.Instance.Dispatch(this, new ExceptionEventArgs(exception, exception.Message));
+            manager.Add(new DownloadTask(manager, versionInfo));
         }
+
+        await manager.LaunchTasksAsync();
     }
 
     private int GetPlatform()
@@ -451,8 +443,5 @@ private void OnMultiAllDownloadCompleted(object sender, MultiAllDownloadComplete
         EventManager.Instance.Dispatch(sender, e);
     }
 
-    private string GetPacketHash(object version) => 
-        !GeneralTracer.IsTracingEnabled() ? string.Empty : $"[PacketHash]:{(version as VersionInfo).Hash} ";
-
     #endregion Private Methods
 }

src/c#/GeneralUpdate.ClientCore/GeneralClientOSS.cs

@@ -51,11 +51,10 @@ await Task.Run(() =>
                 Process.Start(appPath);
                 Process.GetCurrentProcess().Kill();
             }
-            catch (Exception ex)
+            catch (Exception exception)
             {
-                var error = ex.Message + "\n" + ex.StackTrace;
-                GeneralTracer.Error(error);
-                throw new Exception(error);
+                GeneralTracer.Error("The BaseStart method in the GeneralClientOSS class throws an exception.", exception);
+                throw exception;
             }
         });
     }

src/c#/GeneralUpdate.Common/Internal/Bootstrap/AbstractBootstrap.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics;
 using System.Threading.Tasks;
 using GeneralUpdate.Common.Internal.Strategy;
+using GeneralUpdate.Common.Shared.Object;
 
 namespace GeneralUpdate.Common.Internal.Bootstrap
 {
@@ -60,5 +61,8 @@ public TBootstrap Option<T>(UpdateOption<T> option, T value)
                 return default;
             }
         }
+        
+        protected string GetPacketHash(object version) => 
+            !GeneralTracer.IsTracingEnabled() ? string.Empty : $"[PacketHash]:{(version as VersionInfo).Hash} ";
     }
 }

src/c#/GeneralUpdate.Core/GeneralUpdateBootstrap.cs

@@ -59,27 +59,19 @@ public GeneralUpdateBootstrap()
 
         public override async Task<GeneralUpdateBootstrap> LaunchAsync()
         {
-            try
+            StrategyFactory();
+            var manager =
+                new DownloadManager(_configInfo.TempPath, _configInfo.Format, _configInfo.DownloadTimeOut);
+            manager.MultiAllDownloadCompleted += OnMultiAllDownloadCompleted;
+            manager.MultiDownloadCompleted += OnMultiDownloadCompleted;
+            manager.MultiDownloadError += OnMultiDownloadError;
+            manager.MultiDownloadStatistics += OnMultiDownloadStatistics;
+            foreach (var versionInfo in _configInfo.UpdateVersions)
             {
-                StrategyFactory();
-                var manager =
-                    new DownloadManager(_configInfo.TempPath, _configInfo.Format, _configInfo.DownloadTimeOut);
-                manager.MultiAllDownloadCompleted += OnMultiAllDownloadCompleted;
-                manager.MultiDownloadCompleted += OnMultiDownloadCompleted;
-                manager.MultiDownloadError += OnMultiDownloadError;
-                manager.MultiDownloadStatistics += OnMultiDownloadStatistics;
-                foreach (var versionInfo in _configInfo.UpdateVersions)
-                {
-                    manager.Add(new DownloadTask(manager, versionInfo));
-                }
-
-                await manager.LaunchTasksAsync();
-            }
-            catch (Exception exception)
-            {
-                GeneralTracer.Error("The LaunchAsync method in the GeneralUpdateBootstrap class throws an exception.", exception);
-                EventManager.Instance.Dispatch(this, new ExceptionEventArgs(exception, exception.Message));
+                manager.Add(new DownloadTask(manager, versionInfo));
             }
+
+            await manager.LaunchTasksAsync();
             return this;
         }
 
@@ -140,13 +132,25 @@ private GeneralUpdateBootstrap AddListener<TArgs>(Action<object, TArgs> callback
         }
 
         private void OnMultiDownloadStatistics(object sender, MultiDownloadStatisticsEventArgs e)
-        => EventManager.Instance.Dispatch(sender, e);
+        {
+            var message = GetPacketHash(e.Version);
+            GeneralTracer.Info($"Multi download statistics, {message}[BytesReceived]:{e.BytesReceived} [ProgressPercentage]:{e.ProgressPercentage} [Remaining]:{e.Remaining} [TotalBytesToReceive]:{e.TotalBytesToReceive} [Speed]:{e.Speed}");
+            EventManager.Instance.Dispatch(sender, e);
+        }
 
         private void OnMultiDownloadCompleted(object sender, MultiDownloadCompletedEventArgs e)
-        => EventManager.Instance.Dispatch(sender, e);
+        {
+            var message = GetPacketHash(e.Version);
+            GeneralTracer.Info($"Multi download completed, {message}[IsComplated]:{e.IsComplated}.");
+            EventManager.Instance.Dispatch(sender, e);
+        }
 
         private void OnMultiDownloadError(object sender, MultiDownloadErrorEventArgs e)
-        => EventManager.Instance.Dispatch(sender, e);
+        {
+            var message = GetPacketHash(e.Version);
+            GeneralTracer.Error($"Multi download error {message}.", e.Exception);
+            EventManager.Instance.Dispatch(sender, e);
+        }
 
         private void OnMultiAllDownloadCompleted(object sender, MultiAllDownloadCompletedEventArgs e)
         {

src/c#/GeneralUpdate.Core/GeneralUpdateOSS.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics;
 using System.Text.Json;
 using System.Threading.Tasks;
+using GeneralUpdate.Common.Internal;
 using GeneralUpdate.Common.Internal.Bootstrap;
 using GeneralUpdate.Common.Internal.JsonContext;
 using GeneralUpdate.Common.Shared.Object;
@@ -43,7 +44,8 @@ private static async Task BaseStart()
             }
             catch (Exception exception)
             {
-                throw new Exception(exception.Message + "\n" + exception.StackTrace);
+                GeneralTracer.Error("The BaseStart method in the GeneralUpdateOSS class throws an exception.",exception);
+                throw exception;
             }
         }