chore: clean up residual directories, add Core references, trim readiness (#348)#349
Merged
Merged
Conversation
…ness - Deleted src/c#/GeneralUpdate.Common/ (dead code after project merge) - Deleted src/c#/GeneralUpdate.ClientCore/ (dead code after project merge) - Updated Bowl, Drivelution, Extension to reference Core directly (removed file-link compilation to deleted Common directory) - Fixed namespace references: GeneralUpdate.Common → GeneralUpdate.Core in Bowl, Drivelution, Extension source files - Added IsTrimmable + EnableTrimAnalyzer to Core.csproj - Upgraded Extension Microsoft.Extensions packages to 10.0.1 Closes #348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes residual source directories and updates all projects to directly reference Core instead of file-linking to the deleted Common directory. Adds trim/AOT readiness annotations.
Changes
Deleted (dead code after #312 merge)
src/c#/GeneralUpdate.Common/— 80 filessrc/c#/GeneralUpdate.ClientCore/— 14 filesUpdated projects (file-link elimination)
Namespace fixes
GeneralUpdate.Core.Shared.*→GeneralUpdate.Core.*(Core's flat namespace)GeneralUpdate.Core.Internal.*→GeneralUpdate.Core.*GeneralUpdate.Core.FileBasic→GeneralUpdate.Core.FileSystemTrim/AOT readiness
<IsTrimmable>true</IsTrimmable>+<EnableTrimAnalyzer>true</EnableTrimAnalyzer>Verification
dotnet build src/c#/GeneralUpdate.slnx— 0 errorsCloses #348