Skip to content

refactor: Phase 3 — async backup wrappers (#358) #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JusterZhu wants to merge 1 commit into from
Closed

refactor: Phase 3 — async backup wrappers (#358) #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/c#/GeneralUpdate.Core/FileSystem/StorageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,21 @@ private static void CopyDirectory(string sourceDir, string targetDir)
}
}

#endregion

public static async System.Threading.Tasks.Task BackupAsync(string sourcePath, string backupPath, System.Collections.Generic.IReadOnlyList<string> directoryNames)
{
await System.Threading.Tasks.Task.Run(() => Backup(sourcePath, backupPath, directoryNames)).ConfigureAwait(false);
}

public static async System.Threading.Tasks.Task RestoreAsync(string backupPath, string sourcePath)
{
await System.Threading.Tasks.Task.Run(() => Restore(backupPath, sourcePath)).ConfigureAwait(false);
}

public static async System.Threading.Tasks.Task CleanBackupAsync(string installPath, int keepVersions = 3)
{
await System.Threading.Tasks.Task.Run(() => CleanBackup(installPath, keepVersions)).ConfigureAwait(false);
} #endregion
Comment on lines +234 to +248

#region Private Methods

Expand Down Expand Up @@ -312,7 +326,21 @@ public static IReadOnlyList<BackupInfo> ListBackups(string installPath)
.ToList();
}

#endregion

public static async System.Threading.Tasks.Task BackupAsync(string sourcePath, string backupPath, System.Collections.Generic.IReadOnlyList<string> directoryNames)
{
await System.Threading.Tasks.Task.Run(() => Backup(sourcePath, backupPath, directoryNames)).ConfigureAwait(false);
}

public static async System.Threading.Tasks.Task RestoreAsync(string backupPath, string sourcePath)
{
await System.Threading.Tasks.Task.Run(() => Restore(backupPath, sourcePath)).ConfigureAwait(false);
}

public static async System.Threading.Tasks.Task CleanBackupAsync(string installPath, int keepVersions = 3)
{
await System.Threading.Tasks.Task.Run(() => CleanBackup(installPath, keepVersions)).ConfigureAwait(false);
} #endregion
}

/// <summary>Backup configuration.</summary>
Expand Down