Skip to content

feat: disable backup feature by default #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JusterZhu merged 2 commits into from
Jun 11, 2026
Merged

feat: disable backup feature by default #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a38a5ac
feat: disable backup feature by default
JusterZhu Jun 11, 2026
a0a50e2
fix: update backup tests to match new default (false)
JusterZhu Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/c#/GeneralUpdate.Core/Configuration/Option.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public override bool Equals(object? obj)

public static Option<bool?> PatchEnabled { get; } = ValueOf<bool?>("PATCH", true);

public static Option<bool?> BackupEnabled { get; } = ValueOf<bool?>("BACKUP", true);
public static Option<bool?> BackupEnabled { get; } = ValueOf<bool?>("BACKUP", false);

public static Option<bool> Silent { get; } = ValueOf<bool>("ENABLESILENTUPDATE", false);

Expand Down
2 changes: 1 addition & 1 deletion src/c#/GeneralUpdate.Core/Configuration/UpdateContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public class UpdateContext : UpdateConfiguration

/// <summary>
/// Whether to back up the current version before applying an update.
/// Computed from <see cref="Option.BackupEnabled" />, defaults to <c>true</c>.
/// Computed from <see cref="Option.BackupEnabled" />, defaults to <c>false</c>.
/// </summary>
public bool? BackupEnabled { get; set; }

Expand Down
4 changes: 2 additions & 2 deletions src/c#/GeneralUpdate.Core/FileSystem/StorageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,9 +727,9 @@ public sealed class BackupConfig
public List<string> Directories { get; set; } = new();

/// <summary>
/// Whether the backup feature is enabled. Default is <c>true</c>.
/// Whether the backup feature is enabled. Default is <c>false</c>.
/// </summary>
public bool Enabled { get; set; } = true;
public bool Enabled { get; set; } = false;
}

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions tests/CoreTest/Configuration/UpdateContextWiringTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ public void Options_VerifyChecksum_DefaultIsTrue()
=> Assert.True(Option.VerifyChecksum.DefaultValue);

[Fact]
public void Options_BackupEnabled_DefaultIsTrue()
=> Assert.True(Option.BackupEnabled.DefaultValue);
public void Options_BackupEnabled_DefaultIsFalse()
=> Assert.False(Option.BackupEnabled.DefaultValue);

[Fact]
public void Options_PatchEnabled_DefaultIsTrue()
Expand Down
2 changes: 1 addition & 1 deletion tests/CoreTest/Configuration/UpdateOptionsStaticTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void PatchEnabled_HasCorrectDefault()
[Fact]
public void BackupEnabled_HasCorrectDefault()
{
Assert.True(Option.BackupEnabled.DefaultValue);
Assert.False(Option.BackupEnabled.DefaultValue);
}

[Fact]
Expand Down
Loading