Skip to content

Feat/chain count threshold#532

Merged
JusterZhu merged 3 commits into
masterfrom
feat/chain-count-threshold
Jun 21, 2026
Merged

Feat/chain count threshold#532
JusterZhu merged 3 commits into
masterfrom
feat/chain-count-threshold

Conversation

@JusterZhu

Copy link
Copy Markdown
Collaborator

No description provided.

JusterZhu and others added 3 commits June 21, 2026 15:05
… fallback

Swap the single 80%-of-full-size heuristic for a two-condition strategy:
1. Chain count exceeds MaxChainBeforeFallback (default 8) → full package
2. Combined chain size >= full size → full package

Add MaxChainBeforeFallback to UpdateConfiguration (default 8), plumb it
through DownloadPlanBuilder.Build() and ClientStrategy. The new logic
stops switching to full when the chain total is only marginally below
the full size — the runtime fallback (FallbackFull) already handles
chain application failures, so an overly eager size threshold is
unnecessary.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…d-AppType tests

Code review fixes:
- Extract duplicated 'switch to full' code block into local function SwitchToFull
- Add missing MaxChainBeforeFallback mapping in ConfigurationMapper
- Add 3 mixed-AppType test cases (Client+Upgrade split scenarios)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 21, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@JusterZhu JusterZhu merged commit f642b0f into master Jun 21, 2026
2 of 3 checks passed
@JusterZhu JusterZhu deleted the feat/chain-count-threshold branch June 21, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants