fix: address Copilot review comments on PR #3#5
Merged
Conversation
…API references - Fix #1: RULES.md SetOption(Client) -> SetOption(AppType.Client) - Fix #2: RULES.md manifest.json -> generalupdate.manifest.json - Fix #3: backend-api.instructions.md add response wrapper { code, message, body } - Fix #4: troubleshoot curl endpoint /api/update/check -> POST /Upgrade/Verification - Fix #5: cursor/generalupdate-init.mdc manifest.json -> generalupdate.manifest.json - Fix #6: clinerules/01-generalupdate-init.md manifest.json -> generalupdate.manifest.json - Fix #7: troubleshoot LongPathSupport -> generic .NET long path guidance - Fix #8: troubleshoot ZipSecurity -> entry path validation behavior - Fix #9: troubleshoot SignalRRetryPolicy -> retry intent description Co-Authored-By: Claude <noreply@anthropic.com>
JusterZhu
added a commit
that referenced
this pull request
Jun 15, 2026
* fix: resolve all 10 Copilot review comments 1. SemiUrsaClientView.axaml: Remove conv:StatusToVisibleConverter refs, use CanExecute for button visibility 2. DownloadViewModels.cs: Sync VersionText on stats change, clear SpeedText when not downloading 3. RealDownloadService.cs: Replace LaunchAsync() in CheckForUpdates with direct HTTP /Upgrade/Verification call (true check-only mode) 4. FullIntegration.cs: Add missing using directives (Event, Configuration), add hash length guard for truncation, fix speed unit duplication 5. reference.md: Fix framework version table (remove .NET Framework + .NET 8 conflation, use proper target framework monikers) 6. MinimalIntegration.cs: Fix System.Version comment accuracy 7. manifest.json: Remove JSON-invalid comment block, keep pure valid JSON Co-Authored-By: Claude <noreply@anthropic.com> * fix: address Copilot review comments — API contracts, filenames, and API references - Fix #1: RULES.md SetOption(Client) -> SetOption(AppType.Client) - Fix #2: RULES.md manifest.json -> generalupdate.manifest.json - Fix #3: backend-api.instructions.md add response wrapper { code, message, body } - Fix #4: troubleshoot curl endpoint /api/update/check -> POST /Upgrade/Verification - Fix #5: cursor/generalupdate-init.mdc manifest.json -> generalupdate.manifest.json - Fix #6: clinerules/01-generalupdate-init.md manifest.json -> generalupdate.manifest.json - Fix #7: troubleshoot LongPathSupport -> generic .NET long path guidance - Fix #8: troubleshoot ZipSecurity -> entry path validation behavior - Fix #9: troubleshoot SignalRRetryPolicy -> retry intent description Co-Authored-By: Claude <noreply@anthropic.com> * i18n: convert all Chinese comments and docs to English, make skills bilingual All code comments, XML docs, console log strings, UI labels, and documentation now use English (with bilingual status labels where helpful). Converted files include: - All 5 SKILL.md files (init/ui/strategy/advanced/troubleshoot) - All 6 strategy example .cs files - All 4 advanced template .cs files - All 3 project scaffold files - All 10+ UI template files (XAML/AXAML/CS) - reference.md and troubleshooting reference - All adapter files (.cursor/rules/, .clinerules/, .github/, RULES.md) Skills now support both English and Chinese-speaking developers through bilingual status labels in UI templates. Co-Authored-By: Claude <noreply@anthropic.com> * fix: resolve all 6 Copilot review comments on PR #7 1. MinimalIntegration.cs: Fix System.Version comment accuracy 2. RealDownloadService.cs: Accept _updateUrl as-is (no /Upgrade/Verification append), add tenantId, use TryGetProperty for response parsing, add productId param, lowercase platform values 3. NamedPipeIPC.cs: Use Environment.ProcessId for unique pipe name, enforce timeoutMs via linked CancellationTokenSource with TimeoutException 4. clinerules/05: Fix curl appType from 1 to 0, fix manifest path --------- Co-authored-by: JusterZhu <juster.zhu@example.com> Co-authored-by: Claude <noreply@anthropic.com>
JusterZhu
added a commit
that referenced
this pull request
Jun 15, 2026
* fix: resolve all 10 Copilot review comments 1. SemiUrsaClientView.axaml: Remove conv:StatusToVisibleConverter refs, use CanExecute for button visibility 2. DownloadViewModels.cs: Sync VersionText on stats change, clear SpeedText when not downloading 3. RealDownloadService.cs: Replace LaunchAsync() in CheckForUpdates with direct HTTP /Upgrade/Verification call (true check-only mode) 4. FullIntegration.cs: Add missing using directives (Event, Configuration), add hash length guard for truncation, fix speed unit duplication 5. reference.md: Fix framework version table (remove .NET Framework + .NET 8 conflation, use proper target framework monikers) 6. MinimalIntegration.cs: Fix System.Version comment accuracy 7. manifest.json: Remove JSON-invalid comment block, keep pure valid JSON * fix: address Copilot review comments — API contracts, filenames, and API references - Fix #1: RULES.md SetOption(Client) -> SetOption(AppType.Client) - Fix #2: RULES.md manifest.json -> generalupdate.manifest.json - Fix #3: backend-api.instructions.md add response wrapper { code, message, body } - Fix #4: troubleshoot curl endpoint /api/update/check -> POST /Upgrade/Verification - Fix #5: cursor/generalupdate-init.mdc manifest.json -> generalupdate.manifest.json - Fix #6: clinerules/01-generalupdate-init.md manifest.json -> generalupdate.manifest.json - Fix #7: troubleshoot LongPathSupport -> generic .NET long path guidance - Fix #8: troubleshoot ZipSecurity -> entry path validation behavior - Fix #9: troubleshoot SignalRRetryPolicy -> retry intent description * i18n: convert all Chinese comments and docs to English, make skills bilingual All code comments, XML docs, console log strings, UI labels, and documentation now use English (with bilingual status labels where helpful). Converted files include: - All 5 SKILL.md files (init/ui/strategy/advanced/troubleshoot) - All 6 strategy example .cs files - All 4 advanced template .cs files - All 3 project scaffold files - All 10+ UI template files (XAML/AXAML/CS) - reference.md and troubleshooting reference - All adapter files (.cursor/rules/, .clinerules/, .github/, RULES.md) Skills now support both English and Chinese-speaking developers through bilingual status labels in UI templates. * fix: resolve all 6 Copilot review comments on PR #7 1. MinimalIntegration.cs: Fix System.Version comment accuracy 2. RealDownloadService.cs: Accept _updateUrl as-is (no /Upgrade/Verification append), add tenantId, use TryGetProperty for response parsing, add productId param, lowercase platform values 3. NamedPipeIPC.cs: Use Environment.ProcessId for unique pipe name, enforce timeoutMs via linked CancellationTokenSource with TimeoutException 4. clinerules/05: Fix curl appType from 1 to 0, fix manifest path --------- Co-authored-by: JusterZhu <juster.zhu@example.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies all 9 Copilot review suggestions from PR #3 review.
Changes
SetOption(Client)→SetOption(AppType.Client)manifest.json→generalupdate.manifest.json{ code, message, body }wrapper/api/update/check→POST /Upgrade/Verificationmanifest.json→generalupdate.manifest.jsonmanifest.json→generalupdate.manifest.jsonLongPathSupport→ generic .NET long path guidanceZipSecurity→ entry path validationSignalRRetryPolicy→ retry intent descriptionCloses #3 (review comments)