Skip to content

feat: GeneralUpdate Claude Code 技能套件(完整版) (#7)#8

Merged
JusterZhu merged 1 commit into
mainfrom
pr-base
Jun 15, 2026
Merged

feat: GeneralUpdate Claude Code 技能套件(完整版) (#7)#8
JusterZhu merged 1 commit into
mainfrom
pr-base

Conversation

@JusterZhu

Copy link
Copy Markdown
Contributor
  • fix: resolve all 10 Copilot review comments
  1. SemiUrsaClientView.axaml: Remove conv:StatusToVisibleConverter refs, use CanExecute for button visibility
  2. DownloadViewModels.cs: Sync VersionText on stats change, clear SpeedText when not downloading
  3. RealDownloadService.cs: Replace LaunchAsync() in CheckForUpdates with direct HTTP /Upgrade/Verification call (true check-only mode)
  4. FullIntegration.cs: Add missing using directives (Event, Configuration), add hash length guard for truncation, fix speed unit duplication
  5. reference.md: Fix framework version table (remove .NET Framework + .NET 8 conflation, use proper target framework monikers)
  6. MinimalIntegration.cs: Fix System.Version comment accuracy
  7. manifest.json: Remove JSON-invalid comment block, keep pure valid JSON
  • fix: address Copilot review comments — API contracts, filenames, and API references
  • i18n: convert all Chinese comments and docs to English, make skills bilingual

All code comments, XML docs, console log strings, UI labels, and documentation now use English (with bilingual status labels where helpful).

Converted files include:

  • All 5 SKILL.md files (init/ui/strategy/advanced/troubleshoot)
  • All 6 strategy example .cs files
  • All 4 advanced template .cs files
  • All 3 project scaffold files
  • All 10+ UI template files (XAML/AXAML/CS)
  • reference.md and troubleshooting reference
  • All adapter files (.cursor/rules/, .clinerules/, .github/, RULES.md)

Skills now support both English and Chinese-speaking developers through bilingual status labels in UI templates.

  1. MinimalIntegration.cs: Fix System.Version comment accuracy
  2. RealDownloadService.cs: Accept _updateUrl as-is (no /Upgrade/Verification append), add tenantId, use TryGetProperty for response parsing, add productId param, lowercase platform values
  3. NamedPipeIPC.cs: Use Environment.ProcessId for unique pipe name, enforce timeoutMs via linked CancellationTokenSource with TimeoutException
  4. clinerules/05: Fix curl appType from 1 to 0, fix manifest path

* fix: resolve all 10 Copilot review comments

1. SemiUrsaClientView.axaml: Remove conv:StatusToVisibleConverter refs,
   use CanExecute for button visibility
2. DownloadViewModels.cs: Sync VersionText on stats change,
   clear SpeedText when not downloading
3. RealDownloadService.cs: Replace LaunchAsync() in CheckForUpdates
   with direct HTTP /Upgrade/Verification call (true check-only mode)
4. FullIntegration.cs: Add missing using directives (Event, Configuration),
   add hash length guard for truncation, fix speed unit duplication
5. reference.md: Fix framework version table (remove .NET Framework + .NET 8
   conflation, use proper target framework monikers)
6. MinimalIntegration.cs: Fix System.Version comment accuracy
7. manifest.json: Remove JSON-invalid comment block, keep pure valid JSON

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: address Copilot review comments — API contracts, filenames, and API references

- Fix #1: RULES.md SetOption(Client) -> SetOption(AppType.Client)
- Fix #2: RULES.md manifest.json -> generalupdate.manifest.json
- Fix #3: backend-api.instructions.md add response wrapper { code, message, body }
- Fix #4: troubleshoot curl endpoint /api/update/check -> POST /Upgrade/Verification
- Fix #5: cursor/generalupdate-init.mdc manifest.json -> generalupdate.manifest.json
- Fix #6: clinerules/01-generalupdate-init.md manifest.json -> generalupdate.manifest.json
- Fix #7: troubleshoot LongPathSupport -> generic .NET long path guidance
- Fix #8: troubleshoot ZipSecurity -> entry path validation behavior
- Fix #9: troubleshoot SignalRRetryPolicy -> retry intent description

Co-Authored-By: Claude <noreply@anthropic.com>

* i18n: convert all Chinese comments and docs to English, make skills bilingual

All code comments, XML docs, console log strings, UI labels, and documentation
now use English (with bilingual status labels where helpful).

Converted files include:
- All 5 SKILL.md files (init/ui/strategy/advanced/troubleshoot)
- All 6 strategy example .cs files
- All 4 advanced template .cs files
- All 3 project scaffold files
- All 10+ UI template files (XAML/AXAML/CS)
- reference.md and troubleshooting reference
- All adapter files (.cursor/rules/, .clinerules/, .github/, RULES.md)

Skills now support both English and Chinese-speaking developers
through bilingual status labels in UI templates.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: resolve all 6 Copilot review comments on PR #7

1. MinimalIntegration.cs: Fix System.Version comment accuracy
2. RealDownloadService.cs: Accept _updateUrl as-is (no /Upgrade/Verification append),
   add tenantId, use TryGetProperty for response parsing, add productId param,
   lowercase platform values
3. NamedPipeIPC.cs: Use Environment.ProcessId for unique pipe name,
   enforce timeoutMs via linked CancellationTokenSource with TimeoutException
4. clinerules/05: Fix curl appType from 1 to 0, fix manifest path

---------

Co-authored-by: JusterZhu <juster.zhu@example.com>
Co-authored-by: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 15, 2026 18:41
@JusterZhu JusterZhu merged commit 46537da into main Jun 15, 2026
1 check passed
@JusterZhu JusterZhu removed the request for review from Copilot June 15, 2026 18:41
@JusterZhu JusterZhu deleted the pr-base branch June 15, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: GeneralUpdate Claude Code 技能套件 — 5 个技能覆盖完整集成生命周期

1 participant