- Changes to how we resize buffers for HTTP requests

- Attach additional metadata + tags to sentry issues

Author: x64-dev

GeneralsMD/Code/GameEngine/Include/GameNetwork/GeneralsOnline/HTTP/HTTPRequest.h

@@ -86,7 +86,7 @@ class HTTPRequest
 	CURLcode m_pendingCURLCode = CURL_LAST;
 #endif
 
-	const size_t g_initialBufSize = (1024 * 4); // 4KB
+	const size_t g_initialBufSize = (1024 * 32); // 32KB
 
 	bool m_bNeedsProgressUpdate = false;
 	bool m_bIsStarted = false;

GeneralsMD/Code/GameEngine/Source/GameNetwork/GeneralsOnline/HTTP/HTTPRequest.cpp

@@ -73,6 +73,12 @@ void HTTPRequest::StartRequest()
 
 void HTTPRequest::OnResponsePartialWrite(std::uint8_t* pBuffer, size_t numBytes)
 {
+	if (m_currentBufSize_Used + numBytes > m_vecBuffer.size())
+	{
+		size_t newSize = std::max<size_t>(m_vecBuffer.size() * 2, m_currentBufSize_Used + numBytes);
+		m_vecBuffer.resize(newSize);
+	}
+
 	// do we need a buffer resize?
 	if (m_currentBufSize_Used + numBytes >= m_vecBuffer.size())
 	{

GeneralsMD/Code/GameEngine/Source/GameNetwork/GeneralsOnline/OnlineServices_Init.cpp

@@ -847,6 +847,25 @@ void NGMP_OnlineServicesManager::InitSentry()
 	sentry_options_set_database_path(options, strDumpPath.c_str());
 	sentry_options_set_release(options, "generalsonline-client@110725");
 
+	// local player info
+	int64_t userID = -1;
+	std::string strDisplayname = "Unknown";
+	NGMP_OnlineServices_AuthInterface* pAuthInterface = NGMP_OnlineServicesManager::GetInterface<NGMP_OnlineServices_AuthInterface>();
+	if (pAuthInterface != nullptr)
+	{
+		userID = pAuthInterface->GetUserID();
+		strDisplayname = pAuthInterface->GetDisplayName();
+	}
+	std::string strUserID = std::format("{}", userID);
+
+
+	sentry_value_t userinfoVal = sentry_value_new_object();
+	sentry_value_set_by_key(userinfoVal, "user_id", sentry_value_new_int32(userID));
+	sentry_value_set_by_key(userinfoVal, "user_displayname", sentry_value_new_string(strDisplayname.c_str()));
+	sentry_set_context("user_info", userinfoVal);
+
+	sentry_set_tag("user_id", strUserID.c_str());
+	sentry_set_tag("user_displayname", strDisplayname.c_str());
 
 #if _DEBUG
 	sentry_options_set_debug(options, 1);