Fix: Correctly format UnicodeString using format_va

seer-by-sentry[bot] · web-flow · commit a858efde399a · 2025-11-11T17:19:40.000Z
diff --git a/Generals/Code/GameEngine/Source/GameClient/GameText.cpp b/Generals/Code/GameEngine/Source/GameClient/GameText.cpp
@@ -1374,7 +1374,7 @@ UnicodeString GameTextManager::fetchOrSubstituteFormatVA( const Char *label, con
 	if (exists)
 	{
 		UnicodeString strFormat;
-		strFormat.format_va(strFormat.str(), args);
+		strFormat.format_va(str.str(), args);
 		str = strFormat;
 	}
 	else
diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/GameText.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/GameText.cpp
@@ -1374,7 +1374,7 @@ UnicodeString GameTextManager::fetchOrSubstituteFormatVA( const Char *label, con
 	if (exists)
 	{
 		UnicodeString strFormat;
-		strFormat.format_va(strFormat.str(), args);
+		strFormat.format_va(str.str(), args);
 		str = strFormat;
 	}
 	else

Original file line number	Diff line number	Diff line change
`@@ -1374,7 +1374,7 @@ UnicodeString GameTextManager::fetchOrSubstituteFormatVA( const Char *label, con`
`1374`	`1374`	`if (exists)`
`1375`	`1375`	`{`
`1376`	`1376`	`UnicodeString strFormat;`
`1377`		`- strFormat.format_va(strFormat.str(), args);`
	`1377`	`+ strFormat.format_va(str.str(), args);`
`1378`	`1378`	`str = strFormat;`
`1379`	`1379`	`}`
`1380`	`1380`	`else`