bugfix(loadscreen): Prevent null dereference in ChallengeLoadScreen::init from invalid campaign/mission#506
Draft
seer-by-sentry[bot] wants to merge 1 commit into
Draft
Conversation
…init from invalid campaign/mission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLIENT-33Q, where the game would crash in
AsciiString::AsciiStringduringChallengeLoadScreen::init.Root Cause:
The
ChallengeLoadScreen::initfunction (Core/GameEngine/Source/GameClient/GUI/LoadScreen.cpp:930) would attempt to dereferencecampaign->m_nameandmission->m_generalNamewithout proper null checks. WhileDEBUG_ASSERTCRASHwas present, it is compiled out in release builds, allowing null pointers returned byTheCampaignManager->getCurrentCampaign()orTheCampaignManager->getCurrentMission()to proceed. This led to anEXCEPTION_ACCESS_VIOLATION_READwhen theAsciiStringcopy constructor tried to read from invalid memory (offset 0xa0).This scenario typically occurred when
GameLogic::startNewGamewas invoked vialogicMessageDispatcherwith an uninitialised or stale campaign state.Solution:
TheCampaignManager,campaign, andmissionat the beginning ofChallengeLoadScreen::init. If any are null, the function now logs aDEBUG_CRASHmessage (visible in release builds) and returns early, preventing the dereference.mission->m_generalNameto ensure it's not empty before use.TheChallengeGeneralsand thegeneralPlayer/generalOpponentpointers returned by its lookup functions.TheCampaignManager->getCurrentMission()on line 956 with the already validatedmissionlocal, ensuring consistency and preventing another potential null dereference.These changes ensure that
ChallengeLoadScreen::initgracefully handles cases where campaign or mission data is not properly set up, preventing crashes in release builds.Fixes CLIENT-33Q